From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D7CC0044D for ; Mon, 16 Mar 2020 08:15:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7631E20722 for ; Mon, 16 Mar 2020 08:15:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B7QUWfZ2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7631E20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4A406B0003; Mon, 16 Mar 2020 04:15:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFA606B0005; Mon, 16 Mar 2020 04:15:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C10226B0007; Mon, 16 Mar 2020 04:15:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A81D66B0003 for ; Mon, 16 Mar 2020 04:15:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 723278E41 for ; Mon, 16 Mar 2020 08:15:31 +0000 (UTC) X-FDA: 76600516062.29.cup35_4d4a126c2bf2a X-HE-Tag: cup35_4d4a126c2bf2a X-Filterd-Recvd-Size: 5604 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 08:15:31 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id j4so8047752qkc.11 for ; Mon, 16 Mar 2020 01:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=F/i4UURiGEiDmJWiySfSNZr+o1KHFsCHgdng66n03Q0=; b=B7QUWfZ2p0iHwX6wNgX6U4yztQAMGDAiU1KFSHsaBYgSKDV+Kdl+8H155Lfmbg+9o/ TxGbcBBwEqOPQ/B/w6jAG6N0rUQpjSNA+s/F/Tud+SRpVnYFph4gVet/kfh28qnd9zQt +zSo6COsT5fR35kjG2HJUXBsYVrX9cRZUknKCS7W5sr1GYRTBMEC1QpOzQ7viSl+n2pN cGaEg2tPimuaF7sbPikYKrNGerAbRU77SHD6nW+mqtjD7aZXVr2oYClwzswetpGkUdY6 ldrXWz4oCSqcw2vqUL3VtrVAEe7+21fSUUt9pt7RqkY8U0lRZc6KjarLjC7fRfr6wPSh YpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=F/i4UURiGEiDmJWiySfSNZr+o1KHFsCHgdng66n03Q0=; b=pZjadhWCi3ok9UCs+ssqrnwrV+EIldaI70vQ9lXwZ4eMa9yajuqg/9JuKyOgtoTJLA q56P6L2jkdh0Ra3/bZIEyrbccTpUI817+7zU3ZdsWbt1zQJ547nyW9EZz8GGRmd5LBRy FA3wv1KLPxvl1osjWJyu6HcqFrrF+jB54LF9SZ22dIC3P8G1UAIhr1Vf0fTuGsLX0Zhp xrfh3D/RGQji5u2d5Gvav0OfaF31wRejjm4fALnaquB2KFwk6bU4aaS2xHy7mqpYMqDU NqTPwx0C3EcjUolGQ3owXr1eZY7mwxXQSJ7r2yRyhuKEPlvciCQ9Pgfoh9XChLI1WmG1 qDmQ== X-Gm-Message-State: ANhLgQ3EUa9Sv93RTEG38BHkNVaEub4NuG37c9QI82qwWoBS08jHonb9 +BGysU/fE8tigNQorLLKp8YKR++Y/D5+2P7/Nuc= X-Google-Smtp-Source: ADFU+vtuhvzirDhMCsmE4l39TWh2tgFAp6304DDB1OcJOZvmemJgfuS7i39szr9xiMsVL2Kk2XCoJDL/oQcWR3C4GH0= X-Received: by 2002:a37:546:: with SMTP id 67mr24213408qkf.272.1584346530319; Mon, 16 Mar 2020 01:15:30 -0700 (PDT) MIME-Version: 1.0 References: <20200311110237.5731-2-srikar@linux.vnet.ibm.com> <20200311115735.GM23944@dhcp22.suse.cz> <20200312052707.GA3277@linux.vnet.ibm.com> <5e5c736a-a88c-7c76-fc3d-7bc765e8dcba@suse.cz> <20200312131438.GB3277@linux.vnet.ibm.com> <61437352-8b54-38fa-4471-044a65c9d05a@suse.cz> <20200312161310.GC3277@linux.vnet.ibm.com> <20200313110440.GA25144@linux.vnet.ibm.com> <06be5908-9af6-2892-0333-e9558b2cf474@suse.cz> In-Reply-To: <06be5908-9af6-2892-0333-e9558b2cf474@suse.cz> From: Joonsoo Kim Date: Mon, 16 Mar 2020 17:15:19 +0900 Message-ID: Subject: Re: [PATCH 1/3] powerpc/numa: Set numa_node for all possible cpus To: Vlastimil Babka Cc: Srikar Dronamraju , Sachin Sant , Michal Hocko , Linus Torvalds , LKML , Linux Memory Management List , Mel Gorman , "Kirill A. Shutemov" , Andrew Morton , linuxppc-dev , Christopher Lameter , Joonsoo Kim , Kirill Tkhai , Michael Ellerman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 3=EC=9B=94 13=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 8:38, V= lastimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 3/13/20 12:04 PM, Srikar Dronamraju wrote: > >> I lost all the memory about it. :) > >> Anyway, how about this? > >> > >> 1. make node_present_pages() safer > >> static inline node_present_pages(nid) > >> { > >> if (!node_online(nid)) return 0; > >> return (NODE_DATA(nid)->node_present_pages); > >> } > >> > > > > Yes this would help. > > Looks good, yeah. > > >> 2. make node_to_mem_node() safer for all cases > >> In ppc arch's mem_topology_setup(void) > >> for_each_present_cpu(cpu) { > >> numa_setup_cpu(cpu); > >> mem_node =3D node_to_mem_node(numa_mem_id()); > >> if (!node_present_pages(mem_node)) { > >> _node_numa_mem_[numa_mem_id()] =3D first_online_node; > >> } > >> } > >> > > > > But here as discussed above, we miss the case of possible but not prese= nt nodes. > > For such nodes, the above change may not update, resulting in they stil= l > > having 0. And node 0 can be only possible but not present. Oops, I don't read full thread so miss the case. > So is there other way to do the setup so that node_to_mem_node() returns = an > online+present node when called for any possible node? Two changes seems to be sufficient. 1. initialize all node's _node_numa_mem_[] =3D first_online_node in mem_topology_setup() 2. replace the node with online+present node for _node_to_mem_node_[] in set_cpu_numa_mem(). static inline void set_cpu_numa_mem(int cpu, int node) { per_cpu(_numa_mem_, cpu) =3D node; + if (!node_present_pages(node)) + node =3D first_online_node; _node_numa_mem_[cpu_to_node(cpu)] =3D node; } #endif With these two change, we can safely call node_to_mem_node() anywhere. Thanks.