From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by kanga.kvack.org (Postfix) with ESMTP id 06F75828DF for ; Thu, 14 Jan 2016 11:20:44 -0500 (EST) Received: by mail-ob0-f182.google.com with SMTP id ba1so497339806obb.3 for ; Thu, 14 Jan 2016 08:20:44 -0800 (PST) Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com. [2607:f8b0:4003:c06::243]) by mx.google.com with ESMTPS id r63si8265843oia.54.2016.01.14.08.20.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Jan 2016 08:20:43 -0800 (PST) Received: by mail-oi0-x243.google.com with SMTP id e195so21479012oig.2 for ; Thu, 14 Jan 2016 08:20:43 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <1452749069-15334-1-git-send-email-iamjoonsoo.kim@lge.com> <1452749069-15334-4-git-send-email-iamjoonsoo.kim@lge.com> Date: Fri, 15 Jan 2016 01:20:43 +0900 Message-ID: Subject: Re: [PATCH 03/16] mm/slab: remove the checks for slab implementation bug From: Joonsoo Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , Jesper Dangaard Brouer , Linux Memory Management List , LKML 2016-01-15 0:23 GMT+09:00 Christoph Lameter : > On Thu, 14 Jan 2016, Joonsoo Kim wrote: > >> Some of "#if DEBUG" are for reporting slab implementation bug >> rather than user usecase bug. It's not really needed because slab >> is stable for a quite long time and it makes code too dirty. This >> patch remove it. > > Maybe better convert them to VM_BUG_ON() or so? It's one possible solution but I'd like to make slab.c clean as much as possible. Nowadays, SLAB code isn't changed so much, therefore I don't think we need to keep them. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org