From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com [209.85.217.169]) by kanga.kvack.org (Postfix) with ESMTP id 75DEF6B0070 for ; Tue, 27 Jan 2015 20:34:02 -0500 (EST) Received: by mail-lb0-f169.google.com with SMTP id f15so16222592lbj.0 for ; Tue, 27 Jan 2015 17:34:01 -0800 (PST) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com. [2a00:1450:4010:c04::22e]) by mx.google.com with ESMTPS id u1si2895434lal.25.2015.01.27.17.33.59 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 27 Jan 2015 17:34:00 -0800 (PST) Received: by mail-lb0-f174.google.com with SMTP id f15so16225243lbj.5 for ; Tue, 27 Jan 2015 17:33:59 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1422406862.32234.1.camel@ellerman.id.au> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> <20150120230150.GA14475@cloud> <20150120160738.edfe64806cc8b943beb1dfa0@linux-foundation.org> <20150122014550.GA21444@js1304-P5Q-DELUXE> <20150122144147.019eedc41f189eac44c3c4cd@freescale.com> <20150122212017.4b7032d52a6c75c06d5b4728@freescale.com> <1421987091.24984.13.camel@ellerman.id.au> <20150126132222.6477257be204a3332601ef11@freescale.com> <1422406862.32234.1.camel@ellerman.id.au> Date: Wed, 28 Jan 2015 10:33:59 +0900 Message-ID: Subject: Re: [PATCH v3] powerpc/mm: fix undefined reference to `.__kernel_map_pages' on FSL PPC64 From: Joonsoo Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Michael Ellerman Cc: Kim Phillips , Akinobu Mita , Konstantin Khlebnikov , Rik van Riel , Linux Memory Management List , josh@joshtriplett.org, LKML , Jens Axboe , Minchan Kim , Al Viro , Johannes Weiner , Sasha Levin , Joonsoo Kim , linuxppc-dev , Andrew Morton , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood 2015-01-28 10:01 GMT+09:00 Michael Ellerman : > On Mon, 2015-01-26 at 13:22 -0600, Kim Phillips wrote: >> arch/powerpc has __kernel_map_pages implementations in mm/pgtable_32.c, and >> mm/hash_utils_64.c, of which the former is built for PPC32, and the latter >> for PPC64 machines with PPC_STD_MMU. Fix arch/powerpc/Kconfig to not select >> ARCH_SUPPORTS_DEBUG_PAGEALLOC when CONFIG_PPC_STD_MMU_64 isn't defined, >> i.e., for 64-bit book3e builds to use the generic __kernel_map_pages() >> in mm/debug-pagealloc.c. >> >> LD init/built-in.o >> mm/built-in.o: In function `kernel_map_pages': >> include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' >> include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' >> include/linux/mm.h:2076: undefined reference to `.__kernel_map_pages' >> Makefile:925: recipe for target 'vmlinux' failed >> make: *** [vmlinux] Error 1 >> >> Signed-off-by: Kim Phillips >> --- >> v3: >> - fix wording for hash_utils_64.c implementation pointed out by >> Michael Ellerman >> - changed designation from 'mm:' to 'powerpc/mm:', as I think this >> now belongs in ppc-land >> >> v2: >> - corrected SUPPORTS_DEBUG_PAGEALLOC selection to enable >> non-STD_MMU_64 builds to use the generic __kernel_map_pages(). > > I'd be happy to take this through the powerpc tree for 3.20, but for this: > >> depends on: >> From: Joonsoo Kim >> Date: Thu, 22 Jan 2015 10:28:58 +0900 >> Subject: [PATCH] mm/debug_pagealloc: fix build failure on ppc and some other archs > > I don't have that patch in my tree. > > But in what way does this patch depend on that one? > > It looks to me like it'd be safe to take this on its own, or am I wrong? > Hello, These two patches are merged to Andrew's tree now. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org