From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5002DC77B7C for ; Sat, 13 May 2023 03:20:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5ADB6B0071; Fri, 12 May 2023 23:20:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0B026B0072; Fri, 12 May 2023 23:20:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3D26B0074; Fri, 12 May 2023 23:20:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F4E06B0071 for ; Fri, 12 May 2023 23:20:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A36F1A0B6E for ; Sat, 13 May 2023 03:20:27 +0000 (UTC) X-FDA: 80783778894.12.45D198A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 4DE1A180007 for ; Sat, 13 May 2023 03:20:25 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IX7VQb4Z; spf=pass (imf16.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683948025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vvEWNqYSSMDXli0yp49rbVhAD8TwSyx7ZJuCpGSqY6U=; b=hOlXlC2p3Hfhse6xFrmumagcDtdRbr1b3YDFfgP/7nOyPVb+gcvk6ECZebxmVRbs1HHbYB g0kyGNFYumbKQX6BSJpsb5UA8jl1b4rnG6irr78/pDZTGSr3WQ2xabKgnjkWlnQduVRIIv +zTL7KYEMcz1NK4pIj9pAjzjic9pZ4E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683948025; a=rsa-sha256; cv=none; b=Ojp9QP+eLSyZIkCyHncwmlD2yFA983jdof4LM4qEK92ljoZaPjxZ87lfme8StpBpGtV3lM BFDIUJaRAnJs+HlaUkiiyNrF5wt0XA5d7+aO5agr6SdmSz6xl3OB6P2Z7x5+kSxQK7JpJE 8Chc4GruqI5lRv+cEimayU4AO92TeEs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=IX7VQb4Z; spf=pass (imf16.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 607F761129 for ; Sat, 13 May 2023 03:20:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8E7BC4339C for ; Sat, 13 May 2023 03:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683948023; bh=h35C6Fa/IubA/XIiPYtnT6mbZ75B3FvGWhFUVnOz2GQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IX7VQb4ZkpccT3E76GzFc/0tXdUCOe78ssKsBYSYGxQO5bP/Yl84RFTNsZ2eWtpgd IqXZEsozMsn9ZuKuDPD1hYFLuBX1m/oTJeGW5SoKrhEpF8HUYZHk+z8uKO0u8XWSNc 4H4HG7zKN6Dlz979hHV8DYaeqBRulFMZxI0oRxYj5RuKLR1nVv7zGJEN0kEWl3hd+g QnStBmtdWEhAax5N9wKbcwpovcPpB5+F3EUfM37oGAevEBOwNCeyczz1NfdZGE6thj W1qZZsOvOBHyKjyEM0qqBDMp04TcWiZwQ3WZsZtC7PFZaCu3fkuscvDzeDjH36cmnh VuBxIYOTyZy4Q== Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-94f4b911570so1694123466b.0 for ; Fri, 12 May 2023 20:20:23 -0700 (PDT) X-Gm-Message-State: AC+VfDx35wwHWMFvTsp5YR2MxsnaY5XmeQGtyYyoiJtyCEWAZd+wmz3x 6k69jHVylZYCCw2yk958kHQzvlqCS5p+6NSAX8w= X-Google-Smtp-Source: ACHHUZ4diPanHZpH2zYp9Gi2nqVAvyLu7w1ym7rYDer4nc9PWyq7B2iX9aNWfy8GyxzB0v4O2HSGIeDkNWXrdMU3RAA= X-Received: by 2002:a17:907:3e27:b0:965:b517:89a4 with SMTP id hp39-20020a1709073e2700b00965b51789a4mr23191186ejc.56.1683948022061; Fri, 12 May 2023 20:20:22 -0700 (PDT) MIME-Version: 1.0 References: <20230509104127.1997562-1-chenhuacai@loongson.cn> <20230512165309.896e063a9398639250eab264@linux-foundation.org> In-Reply-To: <20230512165309.896e063a9398639250eab264@linux-foundation.org> From: Huacai Chen Date: Sat, 13 May 2023 11:20:10 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH RFC] kthread: Unify kernel_thread() and user_mode_thread() To: Andrew Morton Cc: Huacai Chen , Luis Chamberlain , "Eric W . Biederman" , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4DE1A180007 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 9tbufm5krhs8yn1uqx74tcbf3yufgth8 X-HE-Tag: 1683948025-799586 X-HE-Meta: U2FsdGVkX1/l9+V0d7zsVnYditKqErPnbPjZYd7rQ3tKw/g5lTgJ5G9Kbg2p0m1mkktHTQfh2UYXHKzAWITQTKil/tJtDdb6WX55/1W6ydQJJlEc6Z8BQlUFxRQOmWmv/9BTTx/wM73+AHwwoIDuW0aA23n8/zgRqg5MPGnc9sYAiALqOT+QEJx28kGvjTyjbQEgdMZq5Pn+gEICwdgE0wRpq2p4yip74e6FFRwl7CyeEPYSsLzHnDs6kLMdycTemXTTHQIfViQ9Q5iKz8n3n7EsGDzBiUqesfqNrVpVvWFLt7yrGzhIMeXs5WqM4OsVVG5oJiN6WfEypWfVWKPHFJ9hG4m+WNWnbffCsm7m7OCjTZ+/Ph3UQidtLb57uVsBDTq7gVyVjAcTWn1/ONZIM51nbvVPpv1zdeIZAqJmuLv7uC5vd7aa5jTG7MrE4w/+HakZgYZN1+Ew/Pf/IaarV+jA/Sb7KRePYufgtyb7sUd1BuGmkXVgecMcrWIve/jAWB2VjrADV6BYazPA0EUPQCNDD9qNeu3jVEtZe/BINnWlud/DHbfiEwxV6eGs8cyX4EhlQBManqdfkjEOj7/VGIXChyWLNHoP3abQYCXyjPuNi3wc6Dx1pj3aXozVOFKhIau59fnFtw1D8hgYRz25Kd3ZrUoslmGZHSAfX2U9+U1ZoyBE9rd5B8H2u8Q1OSU8cBk0AoeF8WNB5f8qx+KJoGyVPpA1l+w3+Zsn+DzgZFR4EM3t5lMrcCODu+iDjxyC3j49nkr0A9sg/KB4cyJ7vtor/B065y20EDZFr+JvIpiTGRuJmxc1vkCpV4H2w4zaDVN7XiAfgm3PxqED77beyhhDXlP0crTHT1TFuJUuQmHDs5xksXnyYmSwrI0qo/woTvtn+7Nl2uVqNqBWW5Qw44TJvhc8t2ooIbqlDfyvamjVO7lhj8HBZEeYUNZ2F4AaT3JdgNHLXE+6hChR99j 5yGe6mrp mv2c9s8USKHi6zT6rXbWOmjRUTDflC+EUwT30W6d3HcDmNqdu5NaojER08UM0nO78O7dFpMbylA0FlzSolUj55d7tR2PTy4v0yiD3bzVlPenU437/fXjcFvrFyVetlWJK4S6eYlKXQOEkzGB4XsKWIc91RKRD9DV0rN6QlqecT+fDXTFbVsySQzlMwIR4ZUj8UQSc620poYDKbKb6Fx7ooH5+4nWxwbjfuKLxHyXacO0h+M4cibH6glOuavDzwt1xHO+lS1AlKOjtgu1ijQ6vJ/aL+Mk4OJdIqF6OzHqdZ278zh9o49fSzaeQRrjzo7a4tmYKRvtMe9nKdAEIIYvaWXK26S3pW3xqrmkPxJCAw2r4fNCHHGiIEFgh3l6TZSVmy1odeCnpTqI8JXfzt0dIn9lUGeDwEdnARqqB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Andrew, On Sat, May 13, 2023 at 7:53=E2=80=AFAM Andrew Morton wrote: > > On Tue, 9 May 2023 18:41:27 +0800 Huacai Chen w= rote: > > > Commit 343f4c49f2438d8 ("kthread: Don't allocate kthread_struct for ini= t > > and umh") introduces a new function user_mode_thread() for init and umh= . > > But the name is a bit confusing because init and umh are indeed kernel > > threads at creation time, the real difference is "they will become user > > processes". So let's unify the kernel_thread() and user_mode_thread() t= o > > kernel_thread() again, and add a new 'user' parameter for init and umh. > > > > ... > > > > 5 files changed, 9 insertions(+), 26 deletions(-) > > > > Less code is nice. > > > -extern pid_t user_mode_thread(int (*fn)(void *), void *arg, unsigned l= ong flags); > > + unsigned long flags, int user); > > `bool user'? OK, I will do that in the next version if the whole patch is acceptable. Huacai > >