From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A27C4345F for ; Tue, 16 Apr 2024 14:41:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3CAD6B0085; Tue, 16 Apr 2024 10:41:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BECFA6B0087; Tue, 16 Apr 2024 10:41:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D486B0088; Tue, 16 Apr 2024 10:41:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 89D916B0085 for ; Tue, 16 Apr 2024 10:41:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 423B8407C9 for ; Tue, 16 Apr 2024 14:41:42 +0000 (UTC) X-FDA: 82015658844.03.6F3A323 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf01.hostedemail.com (Postfix) with ESMTP id CD32540014 for ; Tue, 16 Apr 2024 14:41:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qDfLa4/S"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713278499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zQESYRuL5SMGYix4x2aIAnZAMAD/BmabSGUUQP7D2HA=; b=zC93wgjKDq2byblHd07g519CmebjRuxz67zKpMONf/qkScSesNNbE8xkmFxFOVWhkNpwm1 FJ+4l3/tlAEumbN7kdZB1RxfYJCTcXbeckuuDvOyW9im15Gm486SY2pTON8pKhz0Y1eSvp rz28i79LEV5BxU9dxIdKATY4qSqAwzg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="qDfLa4/S"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713278499; a=rsa-sha256; cv=none; b=bNHveugkSVO7IK9NU6tbjwf03IMVc6mbUiLNREfiULmr6ATZSvK+1QiqbAWizMGPDkyVg0 TU6jnacmodJfCWyfqccuA/I3JPTVnU4PEjgXxIWAThWzv2DtxkMkk/NeDhYUmq0zGN4wOU hon4YYX9KQ5HnNLUjfBZyUftf4C/GNk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 27534CE106B for ; Tue, 16 Apr 2024 14:41:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20A77C4AF09 for ; Tue, 16 Apr 2024 14:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713278493; bh=QFSr4wVV/e7e8YSqnMvX38E0a06A53lGWX69D6/6jlg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qDfLa4/SoBzVXvSPIGArjAyJwzvANkOpG+6enMa8kj0JbCrzyogzIIGdAf1i7TnAY tRdNhNSWae+F75GkcxfRVrAtYCBBfglk7WyCyvWs8xTzxIEY6MvDZx7wvgoRF+EYAQ 63/i43I/YJPVus+Gn81W8sXBXmeTeerG/3q2xZhN6kZKu0O6cpPy3JeqlK8IByOWNB lR0Bco6TLZ7DO+9CubDRAqQ8kgWyNZAPguiRFeW/ayvJWUh/sBTebjC1do0FpuLr9f iSNJWsllCVIsSQLTCc7aEAaZgoIdbctB30QVe0sAMutbkyCvZdUxF3WhAggBsPuQ0A mgGkgVDXABywA== Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2d82713f473so83992871fa.3 for ; Tue, 16 Apr 2024 07:41:33 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWXdERxdAyRJ9JZBT477oFVJBlH0P8qN78XA87uwtWRx0jp/A8JrFbu9VupxDQ0ki0pIykWf7OZmbAQiWgy/L9bgPY= X-Gm-Message-State: AOJu0Yz3znl+tXkcBZFqwkFAb4GZPrVVjskRIEGMnZEctjMydWiOP/ms AfG7EaByaziCiDpuXiC9n8lBJhmpRC/GzY5+mAr0Gj26HPYpRWmQIfG5rKMNXx0/mWY1YSV6PBm 74Oqm3O3p8RHf6wMFwrLYNbj+snU= X-Google-Smtp-Source: AGHT+IGN2nz/xTDmRgoYKeTLq3wairO+eDlQiHnk3PLxMapmMED08oZsVrPb0CIY2mj+wK+zCdR/PWSsYeNurFFvENw= X-Received: by 2002:a2e:9ed4:0:b0:2d9:fd90:af57 with SMTP id h20-20020a2e9ed4000000b002d9fd90af57mr9292681ljk.51.1713278491369; Tue, 16 Apr 2024 07:41:31 -0700 (PDT) MIME-Version: 1.0 References: <53d194db-c7d4-4026-9fbb-3b41de545849@app.fastmail.com> In-Reply-To: <53d194db-c7d4-4026-9fbb-3b41de545849@app.fastmail.com> From: Huacai Chen Date: Tue, 16 Apr 2024 22:41:22 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set but not used To: Arnd Bergmann Cc: David Hildenbrand , Miguel Ojeda , WANG Xuerui , Andrew Morton , Ryan Roberts , Linux-Arch , Linux-MM , linux-kernel , loongarch@lists.linux.dev, clang-built-linux Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: CD32540014 X-Stat-Signature: kocn4ynk88x16qtbomsyph831b9xooyr X-HE-Tag: 1713278498-337734 X-HE-Meta: U2FsdGVkX1+tNamPX2nijCyo5QmEnzpmU+XP6tyOhpeProBW5PhpddEGaHKJkdNhZ22KymwdcaitheSf7u16ZJGI97r+Tl6UygGTRqqBtpBm8U4guuArlHOU+B6sJlJg2sJKditZP0QGrbtKvRdMiB7ILTpboLTpQU6Vk9UWN6Vuj3361iq8xEnxaF6QN6+gXYTS9SoCxx7Z991xDzatSha2ZVAbalP8+wIs6X8oJer7pKKDBX3hFEJQ3mC7XoMEkdm+YQw6pIK2ZpD2ObH94cgjhBN3Qq28XStdAnYDZZ/O+I0tZ32KPKMg5WIRlVh+7uJcBKGuIGsAl0+B06sDuxF5bVUPvLL0GY06Q6uQMNCi2ZGq5dMepybyiXTFLvLLkFe1J5TWn7ondqHeIofnjd+J9lNlcz52AnsE5BHl8deJ/Tf5d9RCQVgeF4rZSAbcmkwHBFblA69LP49Y2TBiGmooFeZtaJPxJ5WteoUfeR4JJp4OLTEc+EumRirPzYq20VcQPLDX6Dn2zudB6EJAVWkCZztWq7Jw2Ew71gu0mi4bbRNyd6AUiXGQ5of2Jd4jPDi8hvCB1DKiosr1WNos7SWisghfE8BWuw4Ld0hzuG32eW72Ywz9OKYw/E4anIcC4GFwRvIY5rdFdjVbg3DZlFMiHyMYj7J3p58ZLOMl1TCDrVD3jIrZhGc53TfPpAwHtYRuJ37hWLefTqpGW07UA0+EMsT9WB0Td7difNKxToKcuYeIiipVQYR4qXlSlByzx4dTGA06iTEf9TRxDsR8QlslBq+nVqrBMuJIfAwJsltbEf8MEFyifhe2ne7Zp+0p38eHR5AewsAt38abF8clNdrXLm8sVGNKugrxz4kej3HMlMSpomXY5Y5OW3ES9RxZymo8rgusuc9pcctWTlj7emkMRttB8SWhRclmNRN6kpWRCh6sqLqiB/KaIfkHb7ip6PRgCix2WVdSnfyT61H /ka51G75 yImKtV0M0XZuCIqE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 10:14=E2=80=AFPM Arnd Bergmann wrot= e: > > On Tue, Apr 16, 2024, at 15:51, David Hildenbrand wrote: > > On 16.04.24 12:26, Miguel Ojeda wrote: > >> Hi David, Arnd, LoongArch, > >> > >> In a linux-next defconfig LLVM=3D1 build today I got: > >> > >> ./include/asm-generic/tlb.h:629:10: error: parameter 'ptep' set > >> but not used [-Werror,-Wunused-but-set-parameter] > >> 629 | pte_t *ptep, unsigned int nr, unsigned lo= ng address) > >> | ^ > >> > >> Indeed, in loongarch, `__tlb_remove_tlb_entry` does not do anything. > >> This seems the same that Arnd reported for arm64: > >> > >> https://lore.kernel.org/all/20240221154549.2026073-1-arnd@kernel.= org/ > >> > >> So perhaps the loongarch's one should also be changed into an static i= nline? > > > > 4d5bf0b6183f79ea361dd506365d2a471270735c is already part of v6.9-rc1. H= ow come > > we see that only now on linux-next? > > Andrew merged my patch to enable -Wextra yesterday, and it appears > that this one fell through the cracks with my testing, either I > missed the combination of loongarch with clang, or I last tested > it before your patches got merged. > > > I assume we should see the same on upstream Linux with LLVM=3D1, correc= t? > > On upstream, it only shows up with 'make W=3D1'. > > > If so, we should likely just drop that completely and rely on the > > asm-generic one: > > > > diff --git a/arch/loongarch/include/asm/tlb.h > > b/arch/loongarch/include/asm/tlb.h > > index da7a3b5b9374a..e071f5e9e8580 100644 > > --- a/arch/loongarch/include/asm/tlb.h > > +++ b/arch/loongarch/include/asm/tlb.h > > @@ -132,8 +132,6 @@ static __always_inline void invtlb_all(u32 op, u32 > > info, u64 addr) > > ); > > } > > > > -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) > > - > > static void tlb_flush(struct mmu_gather *tlb); > > Yes, this looks like the best solution, and I can confirm that this > addresses the warning on linux-next. Emmm, this should be removed in the first place because x86 removed it at 5.12... Huacai > > Tested-by: Arnd Bergmann