From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77202C001DE for ; Sun, 23 Jul 2023 14:13:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7641E6B0072; Sun, 23 Jul 2023 10:13:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 713D16B0074; Sun, 23 Jul 2023 10:13:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DCC86B0075; Sun, 23 Jul 2023 10:13:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 47F1E6B0072 for ; Sun, 23 Jul 2023 10:13:41 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 083521406E7 for ; Sun, 23 Jul 2023 14:13:41 +0000 (UTC) X-FDA: 81043069842.02.9BB5F52 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 0B61940004 for ; Sun, 23 Jul 2023 14:13:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iNdQcLV8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690121618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6HKm515/yNEry7cfB4ZQfGnXtGfVJ8CaZUSSqZOn92M=; b=rLz7tmHDCtWH2tgrwcbIKYjvPpIY5Yr7lbeIzj82wnlNbPgVCFyKXzbJuMkj2EBDtoAoTM Zpq/ZIUH5lfsZ5rSsSSTtbGwPVhlEeU1VWevYIeB2Z2D2E7v5gyVD/K+DhxvgHSHyb/z08 WIPtHWFL//4H9YOPQRzCQhXrx++t8Bk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iNdQcLV8; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690121618; a=rsa-sha256; cv=none; b=iexAhQaQ0R/b7Zai+Oe84z3qhg4zCAXXCLSLB+2Zvr6HX90krDLhnozBF8DXerTz3iIV+l eBjUpaEfWYzYtMAmdo6HOoMG3ajanAu9ykqhr++iTTgeBGeA6Ym9MFosmAtS8+XWQ5rads PhAKviThICh8NkJUWmgdxzRfFVf6uck= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CC20F60DB5 for ; Sun, 23 Jul 2023 14:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D766C433D9 for ; Sun, 23 Jul 2023 14:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690121616; bh=UNaK5accp1ZwP3ldqWX+XmypiJ0xhGUuuZsk7zhlSQw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iNdQcLV8Ep9KYJCqkmRFYgcOl0e91fePudNAaqXmkVF68b/lDZO2xPvjfSG0/EERi i1lbGU6bm8RNs0+l9o30a6tx4aKyoIodUjevyO0I4qiakbafihw7hK6/02S42mq605 SK93gjrGJqU6LgaW3ygm6z6QZ9+zzIK0TRgj9j45EPoHf4e0A7vHuOZUmhtm6Kl31F qGOQVKhe1n3ZSfm3nAzwARfERewTQwAZOddj+4sCTzWMjdRA6/CvONVgTHr3wVQsEN uFkI5cvaH/Tai6B2TBIWGC0tc054sTYfB+xYGMEXClA+ribu1vN5vaep6gVXgb2ZkK Q3dxv+Y3HRWsA== Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5221ee899a0so1275345a12.1 for ; Sun, 23 Jul 2023 07:13:36 -0700 (PDT) X-Gm-Message-State: ABy/qLZZW5SElrHOwWhPInhztZq00md8BvWuYR7F1VlBdqAcX+3xcIxk ISWl0pVFqMfp/Qbv94uVwRdS40ehjOYC3V3Q6oY= X-Google-Smtp-Source: APBJJlF81pdK1S5qyov7uXaNJT8toiXRPZCn5bAAB50MkmBHTmXN9RB2JTeu7HCmJAa15BjS1Q2ACUTR3OZuVQL59ZY= X-Received: by 2002:aa7:c459:0:b0:522:2711:871 with SMTP id n25-20020aa7c459000000b0052227110871mr1630550edr.1.1690121614807; Sun, 23 Jul 2023 07:13:34 -0700 (PDT) MIME-Version: 1.0 References: <20230615121016.3731983-1-chenhuacai@loongson.cn> In-Reply-To: From: Huacai Chen Date: Sun, 23 Jul 2023 22:13:23 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kthread: Rename user_mode_thread() to kmuser_thread() To: Luis Chamberlain , Eric Biederman Cc: Huacai Chen , Andrew Morton , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0B61940004 X-Stat-Signature: 64cfs5wap6yhschjnktb5z183jefwsr5 X-HE-Tag: 1690121617-220495 X-HE-Meta: U2FsdGVkX18PKaa3B0SsC7jiw4+SZx734KwVH5uH/B69BCtAPHRF87hX6JIYwslv3wRpq46iEAWP7jBNju3zcyb57+nQ433K/3x6D4nsevtr4T7jNvkHgADI7TsVSi4fsPSlT/ckfOwfa3vNlRUjpFfBAxJWepq5+Yu44Wx5XQfPD3yGGLT/zoQOMdXhAiG5CBFK0qcMtjPxQH0BHuy4mAWVx+Yr8j5oBLljAdauIj2KYy9kcf5I8vhuC6tx+aMiW1SlrFXlOHYeGF0pFHV8nH9iSo+tj3Mvn3hHOa+BFIcMrETF3EDCZc0rP7My/7hN6UJ8/wZzEFw079gjeQ7IzrZE+Sco+xV++esIxgWsyk+rbcg18XHurSW4vhFjVeYbqiYItB6v0BRPYp8Xe1TjREjp7luzDoD6kUKrqOpkfMhjwoobDOyZKL+DBzNdlNjyDWwTU+nkwoKWTG+RCqkoIArfqLx7mUYpsTTbvz5zeM6FXQLOPdb/S3uqv6BmkU2Z0mGcRNqHU24IjfKpbPoClpPl4MdjT9EnSQ8z5daangtsTW20jCJ23NIccc2/jDv4swM3o8hd6q3sEaV4w/TJwoV69FvW6iFRQUamBnuT/yWSrBKAUnzd6wu3rEUbc/KRIpCX357fVpZ7C+tl8gyQirM5ebcpbh78AbRPBa6hixHXgEDg7+NAcI5LQH0ALsXI76gF6HnQetJf8E2vLygVRYVNAhaXcbJ46K+DEcTWfCUyXb1+kHH8wKqC0UR52lHDDVPzxWBQc1D2eOdXAc9vUOSv6ZKYisVfBnO+OSfhwuhVKXbhh+b8Lt7ALDbZnEh3shUyGPrzDcNCkoucWAy8rrHMmAvSfzlEc2idV4PKJefAXgV4qMLqa6pgjmFe2+eoCD750PvM5F0Ct3u6N2R4MbKcmeSqcjQscW13I7RVwxOhj8SJji/5EMmnR4BvhwcsKVOA5HdSIvPUYWwD/Qi IKW2yYao WKLYe3Qsd2RQg7jQRTCyZfq4dhRYErfdm6VuaBwizcz3uJxO1Tq6iB87ImpKMkrGfMElW3XYI4bvPVzMmBL2TeK1EVDhIWibnZY8VCWDav1FWW4WvXOqYeYur1LUbNZSevzWVrIYZa/tSvLdG7gI5aJzPBpeBvns2WgcmMyWqPaZ2POWiU6EGb9jtEpgucBmFZSQSNYEeEv/7CHr5RA/r77Hpw/rpMFt2vaOsUMri9yCq2H2T1HNiUcUBAyQKafXkD7BxEUJK8TyJZBxn2aIp4f1v3eTaURAjVhyhFMs/RXbN1MIYEFTcXls9sZTzqx+ff2kCpxX2kRU8zu8begp3K95G2hWRKM1UdK8KaVxoAerPIDrzYAn1+X3zARkUkDA0EhqCNHEN9IBSGqCekg47kB51zYsXLmu5Zt8A X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Eric, On Tue, Jul 18, 2023 at 8:43=E2=80=AFPM Huacai Chen = wrote: > > Hi, Luis, > > On Sat, Jul 1, 2023 at 7:25=E2=80=AFAM Luis Chamberlain wrote: > > > > On Sun, Jun 25, 2023 at 04:55:33PM +0800, Huacai Chen wrote: > > > Friendly ping? > > > > You want to cc the folks who Nacked your patch. Until then, this > > probably can't go further. > Thank you very much. Eric and Andrew are already in the CC list, so > add Thomas now. > > My brain is a little old-fashioned so I insisted that "a thread > without mm_struct should be a kernel thread" in the previous patch. > Unfortunately this makes Eric and Thomas unhappy, I'm very sorry for > that. > > During the discussion of the previous patch I know I made some > mistakes about some basic concepts, but I also found the name > "user_mode_thread()" is somewhat confusing. I think rename it to > kmuser_thread() is better, because: > 1, it identify init and umh as user threads; > 2, it points out that init and umh are special user threads that run > in kernel mode before loading a user program. > > Sorry for my rudeness again. Excuse me, but could you please tell me what your opinion is. In my opinion a typical user thread is created by pthread_create()/sys_clone(), it is better to distinguish typical user threads from init and umh. Huacai > > Huacai > > > > Luis