From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8307FEB64DA for ; Wed, 19 Jul 2023 15:11:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C341028006A; Wed, 19 Jul 2023 11:11:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDD6428004C; Wed, 19 Jul 2023 11:11:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA50928006A; Wed, 19 Jul 2023 11:11:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9D0F228004C for ; Wed, 19 Jul 2023 11:11:18 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0C595C03BE for ; Wed, 19 Jul 2023 15:11:18 +0000 (UTC) X-FDA: 81028699836.25.4BD278B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 903DF20052 for ; Wed, 19 Jul 2023 15:06:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qqgFzyb1; spf=pass (imf03.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689779216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jx3BVc4/Aba42tkB++z3xWt67laer3kQ9sjvtzX6hiI=; b=JheMJji1Jjbd65FFayHVy+zqoAAyujZ47esTVaL56Qvgi2OsurI1ScMQGOwqur/vQEgbcW N7FFTew+1+y8ws42qm0PKXkUvShOYzkkwdPYWTVDitD93aErfpDYXiUWQwyci4fEjWB64/ q9lXJSzquEbFRlOi8McuUICC53UNncM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689779216; a=rsa-sha256; cv=none; b=sR0B0mLiHbXQE9bdzFKQm1gszciJVWn2kZATiA50XvfJxLQxZ8tjT4o2nHFDnupPEVQ+65 nQf67IKBgZ7DKeom0NmCPo4R4Msqi7VRNaDoqa+WUDF+om0AQi94SX5x9S92FLgjF92FO5 alkJV9sN2aVIplNCDdCXreovJdB9wJg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qqgFzyb1; spf=pass (imf03.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F48461737 for ; Wed, 19 Jul 2023 15:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96034C433CD for ; Wed, 19 Jul 2023 15:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779214; bh=kUIBro8VYIEkHE5j0/agoPvwIueb/Dl6A+asw1DqHtY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qqgFzyb1Q6LF7MPggU2bQnt2PduSRwyoWsnAyQPFnL7+kOVE2ZXPW1+VgUQ/m/WKN pfvUpfs4lOq1epjUqEPn0//6r6xexKUXK6rWTNZHEQtmB4K4mrT8ZAwukM52j84l+s AfF+vEDjKVEJmh8871y2yhiM8v1jASJ3EHrlLsi04qSb9k7YTGvRbo1jrhrB4MEoGK b1QRl4gwEgmmW6ITAAAXk12wZki6qonYp5+D3kLxgy99FMoNMMdYYne0K+iRS8NZ9C fdrEy7bXZrQ5Vj1XpWfo89EmiBvmQU/qrfmFtYWkvDjkoqce7gXpyHriwXSdgu3LQY nwQG6OU/D7SSA== Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-51e29ede885so9886614a12.3 for ; Wed, 19 Jul 2023 08:06:54 -0700 (PDT) X-Gm-Message-State: ABy/qLYncirhttkGENAW7hlCdvS9QHGxNik84fHc31IVdRGQx1cFqYYY wlRvo7RE6uvmfSQ9kjJoar+6S9iAOSGz9kemFM4= X-Google-Smtp-Source: APBJJlFIWF/JGtjaWiG8xG1Xidqf9LjssEXWxsrj4ORgGERwBC9Whsl8zR9B/GHY7ZNedscei3fl6EnpikXH+bdIBsA= X-Received: by 2002:aa7:c1cc:0:b0:51e:ca0:8a2e with SMTP id d12-20020aa7c1cc000000b0051e0ca08a2emr2687589edp.36.1689779212858; Wed, 19 Jul 2023 08:06:52 -0700 (PDT) MIME-Version: 1.0 References: <20230719082732.2189747-1-lienze@kylinos.cn> <20230719082732.2189747-4-lienze@kylinos.cn> In-Reply-To: From: Huacai Chen Date: Wed, 19 Jul 2023 23:06:42 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/4] KFENCE: Deferring the assignment of the local variable addr To: Marco Elver Cc: Enze Li , kernel@xen0n.name, loongarch@lists.linux.dev, glider@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, zhangqing@loongson.cn, yangtiezhu@loongson.cn, dvyukov@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sb73y9szcsbqtxhz4hbs6kmyaywdr89k X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 903DF20052 X-Rspam-User: X-HE-Tag: 1689779216-784493 X-HE-Meta: U2FsdGVkX1+a70U1OIKdqwD8V49+7VsCK3JTSdXTvUQRmNKhGcXqPlk9fRld92JHlDiVYMD313m9P0OS4pOZiooZAS9EyFyXBI2vwHdOv9yJ6eDCU8I4xCzf28Gkl5rMTujXYwk4eIT23N2/XV0Z3mq/aNyCaxvtGcDYHkMtqcZik+8fRLtCB3+KKJ6sq4K/Yru63MWhFknMpZktw6fNmQ0cLM+BLU/E0GiR9Mk1kurlMXkAp3M5GSHONEFd69X4viAHwcVFYUSqQFYptPzw3MinIAU6wKqw0JzoGUgKfRtRmIwu9wJfOVqg0WnqZA3uzpwk63JAR5xGJCIzuAsEtRVZmhTPE6dlW4288Awjr8U3sgY7nPNPpYOK3t+nt+1UyFOQqIdnzsEtPVmYMV2bKuNDeq9rAmzTRa+p0YmKxnIIDVI2qNKZ/hZfDoe2Z/ernl4eH/vDJfgj9CUbJv+VuZEPm8+zsNwNl0aazHnxo6Lcas0n/G4I7VBlF55qTCZW3WkWBs71vdtUCzmfRwnXjCxNea9BFwbXcHTXzIhjVGEH7Ahsa3KBpSYfUNqZMLVVgklR2W+QP4zlZVKWLAPv2CTLrvh7R/cmoQrOmcDSjgWQ+31zCoxQ/9HUIX3tTP+TrltMjlHUJTN0rmgSAIDkNCUjzel/XYRdWyVIyXIJd28bk7qUCGfmzrjgfYOyPZRqMC2W42y7yt8OcpbS2bVWD6J5Z231ILZ4nzR1oeacRhW2Hm3pzvIqYXxdbTkmOIKyOy42DH530vaqtxNs2caHRNvjyMkVewdrTWwjKD4Ul+6/IApMuK4bMwYVW8L+OEouhm68k0x0atE6cnNCutmxs6vebOKfAtnd8EhhGWsrcIt3HoD0BRJztWnX6iQOcJ93Y7A/wb9lwPiArr+RWthnwfh0E+HAh+BGyqCovtJBwo6ts17PTqtBVPcbGyzChLcwquvOgUYS20LqvFJxbtr 2aOmrBye ZGyDhTauy3Eih+AkiNcAhSlV9rLrYvURC6LuGDbea4HqPjC5zEuUQ2y1pvu+DOxuEb0yNBjLQTTNu32JF+G/Dak2qg30GljqHdX/ThePaHYTYWejxOK0gIArUzGuMpuBCOF9aNiFmzj2Pejax0u3y4OAFd2xjIsIwm5F5Qf2zGM8iY85y8mp2UEYxFzANvw/bs+VwUaZPOZ1WrbbaALzxby8FQhgijxXePqUPK8hMBU9idcxyKSPO84PJYg5ECjfNQ01p6zn0T/3HhXBlvqazRML689imtpaGfYqgp+veCr9AiXrT/bq4jBN0P3KTKotyIiQ2Y70w/jes7IqLF8wwGiBDujJlrYbrQ1G9Q3vniyYbOLqxTGAe6YKt/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Marco, On Wed, Jul 19, 2023 at 6:55=E2=80=AFPM Marco Elver wrot= e: > > On Wed, 19 Jul 2023 at 10:28, Enze Li wrote: > > > > The LoongArch architecture is different from other architectures. > > It needs to update __kfence_pool during arch_kfence_init_pool. > > > > This patch modifies the assignment location of the local variable addr > > in the kfence_init_pool function to support the case of updating > > __kfence_pool in arch_kfence_init_pool. > > > > Signed-off-by: Enze Li > > I think it's fair to allow this use case. > > However, please make sure that when your arch_kfence_init_pool() > fails, it is still possible to free the memblock allocated memory > properly. > > Acked-by: Marco Elver Does Acked-by means this patch can go through loongarch tree together with other patches? If this patch should go through kfence tree, then the others should wait for some time. Huacai > > > --- > > mm/kfence/core.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > > index dad3c0eb70a0..e124ffff489f 100644 > > --- a/mm/kfence/core.c > > +++ b/mm/kfence/core.c > > @@ -566,13 +566,14 @@ static void rcu_guarded_free(struct rcu_head *h) > > */ > > static unsigned long kfence_init_pool(void) > > { > > - unsigned long addr =3D (unsigned long)__kfence_pool; > > + unsigned long addr; > > struct page *pages; > > int i; > > > > if (!arch_kfence_init_pool()) > > - return addr; > > + return (unsigned long)__kfence_pool; > > > > + addr =3D (unsigned long)__kfence_pool; > > pages =3D virt_to_page(__kfence_pool); > > > > /* > > -- > > 2.34.1 > >