From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B36FE6B27C for ; Fri, 1 Nov 2024 13:52:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD3516B00A3; Fri, 1 Nov 2024 09:52:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAC0C6B00A4; Fri, 1 Nov 2024 09:52:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B24F56B00A5; Fri, 1 Nov 2024 09:52:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 939046B00A3 for ; Fri, 1 Nov 2024 09:52:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4DDB4404D6 for ; Fri, 1 Nov 2024 13:52:33 +0000 (UTC) X-FDA: 82737665388.12.4E55289 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 9A8A7140014 for ; Fri, 1 Nov 2024 13:52:11 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CQFnaBIg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730469070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZvnyMvVRMyJDazzHKZnXv86cYYSXYBn+vQp6fH3kQpA=; b=7FD1dCzxto4xgJIraueagBTn73wpUf+bErdqARG+h4Tucz/fLqJ1TR65HK0b1F0HaYs3Da 9+OahkcTIgW4T82+ZreT4IovpUA4B6QbLf4tmxYWQhKAQK3/XzJVn3KYxbe7OduBvEUu8I kqNs5Dc/dt5+IIZI0Udx8U+ek+0nNH8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CQFnaBIg; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf09.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730469070; a=rsa-sha256; cv=none; b=4Qz8kU8/D3wrp8VgTTrqjzKtAiQeuV4UZh+YVKhrjmIh5s/+NJau9Xit6CsGvpqD9Q3Rmh Zu6YXVQXIIYSg1KE1c3JjI30l/Kxf5W42W68BDKccjILL+4G35VUzVqg0zoxKZ82ceqM1c 5FjmT6EK/SHLmYMLvD7DASAsBNkJM38= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id F2F805C71D3 for ; Thu, 31 Oct 2024 01:12:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E867C4CED4 for ; Thu, 31 Oct 2024 01:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730337221; bh=WbRptb7FCqv60HSIIaD84GGUKPtD6/MInRYEUgylKqs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=CQFnaBIgu2VJo5I+vqPnQnQya2dHbKnwlw4s5esPxZr2KCwiPFuIEHv6DrTdVcG0P rUmRAxH/fJbdU7KBd/Qy4wplwFFJ27zTgER9Agrvdeve1v8zwMqXCZR1Xnr0Bj5HEq j40z/03nX6Rp5wiFyV6rMoYEnTtjU3wDXxoBH4c/JJtDjnMj75M+dhyA0JmJMAZm54 dLeFSXOiNPIjFQbimyrT3iQa+E7OFRUt+kvmWcpeAX+EPee1AphnyCYN/E3+genhG3 ZPeC44LCSz7ye3ZMnB/3ys4yN0lfAUY7satO3jS9ItjL8U0V0yav/Bm/V4USZgC4pN TTe9z+BWh7wpA== Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a99e3b3a411so237213066b.0 for ; Wed, 30 Oct 2024 18:13:41 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU3W4frvL9bFO4iZVC4hI6by4U2i4ZYlwQomP/e5S7CZ7Lg7UjuF35uPw9R2/C6e3yfWHHB/IGpbA==@kvack.org X-Gm-Message-State: AOJu0Yz+xqibP9bVmsjdnqKsHHy9z4EMUbmdgHg3XpcC34rMfoIOdD5x TPDnucaNGonzigHMxXhBfBPfs7nO0IaGY40yuMc67LVDTHp/WpKVmcJA6HECmXfaBhxgLz48pww SLVCIr9NhFuhIyqa4A4mEkBhprSU= X-Google-Smtp-Source: AGHT+IHNI0GAvdwr25dkpNoHJw8i/LubG55Z749FdRTKFrX6ZwKdMY40mOPZLmY7D520K17tiZfHEOM/OqdIomb8BBM= X-Received: by 2002:a17:907:97d6:b0:a9a:c57f:964b with SMTP id a640c23a62f3a-a9e55a29239mr50707566b.8.1730337219900; Wed, 30 Oct 2024 18:13:39 -0700 (PDT) MIME-Version: 1.0 References: <20241030063905.2434824-1-maobibo@loongson.cn> <20241030164123.ff63a1c0e7666ad1a4f8944e@linux-foundation.org> In-Reply-To: <20241030164123.ff63a1c0e7666ad1a4f8944e@linux-foundation.org> From: Huacai Chen Date: Thu, 31 Oct 2024 09:13:27 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] mm: define general function pXd_init() To: Andrew Morton Cc: Bibo Mao , Thomas Bogendoerfer , Andrey Ryabinin , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , WANG Xuerui Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9A8A7140014 X-Stat-Signature: dwow9beeapsxetfxye6r7yhwpk47kycr X-HE-Tag: 1730469131-579972 X-HE-Meta: U2FsdGVkX19IegaUHelID4iH98eWwVIUryuB53DsGByJXehm/BvJ9CWuCKFIAhz3b/iyf8DQSpWJ4xwDpX7kW+SyWl+/boI4loFE9zjwxcMwklbmC68QxzAebJDLW9jygCr7TV/L+4n4G5R7j9ZGC4BaXatgcUWPDRtj/+G6V5hlnQZG98iJ9H5IflSy+x/4Cz32QDQ2/HAzuZjq3cXsBQwulORAnYQD0PztrEBAGWA86Kj4SmsLBRUYu0B89UFzd0Via6V3yGYchMQm580DJvlZuge+PsX9ppudN6l3QQqj5vxh86cOny3U+J3ak9Iw5H5GQMmovvidizGqTAJLEo0JZlF7pDcq1EdTWMWOgtvZChPwrJ32b173zN+PbUKCs71cvz+J/qgEQNPbLfYbuiL1eNattr6oHaKTXVJFw5rDtu28KVd6SEUdXyC0yWr5sqdsmST8k2EIU133uTwGG5GIQIX5bwx0BwFKTCKxXKPIrA4Iq2jC1TQtNx5P11VCau2LSfaooSgAEmPYcW4SMamuo7yemSvDbb7+vUcbHiQy0aVC1SlIx2YNjl56wmqSIpgCD+XSsSt6TQQ+4kFQ6sAHBsl0uV6Lu6xTq/ul6lLldferOtycB/1IvUByi/5vyAmI9ckv1dXvL1r5r7auSev7B9Oqf6CN5QSc9kTjw8O4MAm90Br5EhA7GEwmn4wUWkbtr8DUybCXUE2equaNByiYGs1yLwP8Ft+XBAFuZ9ukA9827J/IKxOHlrJ0yT41p2eybAvAFBacpskLkbpwoKrzVRodANNdegpfm6UJMVDmPvjKJ4gtPoSjkOnbUTcndiKkfc+EPx2uaa4yPWy/RbCeJB5Ml/4OUXpEEB46OMo9tytUuSRmYBFLx5Uat3OKDbGd2W15zlWzr8murGsaApSv8nLWyXjDs1RweMySI8hEwt6ROLPCgy1RAB51NvROY8fOMF+eN9OJGT7nuq+ wwWclntB rZL7dAx1w1PQ5kJCO7Z+DJ5RtFnn2CvbA9qU+shKsq0f8BzrdKdBSVDIfSqi6Ahx4rQz/+a9P+ghgAwwvngnqFj8eD0ytNZd/1CPmb9RGLNqeMC1cID+ZdbFXV2qmKLUKGh02OI7XQ9dZIsBThZ9GQRR5+f4tySlkA6j050NYQHuleiRh5DLniIVaamx1sBbczF1tXoFhG4SaEDPwupVmAKosW5pg6jp4dKRQKNOmVbQJSxh9MoFcPlkP+9oojpfgWIlwWJxtwExjAuJSkShHIgYbO3dsn7zcbRtjWzqUtjHqWO38G3UmcMNA4tiAe8qlwvCy70qGDwW8TqkJy6qiPe4FTsFiMCmf/mZRSBjmFDF3l6Yd3uuP6alhI+UbOZESoy1ssqZ60neT86xH72nDlLwMemvyIPy+gr7/7qwtTPlQiPirSYPrP0RGuuZuJ1sEnx5BO4yU/9nuve5LlelRnWfrWy/enyq5ZyQng3I9m1i54eQ42Egb+fH1nw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Andrew, On Thu, Oct 31, 2024 at 7:41=E2=80=AFAM Andrew Morton wrote: > > On Wed, 30 Oct 2024 14:39:05 +0800 Bibo Mao wrote: > > > --- a/arch/loongarch/include/asm/pgtable.h > > +++ b/arch/loongarch/include/asm/pgtable.h > > @@ -267,8 +267,11 @@ extern void set_pmd_at(struct mm_struct *mm, unsig= ned long addr, pmd_t *pmdp, pm > > * Initialize a new pgd / pud / pmd table with invalid pointers. > > */ > > extern void pgd_init(void *addr); > > +#define pud_init pud_init > > extern void pud_init(void *addr); > > +#define pmd_init pmd_init > > extern void pmd_init(void *addr); > > +#define kernel_pte_init kernel_pte_init > > extern void kernel_pte_init(void *addr); > > Nitlet: don't we usually put the #define *after* the definition? > > void foo(void); > #define foo() foo() Is there any convention or documents about this? In kernel code there are both before definitions and after definitions. Huacai > > ? > > > >