From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3974BC3ABC0 for ; Thu, 8 May 2025 01:55:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A97166B000A; Wed, 7 May 2025 21:55:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A47D96B0082; Wed, 7 May 2025 21:55:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9329F6B0083; Wed, 7 May 2025 21:55:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 741E56B000A for ; Wed, 7 May 2025 21:55:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B953E121BFC for ; Thu, 8 May 2025 01:55:08 +0000 (UTC) X-FDA: 83418072696.25.6651325 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id A4E0E1A0008 for ; Thu, 8 May 2025 01:55:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AzCEBrb+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746669306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=77EUK+jeCmnkifA4gzRjO6kmu01ocXTl/1cDZdsH0r0=; b=PEfxWHFLlzKnkV1xjZwilKegkhWZDWZI3rlPPZtxrSJy+VSrvM8PvmJ57hvrk0wmlb0rOZ 5PNOq9A+DLa7J3cjOxMIW5dbKk4Za/zavoeua32PoWl7gEBtsCfVtwksYVZHdsoy0kKtPr JmfWFVYLh8QzxOLiiU6Fx3mSYaP+gkw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746669306; a=rsa-sha256; cv=none; b=Xw8NRt6+z+HpStPGR1k2wKeUV9ds3UKghY7jdZP0Yg4B5gUntLXB6PBfTb0Y7B0ocwAoO7 uszsr4XOuwxYSAmHawsp2JoMZmfUj3+cmIaPP8pshBNNmjEVwzhzcQhJ2h7XtKrwDsblge iCuVQYEG6FQhH9c7Dk1DJCYd6FlRCiw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AzCEBrb+; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 673825C61C8 for ; Thu, 8 May 2025 01:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27219C4AF0E for ; Thu, 8 May 2025 01:55:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1746669305; bh=dl8wVcGUAen/exJkdPhBaHcEBBDlS+cM57wzUTccp/M=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AzCEBrb+2+BGZAriyg4my509RMs1eMI1LjJAhrphhd1a7lDGMUO//7+QVcRnHLT4e Sp0c7biPacap9Z1yGEDSX9CarAo2WIem5XYKwH/SOgI0WpuVIqdBXlGeP2kQ+wSZM5 zt0NoJ6Gnpej2ga2SOAMRlfYu7q4FAs6GO0IlRnfcgTTXnc76UedlLH1jFM5N1VJze SvlAq7VYrQr8WPpEMQfKcyguHIbY3M0Q9vxldUUu22yxD1JhACYjcNruUTp80Uu6jE G1F1ZVn8KuhPe//CbfK5fK2Nm+ISnLCrbGUjjuYFrGCBx/tfukvW0KFLIAPC6Ub4MW 8wlgRkvKDZA1g== Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5fbf007ea38so752702a12.3 for ; Wed, 07 May 2025 18:55:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV8YiaWTNIIZ/4K8ie4wK3NVwml8BvJm1LBViSM0WyKBLile792yH5AIBwIUnMy9lou2DmrHvajvA==@kvack.org X-Gm-Message-State: AOJu0YxKCGDyd2a70+qZ2oNjDAvhf7Lr9RXxgLw1MpAwYn3i7EToIR9k aey2rNcKj31I0BsD+PGWPgPbfOMT/IGypz+RA63gjAcqZyX8TU8sXl9FJwHytANvRQ1faKi58gy yC7QHy+IMVbp3Iaq85KAWj54vncY= X-Google-Smtp-Source: AGHT+IEzDcJ6Nujut03djLclbitM7VBQzX0IBIyzj1ZBgppTbip23+rin6MUYH6E+Qcco7dc7IzqUs7M1xomeOXYdGk= X-Received: by 2002:a05:6402:278f:b0:5f7:eafe:76d5 with SMTP id 4fb4d7f45d1cf-5fbe9dcacd1mr4590146a12.8.1746669302688; Wed, 07 May 2025 18:55:02 -0700 (PDT) MIME-Version: 1.0 References: <20250506062245.3816791-1-wangyuquan1236@phytium.com.cn> <20250507172436.00003888@huawei.com> In-Reply-To: From: Huacai Chen Date: Thu, 8 May 2025 09:54:52 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: ATxdqUE3P4RAx1nfYhEUwbSeEb96FNfeucjUlb2LWwN0o3G9NpKb3XLjAO5Afs8 Message-ID: Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk To: Yuquan Wang Cc: Jonathan Cameron , dan.j.williams@intel.com, rppt@kernel.org, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A4E0E1A0008 X-Rspam-User: X-Stat-Signature: uz3zckrsud8fup5exfzd3j9iry3uoyzw X-HE-Tag: 1746669306-488662 X-HE-Meta: U2FsdGVkX18kvqwg3Q9qq3OrnZdWn+Siz6N5I8btTvHUD0tL2nOcZKbqGyyHaXm9XfE3ji3N06CFVN+v0+aiGtJQ+fTf6OPvkZuvpHR3G1zmkgk+Kiol60OerX7BNRnWGo7VQjsQlaqB+xisWi1E+4Vswi3e/Gf5P5ckkhBlYzsgrOFJgZ5FItpZXkVo3mXgHB/dpeyOUJeKQ7+xWm+n8TtqfTYjeEW8D0D2fajD2GSi+XT4Oi/NS93PfHtsdZQ+fQRYzD3X+8EIIK/sTn87vV79lkKjinEuJ9fFOCzSOmdn9TBU/3kdDcuW67lyRLmHOyHzfFvzL2Z/HItOpP0KR1WYifczqCNmJhLLig6bi6crUahaR7hhaGi4n1c31Vu8m0/iBbboZWiQKKIt700xvPP3S3B7HjU6jtfX1w+/Yks2YPd7gHrMK38wt5pI0s+c6G3a2RLOMzterNhpDz2q/qkAe58Go3hXbIkEq/AlIgeC28IZs2piTOqVjiTy4hK8BZ9lQFOk53goA6gI4VUZpSzYQ0YlaR/FCYmDT4n/WT8dvWIFEpdChUmS3cMMnrYWAStWXyrOlXzfa/TLq3J0IX3uoizPJbKj8oeKQCrYUif09N0MGJXPrC2wrqPPNC47fq8KJ6fT1FUE4Bnue0WOqRKM+VlLoZ/FtC7/+1SkvMMSKJ6FjakL6rZ8dd8vKl9qV8cV58MOpS9xv27R1UBpCc23q9I0V3DWDdPKKwxyUmPVqb/+XMIKE0qyTWCEGGXm0VJ6I3CQrfMwUxHTrUQdC8BVtOv+2uNL9hCV8oVCPTWyNRHSY13trEMoKhTCiOxFpNcRp49Dqs2QzJ4UlQHnai2WGMPBb1d0giKuQEt7oOp78+Msa/QBN/7olTKWUHn6ulgJPRU8gTtkd/3m6OC5PENb6uVEzggGLMUIOLbabwg3dcyzhX8hwor2FtUDLLhcsaQNsf66gVfUFYLYtkK AE18qZMM YTBBIJYxwC1QgGXbc/EftpvDsiopBq0XHLVkB+u2RMEdfspB+kiRPYB7Bc5Dafm4vq6ntU5pQ4/Mmk4vOZTyrZPjUoTYlTLg3U7b07GcM40jJci/Y0QzS6M0Ti5FoclqkQfZEmIFFshzcIol1gKuarNqaW+yyx4U9SIUrvGpgxRMllOeyoxKb71mFEu38K4zwFU1IjZM0/nIPxLH2u30lualNjbQod4FS2LYrhHlgrr8bkRjF2+ivbwbM91/OMh9qwj3itUGSDjc/2asRa8Zx9kDk1eT541vsn7Rs2pxfaE0f8DbhPywh4qEFCqcD0nhJb+tFGMHCHjO6dTOG/wfOI2zi9qYJdQ6QzdRnwIEOGE9WBDk6izf4HDmKfx73qUpt7uGrKCpiYCqXYSgmTpjQGFMHH4W2kZCWEBYB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 8, 2025 at 9:47=E2=80=AFAM Yuquan Wang wrote: > > On Wed, May 07, 2025 at 05:24:36PM +0100, Jonathan Cameron wrote: > > On Tue, 6 May 2025 14:22:45 +0800 > > Yuquan Wang wrote: > > > > > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > > > with the expectation that numa_cleanup_meminfo moves them to > > > numa_reserved_meminfo. There is no need for that indirection when it = is > > > known in advance that these unpopulated ranges are meant for > > > numa_reserved_meminfo in support of future hotplug / CXL provisioning= . > > > > > > Introduce and use numa_add_reserved_memblk() to add the empty CFMWS > > > ranges directly. > > > > > > Signed-off-by: Yuquan Wang > > This is v2 take 2. There were tags on the previous version (pre longar= ch > > change). > > > > Reviewed-by: Jonathan Cameron > > > > (Also Dan Williams). > > > > Easiest option when this happens is spin a v3 with a change log to > > say the loongarch issue is resolved and you picked up tags. > > > Hi Jonathan, > > Thanks for your tips. Would this v2 version trigger the kernel test > robot? It seems like only a new version of patch would trigger that. > I would publish v3 of this patch as soon as possible. The kernel test robot operates on linux-next, so there's probably no errors= now. Huacai > > Yuquan > > > > > --- > > > > > > Changes in v2 (Thanks to Dan & Alison): > > > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi= _parse_cfmws() > > > - Add comments to describe the usage of numa_add_reserved_memblk() > > > - Updating the commit message to clarify the purpose of the patch > > > > > > By the way, "LoongArch: Introduce the numa_memblks conversion" is in = linux-next. > > > > > > drivers/acpi/numa/srat.c | 2 +- > > > include/linux/numa_memblks.h | 1 + > > > mm/numa_memblks.c | 22 ++++++++++++++++++++++ > > > 3 files changed, 24 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > > > index 0a725e46d017..751774f0b4e5 100644 > > > --- a/drivers/acpi/numa/srat.c > > > +++ b/drivers/acpi/numa/srat.c > > > @@ -453,7 +453,7 @@ static int __init acpi_parse_cfmws(union acpi_sub= table_headers *header, > > > return -EINVAL; > > > } > > > > > > - if (numa_add_memblk(node, start, end) < 0) { > > > + if (numa_add_reserved_memblk(node, start, end) < 0) { > > > /* CXL driver must handle the NUMA_NO_NODE case */ > > > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %= d [mem %#llx-%#llx]\n", > > > node, start, end); > > > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblk= s.h > > > index dd85613cdd86..991076cba7c5 100644 > > > --- a/include/linux/numa_memblks.h > > > +++ b/include/linux/numa_memblks.h > > > @@ -22,6 +22,7 @@ struct numa_meminfo { > > > }; > > > > > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > > > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > > > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi= ); > > > > > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > > > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > > > index ff4054f4334d..541a99c4071a 100644 > > > --- a/mm/numa_memblks.c > > > +++ b/mm/numa_memblks.c > > > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u= 64 end) > > > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > > > } > > > > > > +/** > > > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_m= eminfo > > > + * @nid: NUMA node ID of the new memblk > > > + * @start: Start address of the new memblk > > > + * @end: End address of the new memblk > > > + * > > > + * Add a new memblk to the numa_reserved_meminfo. > > > + * > > > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk ins= tances > > > + * against memblock_type information and moves any that intersect re= served > > > + * ranges to numa_reserved_meminfo. However, when that information i= s known > > > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_= memblk > > > + * to numa_reserved_meminfo directly. > > > + * > > > + * RETURNS: > > > + * 0 on success, -errno on failure. > > > + */ > > > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > > > +{ > > > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo= ); > > > +} > > > + > > > /** > > > * numa_cleanup_meminfo - Cleanup a numa_meminfo > > > * @mi: numa_meminfo to clean up > > >