From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4A2C0015E for ; Tue, 25 Jul 2023 07:46:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A68E86B0071; Tue, 25 Jul 2023 03:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A16596B0074; Tue, 25 Jul 2023 03:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 905116B0075; Tue, 25 Jul 2023 03:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7DE746B0071 for ; Tue, 25 Jul 2023 03:45:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4D570B24BF for ; Tue, 25 Jul 2023 07:45:59 +0000 (UTC) X-FDA: 81049350438.30.B9BDCDE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 6CB47A0008 for ; Tue, 25 Jul 2023 07:45:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JIOOxeLK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690271157; a=rsa-sha256; cv=none; b=Z909Q9F6Uc4HhbC6jxWFwo4UVSXMkSQQojxGc40c82TBuycyB7u4T7+70U8Ip7OC5NaBMF WKMPN+opu3b0q88ddc+4cQFq3eFFW7pnw3Dmz0dkjAPFBw4VLhgQD4DR2ju+0YH3VmVZTz l7fnsDYhTpab8bzB7VCgWYiyHnoivaI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JIOOxeLK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690271157; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HXyJI6vPSlUN/DrKOtEDI9CVxKqG5iQYUqOSzPkyMug=; b=2xb5DrXbHHayqqjnM8InSExyvv3453cn/pPOrBtXwalPI5FVvXz9Rk4imrro/xl+7E7zl0 oBXYhY15pwsTrAelED0LIeToEADCmYN+l30WESib58wnbE7oAX+Who6ok9sapTwkz4bdS0 xN1KWLjgySHNzpVHYhB9SF5xDmsKuZc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 633BD612BF for ; Tue, 25 Jul 2023 07:45:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8B6EC433CD for ; Tue, 25 Jul 2023 07:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690271155; bh=u2Ib2q+xk6FkAYZSHHu2M1mth/rmXUEtcCpK5STMStg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JIOOxeLKy6vZBQm3LC+erkiN719t+zoQCV+gXVkynadNXULF2F/s50VVTAxNoJK3s NLQTtp5GRH1zhXjYi7F05FPQ+HSkwX3WsLrgF6xV3OESeQrNHkiFs3mSW2lhCxRyXG VVDvSvOkPu+XbHEr3A5GkmtuZaO8BZavS4wpv51ymOqV+d15tB0m7GStaYdz2V0D2c f+g23dVJg3l32lw5LdivO7cbFe8qtupqkYMNDvSgYhUKAp7pllcfuQGNXRMq0tFX/Y hegaXplPrwEHgpaU8jL1cCm1jX/s5anC4jcLUE6tSo0UlKgk9NGbM35gaLvvVD+BrU EqJKcCcYt+8PA== Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-52227884855so3573129a12.1 for ; Tue, 25 Jul 2023 00:45:55 -0700 (PDT) X-Gm-Message-State: ABy/qLY1iw21Wr0wPx8qAhwRtoO6V5lMzch/ee2sMh4A8bEm9qfMVrpD yxmjp1RLnjyEHr6Sr5p01Pn6XWuAxzgnX4gUl30= X-Google-Smtp-Source: APBJJlHq8W0Fb/nKDtR6sWbkKiD8lnNoP7SKahPjwfMJfWgOhgIpYjMg/dkZNMrI2DGrq2jP3F28bBfyBEuuseCLwBA= X-Received: by 2002:a17:906:76d8:b0:99b:8c6f:f3ab with SMTP id q24-20020a17090676d800b0099b8c6ff3abmr6993697ejn.13.1690271153978; Tue, 25 Jul 2023 00:45:53 -0700 (PDT) MIME-Version: 1.0 References: <20230725061451.1231480-1-lienze@kylinos.cn> <20230725061451.1231480-4-lienze@kylinos.cn> In-Reply-To: <20230725061451.1231480-4-lienze@kylinos.cn> From: Huacai Chen Date: Tue, 25 Jul 2023 15:45:43 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/4 v2] KFENCE: Defer the assignment of the local variable addr To: Enze Li Cc: kernel@xen0n.name, loongarch@lists.linux.dev, glider@google.com, elver@google.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, zhangqing@loongson.cn, yangtiezhu@loongson.cn, dvyukov@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 6CB47A0008 X-Stat-Signature: u8kp8c5i15md353y54d6tgif5s6t99wu X-HE-Tag: 1690271157-975099 X-HE-Meta: U2FsdGVkX19k2CWOoZ/fUlHgABKrvSzm36m4a7qZr86XuccZMH3qop9Q67y3t+Znq4TigN9t6IZmrcoyKvdouZp/155OhqLz8nvddWyCK3L4TkqIJ6vpFLI0fdcegzC9hpuXXK22G1db37b0XqcRAalPoD7I1nmyfOId8Y4Bv1Mls93LpjysMXebxNJh8o3jMRYIcZAEEqH/4jStxLg8jNpvIqzhR6Xz3ZkjJR3SrC4oyiJGKX0XswJ+hADzyv3GKpOLgMx4GSmeUFA7bTVrkWz9i7j19YhajTRUJuutk7mvvzIJANtRIRgYpOD84eke7/AczJZbwTxQTcE+eCMy0Fdef5kTMx0WKi5QwwMLbEarARcA1FLJwfAH7trDSJAflegOtUztJlmS5B/rBchiAY2YdwpGfZuVOytvJBWEJSSwRFrfAA32WAbw3uHZN4Y3d5xJRyXOdZRRhFGN5pS8QNa82hn4UKwD4bZJ5RXmF6KNsDugCGh8rCjjv22NpD7rP0Bmgt/DfzNEaJslUm9jkj2sPm7KCLWFsNoHJGvmYvdSvEB8QFshehldU5FFwLJQc8MR9NnY7syw+8l7i5nWmK6yNCW41zbVBYixS5PSmbqnDcRYFJHT4Y2nv/2pLaAX9rWpB4HFqC9gpNedNz6jLVapmGZT/YbykIoF8lBOfxdBTLVvG86/dTD+qAoSsb9mZtrCGv9vuluqwuwMFo9d+ixpUHhifQZQS2ZEMBxsal63+QMPVl6SoTJdqPj9JzDwirF9F+lwpf9Z/arvu1bkKOIwyqbE/psscU8qyT9N/OJA4K7P82YYjMXAaqZT6CUwnOnFDadNSq08Imzs7KnLc/OdLFBo/JwaodFBpgWU4XXcOW6MxUCnTEQ5U6X3j1nTG+4RFeVcSI2sMzqbLWVdZm28BWPTlsVR5o+IzDeWa4Yo50d21sBubs4oHQyC8WH25XiAmX+18yxP9zdvhDz eKt3YsM8 MBVjebvP2S4dnZngUMrkoOh/KEbnOoSq9H7f4KQ2PEyHpJENRO9sDg4b57DX1dzCJnXVsXq/mOTcloWimBMxqPbKSjdvIWt7T8z1AhMKpD6sy+bfyLHmmEvkoBVUT2pW3GUK0SGCI6hMeH/nFyft0qQqVZSP9ZjQKp3UrCKTBXW6wIgcdEHA6VN4CGHo/hWcYShMVJnfD//JmkN5Fr8+cG9bx3K1aRBU1UgtW5tcj1CYEBMTuptVZ0Hvy8VS1aNGqbH/i69yHBZDmeBzP/WSwolKqLsptWFQ4/d7Hb5yzl4KGTZyRR1+yTSj1Oi4L79TBjQeExqYX8Xjws4Q3pdjkri83jg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Enze, This patch is a preparation for LoongArch KFENCE support, so it is better to move to the first patch. Huacai On Tue, Jul 25, 2023 at 2:15=E2=80=AFPM Enze Li wrote: > > The LoongArch architecture is different from other architectures. > It needs to update __kfence_pool during arch_kfence_init_pool(). > > This patch modifies the assignment location of the local variable addr > in the kfence_init_pool function to support the case of updating > __kfence_pool in arch_kfence_init_pool(). > > Signed-off-by: Enze Li > Acked-by: Marco Elver > --- > mm/kfence/core.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/mm/kfence/core.c b/mm/kfence/core.c > index dad3c0eb70a0..e124ffff489f 100644 > --- a/mm/kfence/core.c > +++ b/mm/kfence/core.c > @@ -566,13 +566,14 @@ static void rcu_guarded_free(struct rcu_head *h) > */ > static unsigned long kfence_init_pool(void) > { > - unsigned long addr =3D (unsigned long)__kfence_pool; > + unsigned long addr; > struct page *pages; > int i; > > if (!arch_kfence_init_pool()) > - return addr; > + return (unsigned long)__kfence_pool; > > + addr =3D (unsigned long)__kfence_pool; > pages =3D virt_to_page(__kfence_pool); > > /* > -- > 2.34.1 > >