From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E3AD3C549 for ; Fri, 18 Oct 2024 04:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 673006B0082; Fri, 18 Oct 2024 00:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 61FF76B0083; Fri, 18 Oct 2024 00:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E7F56B0085; Fri, 18 Oct 2024 00:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 309DE6B0082 for ; Fri, 18 Oct 2024 00:23:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EE8C91202A0 for ; Fri, 18 Oct 2024 04:23:46 +0000 (UTC) X-FDA: 82685429778.26.F2F26E5 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 52E3D8000D for ; Fri, 18 Oct 2024 04:23:35 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZIxFjafi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729225401; a=rsa-sha256; cv=none; b=bIkaRXecz59i+2pZLEHcekFAFFMiOzdvzM7+GA0Mb71jnKt7dzINQQZvayYNAVXVNdauD3 q/HMtvkmQuGZHJ6Yn3tyON4ZZ08+hheGneVnCBqaj6tZa9AKaEcT+Whn52NhDWkvk8ofQ+ Iq/UoyKqMZsIx6cBBqKqx3sxTCxTm+0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZIxFjafi; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729225401; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jj6Qji/GiZwLJhiCHjm/SCf+zhBagtHMR0HqL1vKib0=; b=BxLpTpmMsj7w5l19pE1Dd7VwyUIgn8qxvTguQIn5UePvpgJUT10k2W16+HpENrNOPSE89r WWu94vdfwnBR/2GDhehisPmHw1BvtEd+cn835Vet5oI5nPmmdSxnstKVu/DLN/dj6IzD/5 onYc18fPoPHLIaVtXaudDlC7MWXai4Y= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 00DFE5C59AA for ; Fri, 18 Oct 2024 04:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18495C4CEC3 for ; Fri, 18 Oct 2024 04:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729225434; bh=oaEjeBufgsxokyx9Vgf9icLrk7eQUprT5p8xylj9jQ4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ZIxFjafiStjWRCp1d+r4ob90W6qayNqtcr+hjNUqbzryHANDjlBxDH5aki8W2YGeJ m48SjnoKiIrA8KrTW166zl7ZZsmV0mOhNt6LiGMvtgSCAX/a4ivv5IynxyfIu1fwPW 4wlOWptTkeGyVjwfEzW1b9wDuGdNod7Cnr6YF4gb/rYyPS2C04yLgcJ+r1wWD48y5U RdY5AKHMpqP1e/+eq6ZPUDV5wh3qzjqBlD0SRcwXSCGIAyNFYkD1YhY8wXqUbW7Vnl sIni7zRidxMRkOMcfoR05pzQpwyB5DZS2T1kMdn1RkofXc8vu/qKMMnanksCnKIlP8 35muu/zQsIFYw== Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a9a156513a1so198836566b.0 for ; Thu, 17 Oct 2024 21:23:54 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVCaOP6gvIZoOQU02LBd30gb5cUIjkr+0GojdBwqCj3ReijfViO8qCk67pN7CStmSNEb2h93t2JMg==@kvack.org X-Gm-Message-State: AOJu0Yzu1TE04rgvCbFBj4frxLxlVHSQsM3HF3T/PtvMIJ6Dlbe8qDXo B2d27CB+QgfF9wYhDSd/mhU89yqCUZZzUMLKe8R8m/3MSvYTvSdw8YgSdVWEjb8BBfeyG+rs+KR vrc7zjbp/Tcx/SDvOI7SIb6Vpg60= X-Google-Smtp-Source: AGHT+IHlmSDtooChjX+SfN2XokMXSg6kFIwiNyf8JhZt7ra0ZAiOpoQKFbNGZY3OeR8v7A0kztDyylIdvYDkvIt8u/k= X-Received: by 2002:a17:906:c113:b0:a9a:1092:b10d with SMTP id a640c23a62f3a-a9a69b7af5dmr66882666b.33.1729225432608; Thu, 17 Oct 2024 21:23:52 -0700 (PDT) MIME-Version: 1.0 References: <20241014035855.1119220-1-maobibo@loongson.cn> <20241014035855.1119220-2-maobibo@loongson.cn> In-Reply-To: From: Huacai Chen Date: Fri, 18 Oct 2024 12:23:39 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] LoongArch: Set initial pte entry with PAGE_GLOBAL for kernel space To: maobibo , wuruiyang@loongson.cn Cc: Andrey Ryabinin , Andrew Morton , David Hildenbrand , Barry Song , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 7dwa3airi8e3k1mnzernap7k8xzxp4om X-Rspamd-Queue-Id: 52E3D8000D X-Rspamd-Server: rspam02 X-HE-Tag: 1729225415-401316 X-HE-Meta: U2FsdGVkX1/MN1n/Fg1r9h/gJw0d6yyk2UcTYdDYbal4wSTdKCauqND67MWNi54RLUQ6EGcv6K3g9Svi2Z6xtNmUzb2NvM98iFK+R+27HZHSyAxUsYTFLjKsWI/fo8FqMcpCpl1Ejmb7VbGuZkWCsEeTx2LOogCUYZAs3tEkxtQsGB3+d4J+n4gDaWP9p9WXqP9vF1nB95PDRhKRwYU5XeR2QJASu94uRjL0FwiekioFwG1mToeuVMDj1lRkCVLeevZiseOfscxvS2BlM66HbwMLrv7MkSyluPcUo3gK318iUYa0EEmJWHJmtsKOJGuCXwrwJgiIpGjhB9ej12kX7lX9cuv7TQarYsJDHsOQtOGv/rYo8qn8KDH0d+0NdRT3nAOdjYM1Smg6dsHI9crwbBLlprq6miKnanS5EOf5CvazZKiJ772usI/MqdwYrfqolrMkCMxCCW8isN00wXuls6sTP2kCD72A1GwVV7DWkW9yBiD+KnYJ0nsdXAaGd1IU/ikU4eBsqP21Hc21PWFroRDNUinoyuchldzd/CUN+ume5c797LE5YhtZhXrXv7FwbDBca8gVgIKl3cmHm+abv4NUXhsUK8SygdX0wf7cKLNppj2dI/ux4OzQl3TiWyFEiUuaSvloB6FJmY6843TDwVLJgQUhhYW+ZTpRUfVNP1H4fNTB7zxj/lW79vzViSZLtXaCOkb/ouyIpu1cBL7WuOslWfFl6sFwXPc0GIeqAHFpRxfGNycbhNgd6iHcoFZMmzYJvnEc7/OU2iX7uY9iq9ceSLnUmUd+4GWDILGM1erPP3z8sTg4q/+Y2TugWvDS3RTlW2OY5K/meWfeVj7tN9VU9EWD3EcEF6WCe2SkoG8/GJsHO4c6A9J2C/sbos7SkA3WJNzYXBTy6g1jD6Sq+kv2XTuXlV53TMApQqaWdomTgHhmoCZOT4UoE+yEdmn1T/glKHp3a9y9OhAnPf4 2MZaFzMw Tdn6m0DDAzO5+wD6Rd4CaHJjKHlU/vuH5S8CTQNf14W2UNnq2LuTaNW3VRUtF/5RFyvW8R0YTlk6Iby8JSEtTgwzY7FxYBJf+qWusSGvZwN9nYjLiIuYziDfjXjgW92pFZMCGO9W1ShnXQJoYXH4/2I0U+Tzw2Xg1b/WhnIPhTSIWJ6ELZK36llp4qdpRi0fHQ2kUly0IznFYmwThyMLMtJGAn268b+QQsgsA4vqWkun5Qo9YI5npayJs513jEo4qgxjC09caKScjrPeuAp4CXA4HHS1pMbMsc8o6hHYE1cKyQAWotiIYR/1p5OD01V1cVV3SnvmW/OmgG80gEzdIV9A7wm32E6+V+nzVLuwf/8vq1/YOhWxboXcau+Sc38Hsfq0VzXsntN9RPSezOANITTS8VS9G3qn6Z3V2O/iLqE9ZnQk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Oct 18, 2024 at 12:16=E2=80=AFPM maobibo wrot= e: > > > > On 2024/10/18 =E4=B8=8B=E5=8D=8812:11, Huacai Chen wrote: > > On Fri, Oct 18, 2024 at 11:44=E2=80=AFAM maobibo = wrote: > >> > >> > >> > >> On 2024/10/18 =E4=B8=8A=E5=8D=8811:14, Huacai Chen wrote: > >>> Hi, Bibo, > >>> > >>> I applied this patch but drop the part of arch/loongarch/mm/kasan_ini= t.c: > >>> https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loon= gson.git/commit/?h=3Dloongarch-next&id=3D15832255e84494853f543b4c70ced50afc= 403067 > >>> > >>> Because kernel_pte_init() should operate on page-table pages, not on > >>> data pages. You have already handle page-table page in > >>> mm/kasan/init.c, and if we don't drop the modification on data pages > >>> in arch/loongarch/mm/kasan_init.c, the kernel fail to boot if KASAN i= s > >>> enabled. > >>> > >> static inline void set_pte(pte_t *ptep, pte_t pteval) > >> { > >> WRITE_ONCE(*ptep, pteval); > >> - > >> - if (pte_val(pteval) & _PAGE_GLOBAL) { > >> - pte_t *buddy =3D ptep_buddy(ptep); > >> - /* > >> - * Make sure the buddy is global too (if it's !none, > >> - * it better already be global) > >> - */ > >> - if (pte_none(ptep_get(buddy))) { > >> -#ifdef CONFIG_SMP > >> - /* > >> - * For SMP, multiple CPUs can race, so we need > >> - * to do this atomically. > >> - */ > >> - __asm__ __volatile__( > >> - __AMOR "$zero, %[global], %[buddy] \n" > >> - : [buddy] "+ZB" (buddy->pte) > >> - : [global] "r" (_PAGE_GLOBAL) > >> - : "memory"); > >> - > >> - DBAR(0b11000); /* o_wrw =3D 0b11000 */ > >> -#else /* !CONFIG_SMP */ > >> - WRITE_ONCE(*buddy, __pte(pte_val(ptep_get(budd= y)) | _PAGE_GLOBAL)); > >> -#endif /* CONFIG_SMP */ > >> - } > >> - } > >> + DBAR(0b11000); /* o_wrw =3D 0b11000 */ > >> } > >> > >> No, please hold on. This issue exists about twenty years, Do we need b= e > >> in such a hurry now? > >> > >> why is DBAR(0b11000) added in set_pte()? > > It exists before, not added by this patch. The reason is explained in > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/comm= it/?h=3Dv6.12-rc3&id=3Df93f67d06b1023313ef1662eac490e29c025c030 > why speculative accesses may cause spurious page fault in kernel space > with PTE enabled? speculative accesses exists anywhere, it does not > cause spurious page fault. Confirmed by Ruiyang Wu, and even if DBAR(0b11000) is wrong, that means another patch's mistake, not this one. This one just keeps the old behavior. +CC Ruiyang Wu here. Huacai > > Obvious you do not it and you write wrong patch. > > > > > Huacai > > > >> > >> Regards > >> Bibo Mao > >>> Huacai > >>> > >>> On Mon, Oct 14, 2024 at 11:59=E2=80=AFAM Bibo Mao wrote: > >>>> > >>>> Unlike general architectures, there are two pages in one TLB entry > >>>> on LoongArch system. For kernel space, it requires both two pte > >>>> entries with PAGE_GLOBAL bit set, else HW treats it as non-global > >>>> tlb, there will be potential problems if tlb entry for kernel space > >>>> is not global. Such as fail to flush kernel tlb with function > >>>> local_flush_tlb_kernel_range() which only flush tlb with global bit. > >>>> > >>>> With function kernel_pte_init() added, it can be used to init pte > >>>> table when it is created for kernel address space, and the default > >>>> initial pte value is PAGE_GLOBAL rather than zero at beginning. > >>>> > >>>> Kernel address space areas includes fixmap, percpu, vmalloc, kasan > >>>> and vmemmap areas set default pte entry with PAGE_GLOBAL set. > >>>> > >>>> Signed-off-by: Bibo Mao > >>>> --- > >>>> arch/loongarch/include/asm/pgalloc.h | 13 +++++++++++++ > >>>> arch/loongarch/include/asm/pgtable.h | 1 + > >>>> arch/loongarch/mm/init.c | 4 +++- > >>>> arch/loongarch/mm/kasan_init.c | 4 +++- > >>>> arch/loongarch/mm/pgtable.c | 22 ++++++++++++++++++++++ > >>>> include/linux/mm.h | 1 + > >>>> mm/kasan/init.c | 8 +++++++- > >>>> mm/sparse-vmemmap.c | 5 +++++ > >>>> 8 files changed, 55 insertions(+), 3 deletions(-) > >>>> > >>>> diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/i= nclude/asm/pgalloc.h > >>>> index 4e2d6b7ca2ee..b2698c03dc2c 100644 > >>>> --- a/arch/loongarch/include/asm/pgalloc.h > >>>> +++ b/arch/loongarch/include/asm/pgalloc.h > >>>> @@ -10,8 +10,21 @@ > >>>> > >>>> #define __HAVE_ARCH_PMD_ALLOC_ONE > >>>> #define __HAVE_ARCH_PUD_ALLOC_ONE > >>>> +#define __HAVE_ARCH_PTE_ALLOC_ONE_KERNEL > >>>> #include > >>>> > >>>> +static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm) > >>>> +{ > >>>> + pte_t *pte; > >>>> + > >>>> + pte =3D (pte_t *) __get_free_page(GFP_KERNEL); > >>>> + if (!pte) > >>>> + return NULL; > >>>> + > >>>> + kernel_pte_init(pte); > >>>> + return pte; > >>>> +} > >>>> + > >>>> static inline void pmd_populate_kernel(struct mm_struct *mm, > >>>> pmd_t *pmd, pte_t *pte) > >>>> { > >>>> diff --git a/arch/loongarch/include/asm/pgtable.h b/arch/loongarch/i= nclude/asm/pgtable.h > >>>> index 9965f52ef65b..22e3a8f96213 100644 > >>>> --- a/arch/loongarch/include/asm/pgtable.h > >>>> +++ b/arch/loongarch/include/asm/pgtable.h > >>>> @@ -269,6 +269,7 @@ extern void set_pmd_at(struct mm_struct *mm, uns= igned long addr, pmd_t *pmdp, pm > >>>> extern void pgd_init(void *addr); > >>>> extern void pud_init(void *addr); > >>>> extern void pmd_init(void *addr); > >>>> +extern void kernel_pte_init(void *addr); > >>>> > >>>> /* > >>>> * Encode/decode swap entries and swap PTEs. Swap PTEs are all PT= Es that > >>>> diff --git a/arch/loongarch/mm/init.c b/arch/loongarch/mm/init.c > >>>> index 8a87a482c8f4..9f26e933a8a3 100644 > >>>> --- a/arch/loongarch/mm/init.c > >>>> +++ b/arch/loongarch/mm/init.c > >>>> @@ -198,9 +198,11 @@ pte_t * __init populate_kernel_pte(unsigned lon= g addr) > >>>> if (!pmd_present(pmdp_get(pmd))) { > >>>> pte_t *pte; > >>>> > >>>> - pte =3D memblock_alloc(PAGE_SIZE, PAGE_SIZE); > >>>> + pte =3D memblock_alloc_raw(PAGE_SIZE, PAGE_SIZE); > >>>> if (!pte) > >>>> panic("%s: Failed to allocate memory\n", _= _func__); > >>>> + > >>>> + kernel_pte_init(pte); > >>>> pmd_populate_kernel(&init_mm, pmd, pte); > >>>> } > >>>> > >>>> diff --git a/arch/loongarch/mm/kasan_init.c b/arch/loongarch/mm/kasa= n_init.c > >>>> index 427d6b1aec09..34988573b0d5 100644 > >>>> --- a/arch/loongarch/mm/kasan_init.c > >>>> +++ b/arch/loongarch/mm/kasan_init.c > >>>> @@ -152,6 +152,8 @@ static void __init kasan_pte_populate(pmd_t *pmd= p, unsigned long addr, > >>>> phys_addr_t page_phys =3D early ? > >>>> __pa_symbol(kasan_early_sh= adow_page) > >>>> : kasan_alloc_zeroed= _page(node); > >>>> + if (!early) > >>>> + kernel_pte_init(__va(page_phys)); > >>>> next =3D addr + PAGE_SIZE; > >>>> set_pte(ptep, pfn_pte(__phys_to_pfn(page_phys), PA= GE_KERNEL)); > >>>> } while (ptep++, addr =3D next, addr !=3D end && __pte_non= e(early, ptep_get(ptep))); > >>>> @@ -287,7 +289,7 @@ void __init kasan_init(void) > >>>> set_pte(&kasan_early_shadow_pte[i], > >>>> pfn_pte(__phys_to_pfn(__pa_symbol(kasan_ea= rly_shadow_page)), PAGE_KERNEL_RO)); > >>>> > >>>> - memset(kasan_early_shadow_page, 0, PAGE_SIZE); > >>>> + kernel_pte_init(kasan_early_shadow_page); > >>>> csr_write64(__pa_symbol(swapper_pg_dir), LOONGARCH_CSR_PGD= H); > >>>> local_flush_tlb_all(); > >>>> > >>>> diff --git a/arch/loongarch/mm/pgtable.c b/arch/loongarch/mm/pgtable= .c > >>>> index eb6a29b491a7..228ffc1db0a3 100644 > >>>> --- a/arch/loongarch/mm/pgtable.c > >>>> +++ b/arch/loongarch/mm/pgtable.c > >>>> @@ -38,6 +38,28 @@ pgd_t *pgd_alloc(struct mm_struct *mm) > >>>> } > >>>> EXPORT_SYMBOL_GPL(pgd_alloc); > >>>> > >>>> +void kernel_pte_init(void *addr) > >>>> +{ > >>>> + unsigned long *p, *end; > >>>> + unsigned long entry; > >>>> + > >>>> + entry =3D (unsigned long)_PAGE_GLOBAL; > >>>> + p =3D (unsigned long *)addr; > >>>> + end =3D p + PTRS_PER_PTE; > >>>> + > >>>> + do { > >>>> + p[0] =3D entry; > >>>> + p[1] =3D entry; > >>>> + p[2] =3D entry; > >>>> + p[3] =3D entry; > >>>> + p[4] =3D entry; > >>>> + p +=3D 8; > >>>> + p[-3] =3D entry; > >>>> + p[-2] =3D entry; > >>>> + p[-1] =3D entry; > >>>> + } while (p !=3D end); > >>>> +} > >>>> + > >>>> void pgd_init(void *addr) > >>>> { > >>>> unsigned long *p, *end; > >>>> diff --git a/include/linux/mm.h b/include/linux/mm.h > >>>> index ecf63d2b0582..6909fe059a2c 100644 > >>>> --- a/include/linux/mm.h > >>>> +++ b/include/linux/mm.h > >>>> @@ -3818,6 +3818,7 @@ void *sparse_buffer_alloc(unsigned long size); > >>>> struct page * __populate_section_memmap(unsigned long pfn, > >>>> unsigned long nr_pages, int nid, struct vmem_altma= p *altmap, > >>>> struct dev_pagemap *pgmap); > >>>> +void kernel_pte_init(void *addr); > >>>> void pmd_init(void *addr); > >>>> void pud_init(void *addr); > >>>> pgd_t *vmemmap_pgd_populate(unsigned long addr, int node); > >>>> diff --git a/mm/kasan/init.c b/mm/kasan/init.c > >>>> index 89895f38f722..ac607c306292 100644 > >>>> --- a/mm/kasan/init.c > >>>> +++ b/mm/kasan/init.c > >>>> @@ -106,6 +106,10 @@ static void __ref zero_pte_populate(pmd_t *pmd,= unsigned long addr, > >>>> } > >>>> } > >>>> > >>>> +void __weak __meminit kernel_pte_init(void *addr) > >>>> +{ > >>>> +} > >>>> + > >>>> static int __ref zero_pmd_populate(pud_t *pud, unsigned long addr= , > >>>> unsigned long end) > >>>> { > >>>> @@ -126,8 +130,10 @@ static int __ref zero_pmd_populate(pud_t *pud, = unsigned long addr, > >>>> > >>>> if (slab_is_available()) > >>>> p =3D pte_alloc_one_kernel(&init_m= m); > >>>> - else > >>>> + else { > >>>> p =3D early_alloc(PAGE_SIZE, NUMA_= NO_NODE); > >>>> + kernel_pte_init(p); > >>>> + } > >>>> if (!p) > >>>> return -ENOMEM; > >>>> > >>>> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > >>>> index edcc7a6b0f6f..c0388b2e959d 100644 > >>>> --- a/mm/sparse-vmemmap.c > >>>> +++ b/mm/sparse-vmemmap.c > >>>> @@ -184,6 +184,10 @@ static void * __meminit vmemmap_alloc_block_zer= o(unsigned long size, int node) > >>>> return p; > >>>> } > >>>> > >>>> +void __weak __meminit kernel_pte_init(void *addr) > >>>> +{ > >>>> +} > >>>> + > >>>> pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long = addr, int node) > >>>> { > >>>> pmd_t *pmd =3D pmd_offset(pud, addr); > >>>> @@ -191,6 +195,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pu= d, unsigned long addr, int node) > >>>> void *p =3D vmemmap_alloc_block_zero(PAGE_SIZE, no= de); > >>>> if (!p) > >>>> return NULL; > >>>> + kernel_pte_init(p); > >>>> pmd_populate_kernel(&init_mm, pmd, p); > >>>> } > >>>> return pmd; > >>>> -- > >>>> 2.39.3 > >>>> > >> > >> > >