From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABFDD1A42C for ; Sat, 12 Oct 2024 02:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA4246B00A1; Fri, 11 Oct 2024 22:18:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C543A6B00A4; Fri, 11 Oct 2024 22:18:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF54F6B00A6; Fri, 11 Oct 2024 22:18:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8E4916B00A1 for ; Fri, 11 Oct 2024 22:18:03 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EA78FAD096 for ; Sat, 12 Oct 2024 02:17:52 +0000 (UTC) X-FDA: 82663339962.06.B2B25B4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf01.hostedemail.com (Postfix) with ESMTP id 0FB9040009 for ; Sat, 12 Oct 2024 02:17:57 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h+CAB8VO; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728699342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pqJ/AERVmK6K4aQ02OIzrFrKz5TUyCtyl4z64EExDH0=; b=OKYYChzCcCdQHP7EGkhJ+tevT3YaSh5ZX3C1UBw4VZ/PzUtUKDULUkwE5HNWo/B8tbRjVY ctFSl+OreX+VuY+aUmtbPtgvTcAv6QGIlvHyeSbRI79BpqGbXzNZ1kUDY/jzedTh/MsEOk qZgg9037z259MxVSGduZsYWfTl+5Ksk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728699342; a=rsa-sha256; cv=none; b=VazPjX8wifVHnrAmvabRFBa4SWeAMHXTmyT9E4+g+2ZT16VSnwQkb+KaVLGn3x9N/QiEuf LPDNkJOZrwefE3cMyXmpPLZ6gaMOUwNvopmYLh9tg3+dO5U+9d43YbsfVUNNuLpshMp5xB 6/Q0kx8tMOGpts4SGcZjn1XM2f0dYZs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h+CAB8VO; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 21DF45C5EBB for ; Sat, 12 Oct 2024 02:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13A35C4CEC3 for ; Sat, 12 Oct 2024 02:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728699480; bh=cbwIdPMTkXJZaw/g0jqTBZNpsKABLtmQqfxIXVFHsJQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=h+CAB8VOhTj/A/uouG8pFg2yoaPfGdL86TfFLKIn5o+zpGlutbFmH5QlkIZwn7CCm XLtTadvsKM9dgCLQjY+wdWDxlfmV0HtUQQTZsecgY6CyHC5fFwGIJe+xNadJMq3mVm XVeq5ILYQz1G/mQL0u0gIZOTj/RAjo6xy/JHWYrlwKnJpekRYfV5hhIw9RFhBnF7RL CgKCDifS6g4Ho5zT9N6riuvlVuErYTFCL0EXxvIqExFajnQp5jlAQTB0mzhhOlBKTv Z/6hMXkRDI3BG85qZ6MXQ2+gQV6TcwptN0TPdOcxQyuEdgLglDDDzf7C0BLop7uNky IUfZSdTiDxetw== Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a7aa086b077so357747566b.0 for ; Fri, 11 Oct 2024 19:18:00 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXpNqYNbn684GMbHLH8Fl8ETD34SjNNex/Je2qI43bH6ALLIXfsyWqYUq5se2CVboSoW+evHSZo2Q==@kvack.org X-Gm-Message-State: AOJu0YzeeEXnIi31oZrUwNBQcgLI18gGoLEjY5Moxm3gxJz1d1Hh4xNd R+yPH1MjmRpde4la04hfNzt46L8aOk1u9+mS7a2zSG22jcZOB40aKtZTywyUu8nDPGUeYDhKFz4 umdxdjzTLtqytDVKF68fCkd2ZLgc= X-Google-Smtp-Source: AGHT+IFmjZGdy3AhXsSg3wBPqtzohdmOoU3lQFAGI8tv8oev4/YMxBqqtH+JJ8oRd4VKSyAVjJtvHkcEEzudybO5HHs= X-Received: by 2002:a17:906:6a12:b0:a99:742c:5c7 with SMTP id a640c23a62f3a-a99b9305ed1mr326220766b.10.1728699478702; Fri, 11 Oct 2024 19:17:58 -0700 (PDT) MIME-Version: 1.0 References: <20241010035048.3422527-1-maobibo@loongson.cn> <20241010035048.3422527-3-maobibo@loongson.cn> In-Reply-To: <20241010035048.3422527-3-maobibo@loongson.cn> From: Huacai Chen Date: Sat, 12 Oct 2024 10:17:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/4] mm/sparse-vmemmap: set pte_init when vmemmap is created To: Bibo Mao Cc: Andrey Ryabinin , Andrew Morton , David Hildenbrand , Barry Song , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0FB9040009 X-Stat-Signature: a44z5scq83yn5upki3iow4f6g3iwhcf5 X-HE-Tag: 1728699477-25598 X-HE-Meta: U2FsdGVkX1+9y5o+aut8FrOYB3/jZQHsfF6BUcqOx2YQBIZ3HHh5VNrWui3fUIxJfGt81Hg48EObiCAhA6E8yhDfy2tNIWK/mWjwsZwUhUBwW7TYcrbf+mwyB1tQTHKvIWAOG2nztOSo9eMzY0r24zngvnVxCiXjHsd9o8Hgv4qvx+FK3LpOxTmROeFVWo8GIMSmmOqxbbRaH972Y+tQnq2IdXB4svoly6eLtyz4p+wqk+MkYX/dtxN6yQh5Cx9/hLi7Llf8THxUsw9zf1XK1KaFwS3ZPZbop2rErxesDcbaAtUOH4YPq7cT0BGxbxQC531no+T7oXJs5z1Wgy5VTC+c4JoXfiSGt/IIN8GvkobjUafKiT1Sez+hK6JxgCVeQKma51ZQNxTLh0aebpnFqdnMnN19Wfbf4oyPPWG15l/Q3LXYdsD6DxDuW9VEz55tBT6h56qK/Qunw7bRGWV8epptL7BJTQFPS/oA8bqwKVb2i2X5GV5JZAhfR1GFIjoL5GU3oEPWw4D2IjHIacvosNjNvTlNZZMkpDCdfQCyV62GBFMVtqRDtg37LhI6yoLO4SyHEIA2ahYQE4FglvKc5/2foox3557XTdjdzpOUycXp73LdAPg6Q4kmlFF9IZsSDCGOk4O1Nf2xBV9jYsYu3GhCuj3ze8wsDSNd2m7ng8FDFW0BB01k5Mhb6HMAxPGzK8/8OXod6D2OGJ4f3ap/1zYLdBQpt1JQZsqo8EXOKjbwiK8edWxy0xaf5PbFz1OFshH4KCxS3fs6IPI/0iEwILx3Dfv20iKnWodYOcacuYSn44h7PoMgTzgMiLBjCIKxV/N0wHKaSGw6Ba44TJAGZVWvPEbDzpnkZ9p78HQ6Rk67hI5pNjFgBObn/eaScxCJKzi6eewQ15WhGNi7kMQnvVuG8O2G30R3ldHSNUIB8Y5FYkVNJVrYDRFvA2+BpekfeSTfjQC/eF+SHHJbRLb KL5FPBZC YmHdfWJlOT+/O1/HiEAy37ey+0DpjcQ2iWPOBdaMQbhAdr+rbuPZQs5f9hU6ZrPgJ00rW7dGLPKouQYLll8y1frMGE9ahrEtse5+gEAqJ1IrsJQmjri4aj3mTO1vuywdtgGK2iQbPp+q+7vv1r1eoAiquVqP+gTLEda/nF6n0MNiscu90itDPURFao3+g4GRqOebf5FGv6/QUFeNzd6xo55XfpPiHiQ4fXlwdo9IUjClB6EvFIvQsTKGz8XxJozWv7RXae+nhadv215cCxOBVUxsvmqwtctxSSlT9D4UwhdFIyQT84D4jVBCZvvKgy9/F/pCOYSnmYlgHcDI0jBNtmBIMHfl6Zzo0z5WW3KwTl69uLEHeyT74Zyu8SXUQ3tG0pMMhywseUIgRkDyYUtox1uGUBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Bibo, Just declare kernel_pte_init() in header file. Since this series is a bugfix, we should merge it as soon as possible. The refactoring patch can be sent after this series. Huacai On Thu, Oct 10, 2024 at 11:50=E2=80=AFAM Bibo Mao wro= te: > > Like pmd_init(), a weak function kernel_pte_init() is added and it > is only effective on LoongArch system. When pte table is created for > vmemmap kernel space, function kernel_pte_init() is called here. > > It has no any effective on other architectures. > > Signed-off-by: Bibo Mao > --- > mm/sparse-vmemmap.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index edcc7a6b0f6f..c0388b2e959d 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -184,6 +184,10 @@ static void * __meminit vmemmap_alloc_block_zero(uns= igned long size, int node) > return p; > } > > +void __weak __meminit kernel_pte_init(void *addr) > +{ > +} > + > pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, i= nt node) > { > pmd_t *pmd =3D pmd_offset(pud, addr); > @@ -191,6 +195,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, un= signed long addr, int node) > void *p =3D vmemmap_alloc_block_zero(PAGE_SIZE, node); > if (!p) > return NULL; > + kernel_pte_init(p); > pmd_populate_kernel(&init_mm, pmd, p); > } > return pmd; > -- > 2.39.3 >