From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91BF2C83F1A for ; Mon, 21 Jul 2025 10:11:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 182146B0096; Mon, 21 Jul 2025 06:11:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10C836B0098; Mon, 21 Jul 2025 06:11:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3CFD6B0099; Mon, 21 Jul 2025 06:11:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DC4D46B0096 for ; Mon, 21 Jul 2025 06:11:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 89CD51DB148 for ; Mon, 21 Jul 2025 10:11:12 +0000 (UTC) X-FDA: 83687853984.19.C18B0AD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 7846C180004 for ; Mon, 21 Jul 2025 10:11:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ikC/TM3m"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753092670; a=rsa-sha256; cv=none; b=fqSHbdrYaMiKHFVY7P2un8RrGDKRCb0XrLK8XHi4zwklpT231xYtQ28DW5DOE9SogY04L6 4Q9yHYrEMSOlaFgI3tZ8boIzqeffJZkLv/ude5SoU1duPttAMrkofy82pph1zWwl9Tc4N4 eLa9V6esX+P3jgEt2Rrei8NpUg7EVkU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ikC/TM3m"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753092670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nvs7t2HIuKRmVbonpPDDTAWdylkzXICWPxoBrM7nnzQ=; b=dgVlQE9W/VzKPnk71YFzeZEPlEGJhkaduSPid2V8LRam6dni8WN8NACnXENKeWjQ96BlGN IAWCFhJYjbsE5a4jS7j3Hm6R7R2//9jFnUKdMMxfyyFfg8cRgeefFFAzNdhJrOEV6ectUB Ol7iG4VyEcmYbWmQb4T52IfBREd1iZk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 429F65C5BB1 for ; Mon, 21 Jul 2025 10:11:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2DFFC4CEF7 for ; Mon, 21 Jul 2025 10:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753092668; bh=VyUtJcOfBhsCPbxOvmt2mP41Jze99E8f+PefufWh6Ws=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ikC/TM3m6kqj8wv+6FfC//nAiqfpwcXBBntEPSFmvvpPuiZ7WJiaiW79+w5o/nT6L 16eLaVhVCeYpkytn1GZ4/3zOVjyrz8x8xMHcvqZbrj8jYFp46jq61uC2wjbku8yPIS 8wGVKiNuB1qqSVyawpQLsSOV3qgNKuqvfp6Nf26QZnD1Og9dwa/IT6CDwMjRcahAor xnejPYqt8gYlDlaej8yDEien1cwhc3mt+m7GRgsKxTqDMSsSJ7cmKEB2Ql22b4a9CJ Zm/PG0EQuZxeAZxjmAcn0NBlDbQfIlL8afaOMkWoZaKRwpAGbk6BMQnScRfjxia3/I kdz+i4yWJDw/w== Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-60bf5a08729so7924833a12.0 for ; Mon, 21 Jul 2025 03:11:08 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXZ4l5jNfGemHnObLm6sQCnG+p9WBygmidOR20NAnBA0zs2IsP3zbMymvBz4+yXVkmSKiaBhfqI2A==@kvack.org X-Gm-Message-State: AOJu0Yx/BJ2Br1fpWU8o36i41qn2JnMEBoVuM17yK5Sgf0ctyjXSb03g bZkNYB+yQRMr/Y+4UHHPBAmRCAKbHhrXKSpiBF7VQpztd8f1D6uxBU4eP1aosdMyl4/6Z+isq2e 5HrLIMBQdqlpP+cQLiQPTi89Xuvc+2uI= X-Google-Smtp-Source: AGHT+IEvoNhqTAmjDSGVH8ezp7mUro7GEZ0mQjc6O5ZHHcN1eyv9VMoMXmctu75NA+vUW0IeI+G+NpPWG2UCCbOb9Go= X-Received: by 2002:a05:6402:34c6:b0:612:dbb9:9cba with SMTP id 4fb4d7f45d1cf-612dbb99fcdmr9007336a12.11.1753092667388; Mon, 21 Jul 2025 03:11:07 -0700 (PDT) MIME-Version: 1.0 References: <20250720105509.2914898-1-chenhuacai@loongson.cn> <2025072056-gambling-ranger-5b0f@gregkh> In-Reply-To: <2025072056-gambling-ranger-5b0f@gregkh> From: Huacai Chen Date: Mon, 21 Jul 2025 18:10:55 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwmWWDis-x1Ej9FMfBbbdalzOX_DkigL6tsfidKQFsiJq8tVEPHRRLzDTo Message-ID: Subject: Re: [PATCH V2] init: Handle bootloader identifier in kernel parameters To: Greg KH Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7846C180004 X-Stat-Signature: npexa1otphf7jqm3jargy3hs9jg6wjud X-HE-Tag: 1753092670-370494 X-HE-Meta: U2FsdGVkX194MKeL1/QV0Ixkb+G9x+azsZWtHPudKhalKNfrQeXIiQDpoP2K+3/O1z0CyXPmuHTKQ+ELR11vOvV4gRWQ3HDiy+GgJbKmt5o/79G+vplb9oa9TLm4Eh81qCyhSFuwDmX8eZayZOZfPncrsbmrqBVlXr0Z4nkI7cv2kLQtk1GV82W5Cv15c0YA1eETl7DXjfICDXj3Row9oyhUX6930mBaNpGbNQq+/uJVRGWJ976rn02VcCfHMlWIEweZDulniM535mJAj2ld0Wo9P+SrioHgFZ0DDiO2zO+/9lrhxHMEWDlyJDfpr59fbIXIF8Ho8PROaDmBlZYNOfk6qqWSpJaPomYqWRvT0Dniksu8rbm/gUg56AAtNOVmAA6TsiBS91pl0fWm+TEZZhrqHm6ehB4PVBUb6ARG0zmh6DCDK5b5RLrXvhWfAsKmkPdsozPqDuYZL1n7QEF3fnt6ZIBUMd2OtHzVRK6XEU2VVSDLSP5reI4fp/p7MbmqYAAWwQ97zUGItCWjz7iI9x22tQHUCc+Px1kZWBWj+XU8W0m+55p24uJdbofrWec8+HtZlWR1UNg5L43EcyjI688raTi+jiOjtKQCIa53+cDaZ6cKg9ViK3eYIiYWtYVDkU1dT04uDd/V5XPX6W59I3JzQNhny9Q3I5jk9fgft+tnGEF4IhnDUYopUDul8zQvzmonZYSbS6+alz6FM0NxoemZpbw/1eLzZq1OSlweoAneAyB/JtYYLYmZaL2AsJxEeq43KBip9DP8S8//yeJZFyGGrQIU98vBY7Yjkm9T+9jaaks+lJJvGP2HhKNqfNdSKGx4U2kj9nbeiSZhnwE64K7QmEeHbj+GiQXmEvqX9axC8iRtuvVedSbOv2qwc7wKFoSPm1leMi7Ih3DbrzMT4a2zvseLKDKmtdxQyk2lCtqAaYBPamDw+i9PmSWp7ubxqocLwW4YrfgLeb5NCsu 0T4U4qgM HCGHeuFsXgU76eZQHWJFDOxcXlKL1CkRkvYML9q8Nt3GqzW/wJiyz37z6iANkW5EQOJxHT5F0eKFElYmIr/nZOfgxI2VLZwilszgB+AXbHUi0NjdYqbVvchC0XGXTBf6xqw+QY/T4pV/rVTz6UukkxT4X8/Ga53jmARKxcMhphDp+gLwdqFJ4YeR0QulXq7VLicHyPxXWiSKI3iJjeMk0sXHvS+zNzfnjD7jOtcBWGzxOr3JV79SZnqII3FDHNIcEpKsH0rISi75FJsKsWOo4/Nbzvcp6pMV7RkMUoYEdaQBlwSX5sF+bfZEXuPMpsl26D+SGbPSO/8iYw6rxg5bDHFH3dNvtE7UMhhfUmUeby3DRdi5AbhQKTEbMArtg/SgN+f7z9mYwVWFKHus= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 20, 2025 at 7:10=E2=80=AFPM Greg KH wrote: > > On Sun, Jul 20, 2025 at 06:55:09PM +0800, Huacai Chen wrote: > > BootLoader (Grub, LILO, etc) may pass an identifier such as "BOOT_IMAGE= =3D > > /boot/vmlinuz-x.y.z" to kernel parameters. But these identifiers are no= t > > recognized by the kernel itself so will be passed to user space. Howeve= r > > user space init program also doesn't recognized it. > > > > KEXEC may also pass an identifier such as "kexec" on some architectures= . > > > > We cannot change BootLoader's behavior, because this behavior exists fo= r > > many years, and there are already user space programs search BOOT_IMAGE= =3D > > in /proc/cmdline to obtain the kernel image locations: > > > > https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/util.go > > (search getBootOptions) > > https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/main.go > > (search getKernelReleaseWithBootOption) > > > > So the the best way is handle (ignore) it by the kernel itself, which > > can avoid such boot warnings (if we use something like init=3D/bin/bash= , > > bootloader identifier can even cause a crash): > > > > Kernel command line: BOOT_IMAGE=3D(hd0,1)/vmlinuz-6.x root=3D/dev/sda3 = ro console=3Dtty > > Unknown kernel command line parameters "BOOT_IMAGE=3D(hd0,1)/vmlinuz-6.= x", will be passed to user space. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Huacai Chen > > --- > > V2: Update comments and commit messages. > > > > init/main.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/init/main.c b/init/main.c > > index 225a58279acd..c53863e5ad82 100644 > > --- a/init/main.c > > +++ b/init/main.c > > @@ -545,6 +545,7 @@ static int __init unknown_bootoption(char *param, c= har *val, > > const char *unused, void *arg) > > { > > size_t len =3D strlen(param); > > + const char *bootloader[] =3D { "BOOT_IMAGE=3D", "kexec", NULL }; > > Where is this magic set of values now documented? Each of these need to > be strongly documented as to why we are ignoring them and who is adding > them and why they can't be fixed for whatever reason. OK, will do. Huacai > > thanks, > > greg k-h