From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF0D5C43334 for ; Tue, 5 Jul 2022 06:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 357EA6B0071; Tue, 5 Jul 2022 02:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 307BA6B0073; Tue, 5 Jul 2022 02:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CFFF6B0074; Tue, 5 Jul 2022 02:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B8226B0071 for ; Tue, 5 Jul 2022 02:22:10 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C758A80C74 for ; Tue, 5 Jul 2022 06:22:09 +0000 (UTC) X-FDA: 79652051178.05.CA43082 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id 5A533100020 for ; Tue, 5 Jul 2022 06:22:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82A1D61370 for ; Tue, 5 Jul 2022 06:22:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E849DC341CD for ; Tue, 5 Jul 2022 06:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657002127; bh=Zaf7DjhcD3ZxfJHUz1tOGgDGa4JYJfrWSDwsbtdTNwI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=H9eEcB3zj5OPJJVEYT0QLmZpJp6xHvhCw2s2qczzRVAVZSIay2APrXyZImwwphIeC nqJT3BpFsaVivcOXp+s0ZCCa0e6lVVj7p60thi2G9Qkg/v69hLrN9AO+GerRR6d6cx 559aS5ewGffp6GtLlCP1MQQ/G1CeiSHJ+8Zx+8Sb6oZB7Eh+oKBaNuv4VZOyMB3Tbx B5FVxlGv8V9UI5NCn2ev/ygPat1HgxXST8hfDvg4wIhNfjqbY1V78pRe+XnW5zoqsz Ogi+Vfxs7gBK6Tg7a2WHMOrvYxJHa/4LyVdHOg3s1yDZ7vY2bHRJLWE4ng5ubXfrUq FwnEzMp9XV2Ug== Received: by mail-vs1-f46.google.com with SMTP id h7so10901713vsr.11 for ; Mon, 04 Jul 2022 23:22:07 -0700 (PDT) X-Gm-Message-State: AJIora9V/EiK0vzYZjByWLBeUgjxQ9hGtaPDNril6h/fXkSS8T5rYE+f 1QablUGnW1CEf/potswsfaQshcb0aDlQcX1PamY= X-Google-Smtp-Source: AGRyM1uR3kDpQ/MbyXcNWqnHFpFRoA+f7XpzR2mn61Kf/oGLc1bqoMRFlPTGI0x9k49ir5CWsNuWr5PQo6T9BiLh8ww= X-Received: by 2002:a67:6fc3:0:b0:356:18:32ba with SMTP id k186-20020a676fc3000000b00356001832bamr18421067vsc.43.1657002126922; Mon, 04 Jul 2022 23:22:06 -0700 (PDT) MIME-Version: 1.0 References: <20220704112526.2492342-1-chenhuacai@loongson.cn> <20220704112526.2492342-5-chenhuacai@loongson.cn> In-Reply-To: From: Huacai Chen Date: Tue, 5 Jul 2022 14:21:56 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 4/4] LoongArch: Enable ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP To: Arnd Bergmann Cc: Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , loongarch@lists.linux.dev, linux-arch , Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux-MM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List , Linux ARM , Feiyang Chen , Muchun Song Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657002129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EDd3dIuYAm+vcpzVuGRdwgeslL7GcNgNx9C3IVFW1g8=; b=eHJF/B0kW3u2/kDLmhJ57kOBjxRQyl8CrLRYQkdEoWmaMZ9ebe3ZwWv3bDNE5LmibRnnWI NxAkfts0DCTWSMmOg2NZKZ7dytEnY0KACiX+UwgNu/yuTd+6RpG4vRiPb2N8UiNyJum3m7 SQFC+vF9T7uY/8vUSLhLnyshTf27vaY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H9eEcB3z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657002129; a=rsa-sha256; cv=none; b=eciQyTxu0eoQooVQugrKqxb4pdoNZYOiUgaSDAxCuz9nidDRcDNnQXC9LVNL6n5d1VW4EB T2xrbUNfTNQwVJFekB79NOZsUz1Yn3WxcPDX13eBL/K1rTrZlKV+Po1NGgrDmoQTSZFqa5 FeZZF6HBkAugwLCXjZ6EYnptesHuV/c= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=H9eEcB3z; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of chenhuacai@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org X-Stat-Signature: jufuhj7zgx3fbjeuwae3a396qscxn7wm X-Rspamd-Queue-Id: 5A533100020 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1657002129-848284 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Arnd, On Mon, Jul 4, 2022 at 8:18 PM Arnd Bergmann wrote: > > On Mon, Jul 4, 2022 at 1:25 PM Huacai Chen wrote: > > To avoid the following build error on LoongArch we should include linux/ > > static_key.h in page-flags.h. > > > > In file included from ./include/linux/mmzone.h:22, > > from ./include/linux/gfp.h:6, > > from ./include/linux/mm.h:7, > > from arch/loongarch/kernel/asm-offsets.c:9: > > ./include/linux/page-flags.h:208:1: warning: data definition has no > > type or storage class > > 208 | DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > ./include/linux/page-flags.h:208:1: error: type defaults to 'int' in > > declaration of 'DECLARE_STATIC_KEY_MAYBE' [-Werror=implicit-int] > > ./include/linux/page-flags.h:209:26: warning: parameter names (without > > types) in function declaration > > I wonder if page_fixed_fake_head() should be moved out of line to avoid > this, it's already nontrivial here, and that would avoid the static key > in a central header. I have some consideration here. I think both inline function and static key are instruments to make things faster, in other words, page_fixed_fake_head() is a performance critical function. If so, it is not suitable to move it out of line. Huacai > > Arnd >