From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289A6E77197 for ; Tue, 7 Jan 2025 10:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 974736B00BD; Tue, 7 Jan 2025 05:29:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FB2C6B00BE; Tue, 7 Jan 2025 05:29:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 775536B00BF; Tue, 7 Jan 2025 05:29:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 502DF6B00BD for ; Tue, 7 Jan 2025 05:29:20 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 01953AF3B2 for ; Tue, 7 Jan 2025 10:29:19 +0000 (UTC) X-FDA: 82980283680.20.68E4A9A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf28.hostedemail.com (Postfix) with ESMTP id 0CB49C0009 for ; Tue, 7 Jan 2025 10:29:17 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzVho9OY; spf=pass (imf28.hostedemail.com: domain of chenhuacai@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736245758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sxcakPJlcv6ggNNNsX/Elr/2bjtKScK33wPeW1tgQI0=; b=IoGUqHTNhDMqE+d0fNrajOM7MxgcI7mFvqh8DpFDxcIpr40GEf0KTCjZ/alJdnvYm018hl ZndgTUCOPKpGqfYbkBdpZOKug8ma221WJCF+lTRrSrK4l5Vk3gpg526dgwmt8rQzcLQ2a0 bDn8MWmGzHJtH8WFKnAl/MuvW582hY4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fzVho9OY; spf=pass (imf28.hostedemail.com: domain of chenhuacai@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736245758; a=rsa-sha256; cv=none; b=bNbg1wWVXN7v7O6+c7+ln/DZrNcHMC+D6jx8Twf95O5B/L8hJjCBGsK5zpJ1AswrXA8bBq 5+hhGo/psXJb+N53Gt5C2R5/eA1FWO0Pu3jU+8GivqGxoboRxrdGILPaYKpHaXq32A4HcN p0MpFIRKBPmqXXBRUVIpPIE0/QCqPD8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8124EA40EBD for ; Tue, 7 Jan 2025 10:27:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD272C4CEE4 for ; Tue, 7 Jan 2025 10:29:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736245756; bh=US71jDa+IGbgSUkjGlr1Slux1vtYuZl1LmeA4VHGQkU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=fzVho9OYDSi9Mi8lNxj2c3I3OPWaCJhbKZQSrIzBFBaDel2FdI5JONTc5c1rUNz3d RdaJ4Iq3Ic/V1E4w8VzfVR3lWHqX7Hjp2fQgIi3MGjZL9sq0vEtjYZnbwCC/NcyXUd ZS/6GU1sTZzwYvV6jdOsEYGqXak6DHyKjtXaUc33HIcv+Q9Paxll/2Kys7+QhbvcdU 1/W93+RbBpZktu5Q6vBJEcsREKtc25dQnr0SRdDqnoEaqKpoAkEh9cXUfLoMezFVr+ G4YFHqnb04SzaU6xnb6/Ome5V/5ub+Oz+Z1sz1L+bs7lzGwMDB7NCUrYeo9MrKpkyf HcLcIKt4hM6ag== Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-aaecf50578eso491615966b.2 for ; Tue, 07 Jan 2025 02:29:16 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCV/Jd1jXp2u+SO6f7d9QbeYMPX+hEOAZeFaNn9uEfiXPYYG5jCGp6oOZ1l/JSGxNMNmjWOG+UuYVA==@kvack.org X-Gm-Message-State: AOJu0Ywa1QQ31qbS2SossKVQm7I9yr6v0bN+0r8XVH2xLEnJo+Vzx9u6 tYeqNdnd8cHoH6yLdN4D7bkSbed4FqGtJLZ0DlOlqXqE/f9DSyWG6Bqeg9Dh9qD5cSlvJ9SLUjR 4SJ2lSaDkOycGC20XRiINa3T8Ruk= X-Google-Smtp-Source: AGHT+IHfXcIIHZAbwKaEd9+lFR0/crqlDqb6NK9FUtcO2HzAlGqat0WTMhIhPfNoJULOJypWgQLte9NAGpPoSOpZD6Y= X-Received: by 2002:a17:907:360b:b0:a99:f6ee:1ee3 with SMTP id a640c23a62f3a-aac334f624amr6866982266b.43.1736245755211; Tue, 07 Jan 2025 02:29:15 -0800 (PST) MIME-Version: 1.0 References: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs> <20250107011848.689556-1-chenhuacai@loongson.cn> <3a5ad843-6d00-4e8c-9f77-f53282cef4b3@lucifer.local> In-Reply-To: <3a5ad843-6d00-4e8c-9f77-f53282cef4b3@lucifer.local> From: Huacai Chen Date: Tue, 7 Jan 2025 18:29:03 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvZPguA5BFSZV6EEkeEOf-CTih5JFUmb3JL0X_NfKw4YBM8eRewi4-5jUK8 Message-ID: Subject: Re: [PATCH] Simple fix To: Lorenzo Stoakes Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Koichiro Den , Sebastian Andrzej Siewior , Mark Rutland , Charalampos Mitrodimas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0CB49C0009 X-Rspam-User: X-Stat-Signature: bo8qw1w1rwxdpb8r66no1u78wmhbn8on X-HE-Tag: 1736245757-428767 X-HE-Meta: U2FsdGVkX18Y4w8ee43iT8ql4o+kPuYoMlkhnVCB94lwoazM4eemv0qtPhdzksv8YLNY4FQVqOXmuRjyKFPh7DwLqiqfkQojPRgfy+b4adw1cI+aWuHSsbFy78ExJExVls0P1hHzl9V1Wo9G6o/dnKte8EtdiLJeK/295Mwf5eMzVbiVqTq+g/gJHjFVNxBoNetBV7Wh6fTckKxqXve3H+Gj97Ei5j5BITyQ8YB+D3BMBa9YrtTv+nd/+cPaDW7rDuciV/Z87MDck3ofK1sUcbfsRivaVVFJnvAUnIM1FSEup9GrtbgVy190AQGG3Uq8OTkCNSUzegbyCyPUt5Z0JsrR9eesqSvYHBlUC5qFGXZz3QsZ13e+XdvriGF0ajTfmYMHwHnNdal3Ys0mxEZ819vcaAxq8qwm4hCk9OXy38aE6EjxBeWOdINhGioCtmeT8iGgYggoScq0RZAWF+nSqFn3X05D7jTBvbl8LunBgyv1r/R7jRQJPEejwmvxq8s3MkvV/elOU37xDWplFCy8you95Cx+l2Tvwga1fmt6PNxg1B0IxGM+cbK35qN3+d27k2zlVHGk+Opp1CwXPJ6rim/q6mSCuC1saNeBoQFwMreSuuACz96XWOGCCpz3m7OROvg5iNM9xmHXy5HpvR1oCPnvOMG/Xhd39nL5BKdY7Mzza5+vgZylzSO4hfn6gI0VBHYit36xBnOTytLFOxiCmvmQFkEi4PZoh/C4+MKMyXkzJFaLHX9fwaaIwYbuR3OeUJ8l7oy9UqSs4ya3/Nllfru4d+PYBTmcxpzxL67SVCHrcfAx+zaQHo2VxmInLoMlZySGQEsmpnOP62soNBbMR2pcrK/lp4w01koDIL/KcX3D4y1FqlpfkZkHiv1fMeF7q75PlUxuye1w8Zjt5Sw6agB8vwdK+3bF9PHTR3wpFOLf1f39HD2XKrV+Zl/4pb+1Uu5xxhRTlBgTr2L2Yi7 BWYUAUTl LHN54gKHC/4BBGpr8hsHB5ZIa//DjdnwMxFWemB3Cn4ZY0/oL/I/AXf2EkX4YxRXU3nOfSEpcvkMrWKw4fEqxI2IagPTpPvS4MfhtHGr+63xnURtUlBhY8eFNTnSdS1T8RN8tv3zxze5WM4vBL3KwFRa0K/m5aun553Fl9ZTlmEVAd+OuxvVAa7XQ1/HIEygODNz29p7WOc4REpmxg9hJW319lDEw9G3iktbyRRWWdM/PiUQ2JnJn/IjyG4o2wLK8AWdwFOjXGlzUGtWfNS3yxl+oal92JGNs1n7M2vflqATNtqaKIESjseWPVg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.034576, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Lorenzo, On Tue, Jan 7, 2025 at 4:48=E2=80=AFPM Lorenzo Stoakes wrote: > > On Tue, Jan 07, 2025 at 09:18:48AM +0800, Huacai Chen wrote: > > Hi, all, I like simple fixes, so is this acceptable (based on an early > > version from Koichiro Den)? > > No not at all. This is bizarre - in the mail you are replying to Koichiro > agrees with me that the approach of his code that you've sent here (I don= 't > know why) is fundamentally broken and suggest another. > > I am at a loss as to why you've sent this? Perhaps a miscommunication > somewhere? :) > > In any case, please don't send '[PATCH] xxx' mails that aren't intended t= o > be patches, a better form of this would be to say 'oh can we just do...' > then to put this code in the mail underneath, without any '[PATCH]' prefi= x. I wasn't in the CC list, and I also found the bug yesterday, so I can only reply to this email with "git send-email --in-reply-to". This is the reason why my reply looks so stranne. > > But please do review the discussion - the below is insufficient as simple > as it is (sadly) because the boot CPU's delayed work will never be > executed. Koichiro's simple fix causes the boot CPU's delayed work to never be executed, this is obvious, and of course I have read the early discussion. And so I improve it, with a "cpu_online()" checking, then the boot CPU is unaffected. Huacai > > I will take a look at Koichiro's new approach as soon as I am able. > > Cheers! > > > --- > > mm/vmstat.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 0889b75cef14..1badc24a21ff 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void) > > { > > int cpu; > > > > - for_each_possible_cpu(cpu) > > + for_each_possible_cpu(cpu) { > > INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), > > vmstat_update); > > > > + /* Will be enabled on vmstat_cpu_online() */ > > + if (!cpu_online(cpu)) > > + disable_delayed_work_sync(&per_cpu(vmstat_work, c= pu)); > > + } > > + > > schedule_delayed_work(&shepherd, > > round_jiffies_relative(sysctl_stat_interval)); > > } > > -- > > 2.43.5 > >