From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94061E77198 for ; Tue, 7 Jan 2025 03:58:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25A9D6B00AD; Mon, 6 Jan 2025 22:58:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2094E6B00B0; Mon, 6 Jan 2025 22:58:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AA086B00B3; Mon, 6 Jan 2025 22:58:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD08C6B00AD for ; Mon, 6 Jan 2025 22:58:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7EF58806BD for ; Tue, 7 Jan 2025 03:58:20 +0000 (UTC) X-FDA: 82979298360.30.5E47422 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id 9182D4000C for ; Tue, 7 Jan 2025 03:58:18 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JyPqKoq/"; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736222298; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tRw6+yWIICDqR1tvHDzxoBcPRwArSV53Iy03ekLpt0U=; b=lNExNE8Xw0b9fPJtUsnQ3H2+o0ahZklfyroppaws3hfWGFChTWf1ImCAw9hV7ZzN3CqXDH uvIdbu/eVRxRDkh56/83Cve8arBnhpTqZXZLlwSn+HmV/jMua2siD3dL8w1nxNUkLPNqI9 oU/oWfYv5W3QGIH/BBNG8/EXCM653Uk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736222298; a=rsa-sha256; cv=none; b=G+CegEA52tp4uDWV7cFUP2b77VaPJEv6XTxf/NBgzyIaPkE+ig4l6KFxZh7t58KxU4QU60 ggdVe5PZuonU8Pu8hK/pnpnO1DuUOuuEQomUmVQnR4BvZ3NwnUs0XsjD5SXe0epE0rPU+n efGJ36xmyIyunov2mnPwBo6j78HlIdA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="JyPqKoq/"; spf=pass (imf01.hostedemail.com: domain of chenhuacai@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=chenhuacai@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 0BF02A414F2 for ; Tue, 7 Jan 2025 03:56:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A9CAC4AF09 for ; Tue, 7 Jan 2025 03:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736222297; bh=jnfdPGOVbW+dL91iClcIiAhI5RSvQGMITRrTk7wqEIs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JyPqKoq/28/Ug0YhE1/QJZ6I2Bb+GG4hf3MJCBUGBCw9IZLSd8cTyd33evqYZXqxJ XKbRua/CyhRB6h1oCoMyEwvCI4w/0hTabjZsVSyc2SmEmpnJojDzBznK2oGZ6AaBv+ nIqJU2g9Iq0qWBUJsWmDfT6jAAghZ/Wp3qpA0w3UhjUWpWXd71jndpA0jxbDrCPUjM TYYhs6NaS5NMpCAKWWHhWsW0VnpUapPrXLVBwakKnk9CIHKMbsCiuUHH7oSQSrrK7h MMEHfZ0uOToG6QHOmncpUSO4SKaOfEPr8/fRhqBhnUjqdgzmuZHfvz7ATpgx6STTt2 Ncf3ahOssFsHQ== Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aaf60d85238so955035566b.0 for ; Mon, 06 Jan 2025 19:58:17 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXB/FfaCJyk2dork3xPTqAzdvdnk+G3Rrzvz+KaxuH/dlMxqUYpWUQw2OzBhWSKyZpTbYKG0Tz/6Q==@kvack.org X-Gm-Message-State: AOJu0Ywpgmr2yIrOnxordlmOLRXsc8hiY+xqikYf0vwzZcLCVl1e3XW0 FKSFPQqIxVKf021z57Dace763ckxwCFwDoNZ7iQMsiKs3a1QI3hiqI6Jy3k0LBxIAye0Vz+He0L Ro7DAm3XU/azav1hZoTGdLyYhGX0= X-Google-Smtp-Source: AGHT+IG1A/n4qMoG0oKL3pRIAvJzFKj+z/GgHzeG4wW53eUnRAlH2N6frgi85ZTcLFmhDUFqpLlfTbLOmjXz5+23dHE= X-Received: by 2002:a17:907:6ea7:b0:aa6:8a1b:8b84 with SMTP id a640c23a62f3a-aac345f5b92mr6271209166b.57.1736222296087; Mon, 06 Jan 2025 19:58:16 -0800 (PST) MIME-Version: 1.0 References: <7gd4skn6l4i3liu6cvzmgqlrwxc3rukrnau7lnpyhmfyjuvqwl@gdwgybedp5gs> <20250107011848.689556-1-chenhuacai@loongson.cn> In-Reply-To: From: Huacai Chen Date: Tue, 7 Jan 2025 11:58:06 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AbW1kvZ_bZQNwYoxBR6IPGfYaSkr7lv_crplMKzwWNgaS2_gJVG2NLlWmKTSQ-U Message-ID: Subject: Re: [PATCH] Simple fix To: Matthew Wilcox Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Koichiro Den , Sebastian Andrzej Siewior , Lorenzo Stoakes , Mark Rutland , Charalampos Mitrodimas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9182D4000C X-Stat-Signature: xufhowx8dcopgc3rehc4ykwo3u7o3efh X-Rspam-User: X-HE-Tag: 1736222298-951171 X-HE-Meta: U2FsdGVkX1/3wdVdvhD+HO8UI0Qzu/Yhzmr04QXzx6ZLmYumAvleKwr1SCC70aUVvHIRjI8ezZRE/SBuV6myclAgYJsphlLxWkS9BaWESHgiavtZZWaSKj9ynmvFCHzGceRyDTDg+a2qBvAFuBibvFy/y230dBvQSuDM4/glQS0l2kGyOn4F0Z3dxfIcfdZrdIDLJaa4hkQFxDuKhO5hBDDcsKS3m7/C5GmTevxpCcjbyU2ki+QMq5O2yo3MzaZyav0K+S+iafLfdoHWQOOtPboGArC/uNQD6A0fdXgtdVEGSjA/Eyc7teOkX/E1ffp8Vm8MA75Dg0N5/8aerHr/o9MPC69cBwm9ZzMOr+iwMF5reN27Lxr/MZenwR6ml+nyZ4wLSsAil6n5r1xHaP9MF9AWWH/g/yBgHs4vojUA3QdTKuUV4QjfCIPSvNMwVx38F0nnGZeQzQCuvP7FtGpYniRRHtkBAAzf+LMs0b7mY6bIoliABhRyce2EiUyvJ+fIwkh+f66uzvjcWjVlIK/8GyHrSYWgVWKiBqr8EeVyPshZamAcEjDmcSgYBgb0nTY+V3CQZccHBwDBxw6q3FHE0HOZvpoqi/zC8o3CITm6kRSFifcEgMkirwge/mZCYHVUNIzJCKRMi+J5QJho8LoGrNK27+FTRcM0nbcZbD3PYb30m0P/kvjUIyM3Ov9RhlJdpwUI4RwU6ScpqC+nkOEA7IDGq6Xx0+GWnsb0w2mqfKHOfGSfeF9S6ce4r/9Qu/VMqyhbpKpTqZPDhQ4nXGFBrmQ+7xBlXjSSQgCyQhsqdjiNY4RlDUjSUlZip3BJYVJo70GBTJCkzUkQgrnTPRmjzABJejCQzTWVMYLi0a7X7iYm1QhGp6up5WTi17V6fsWWAG+MXR2dymzNukSQqVyYwu/cGI5x0DL+en1up3ZKUS5YPd7yuM+jJWklEypXEWlkNYz0Yy0HN2vPHc1rc4H 4nDJOM/w Vap2FHwIkYSmioskw6bOb04O6u1UdUA0AINgteuS3nBXahwhepDyyXymVtARsGKHvk5UsWLHBS7CtmArlLuJnv+vKRmT95Q2jG1zzeL1bl+oK7kwQfxkQEwNvZbYcWUxROi2t7yl12Fv6bbNBIuUzhuXc+hJz+JyhtsT3/xvCkBhb+GPLbOsTf7M3Gqu/hF4FgoZqFHFuHemesP+Hf4ow1b/eere+cu4/810CZhndza8HSVF7YctNvcsKv6AZZVpvUhdJ+ucMy2O1QmEo1cdfZVxNvWbHHmPG6QfbgIR/1UcQjPSoq1grrAfpUCaspIu/mc39rFZQXciFjxAZtJhoilJmKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.041866, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 7, 2025 at 11:35=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Jan 07, 2025 at 09:18:48AM +0800, Huacai Chen wrote: > > Hi, all, I like simple fixes, so is this acceptable (based on an early > > version from Koichiro Den)? > > This is an unacceptable commit message. Of course, this is just for discussion, not a proper patch. Huacai > > > mm/vmstat.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index 0889b75cef14..1badc24a21ff 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -2122,10 +2122,15 @@ static void __init start_shepherd_timer(void) > > { > > int cpu; > > > > - for_each_possible_cpu(cpu) > > + for_each_possible_cpu(cpu) { > > INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu), > > vmstat_update); > > > > + /* Will be enabled on vmstat_cpu_online() */ > > + if (!cpu_online(cpu)) > > + disable_delayed_work_sync(&per_cpu(vmstat_work, c= pu)); > > + } > > + > > schedule_delayed_work(&shepherd, > > round_jiffies_relative(sysctl_stat_interval)); > > } > > -- > > 2.43.5 > > > >