From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8B9C433ED for ; Tue, 20 Apr 2021 04:19:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74800611B0 for ; Tue, 20 Apr 2021 04:19:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74800611B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F16EB6B0036; Tue, 20 Apr 2021 00:19:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEE406B0070; Tue, 20 Apr 2021 00:19:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB6286B0071; Tue, 20 Apr 2021 00:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0246.hostedemail.com [216.40.44.246]) by kanga.kvack.org (Postfix) with ESMTP id C2D446B0036 for ; Tue, 20 Apr 2021 00:19:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8AA323646 for ; Tue, 20 Apr 2021 04:19:31 +0000 (UTC) X-FDA: 78051441342.22.AA49F2B Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf27.hostedemail.com (Postfix) with ESMTP id A6BBC80192D5 for ; Tue, 20 Apr 2021 04:19:15 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id p6so29404655wrn.9 for ; Mon, 19 Apr 2021 21:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6tOKXOtetoB5l502f6CwFsHmwD7mexR6F47nan+OthU=; b=zPHU77GKMzPEi4Z3USHsG2BRW0Zi4R9HfLDI9y7k4FXV1enRHFnEnDFpNblWfiBxmr do3ZkVZLdc8LojasG7YWO1dNz1M+r0AXaX9ZjzoEKYFZ8Z/wAxvxyRXTF1NwWMyZJd9B O5fNW1Sjd0U6Odjk1x3B8z6uEpc+pHXeBW7ltTAEQu0DpyfIOYhv/0zch1Kw6bX4oIQ1 a7pVpXyJGsbA3HHIEyJnKH9+kMYJpHy7mGu0VNnpNFdJDPOJmwTEBmrQfuWaCldrzMNy nrk1Cd5+0YuXB7qga8FtlY298hCzN0WhhpVElJvtFP5cQ9ghiUqvfTB/LzYFPYwxnETO 5Ymw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6tOKXOtetoB5l502f6CwFsHmwD7mexR6F47nan+OthU=; b=fO//E+MbOKwsUAffQQlfsYtulzfEcur2RatPYSKIAmtISGPimqT5N1VmbVoGnf++74 dePJsglaKj/7zH51xd7CBrCnKwY2KweJYc2qsSOXMtbiEdg5YCD00V3Z4qSnMHJnsqkv pCYv+Q17X1MRlZllT6qrckzyEkCgo+ABYdm7RBoaeFHRA9IAr9Vy5cZE2IOhKcaGfbdx IdjxMIeILJEnDQ5LDHRPbsHMiaArog0qbUKoXxInqhXnQU87uJNqIC/PPCVy1VLMqUIW 1Q9JTlIl79uS8QEiZ2WXA6s8uzHBfflVi9MJh6pbWqraAqh9tqhJ/4/eNU6jv330zW6a xy6w== X-Gm-Message-State: AOAM533ag1RXzNHVR15qkkX4z9sQVjd4crcGbL51HzNeWaX6W5Tuu1ES lIBFS2T6/f3wE5b/AEkNJHrESgc0ZUt0S+no3DtT3Q== X-Google-Smtp-Source: ABdhPJwyi59C/3tYFHMh5Y6vJynOO8jGTiBuy759HBjpadP75J9jtm+F/ANmSq07/Qd2xqFswBp4XEetGIu9IzB83DY= X-Received: by 2002:adf:dfc2:: with SMTP id q2mr17850344wrn.128.1618892370130; Mon, 19 Apr 2021 21:19:30 -0700 (PDT) MIME-Version: 1.0 References: <20210418112856.15078-1-alex@ghiti.fr> In-Reply-To: <20210418112856.15078-1-alex@ghiti.fr> From: Anup Patel Date: Tue, 20 Apr 2021 09:49:18 +0530 Message-ID: Subject: Re: [PATCH] riscv: Remove 32b kernel mapping from page table dump To: Alexandre Ghiti Cc: Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , linux-doc@vger.kernel.org, linux-riscv , "linux-kernel@vger.kernel.org List" , kasan-dev@googlegroups.com, linux-arch , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ii636r9cjg4ob1mrj9sqt6zo8isbeo43 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A6BBC80192D5 Received-SPF: none (brainfault.org>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-wr1-f50.google.com; client-ip=209.85.221.50 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618892355-19888 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 18, 2021 at 4:59 PM Alexandre Ghiti wrote: > > The 32b kernel mapping lies in the linear mapping, there is no point in > printing its address in page table dump, so remove this leftover that > comes from moving the kernel mapping outside the linear mapping for 64b > kernel. > > Fixes: e9efb21fe352 ("riscv: Prepare ptdump for vm layout dynamic addresses") > Signed-off-by: Alexandre Ghiti Looks good to me. Reviewed-by: Anup Patel Regards, Anup > --- > arch/riscv/mm/ptdump.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/riscv/mm/ptdump.c b/arch/riscv/mm/ptdump.c > index 0aba4421115c..a4ed4bdbbfde 100644 > --- a/arch/riscv/mm/ptdump.c > +++ b/arch/riscv/mm/ptdump.c > @@ -76,8 +76,8 @@ enum address_markers_idx { > PAGE_OFFSET_NR, > #ifdef CONFIG_64BIT > MODULES_MAPPING_NR, > -#endif > KERNEL_MAPPING_NR, > +#endif > END_OF_SPACE_NR > }; > > @@ -99,8 +99,8 @@ static struct addr_marker address_markers[] = { > {0, "Linear mapping"}, > #ifdef CONFIG_64BIT > {0, "Modules mapping"}, > -#endif > {0, "Kernel mapping (kernel, BPF)"}, > +#endif > {-1, NULL}, > }; > > @@ -379,8 +379,8 @@ static int ptdump_init(void) > address_markers[PAGE_OFFSET_NR].start_address = PAGE_OFFSET; > #ifdef CONFIG_64BIT > address_markers[MODULES_MAPPING_NR].start_address = MODULES_VADDR; > -#endif > address_markers[KERNEL_MAPPING_NR].start_address = kernel_virt_addr; > +#endif > > kernel_ptd_info.base_addr = KERN_VIRT_START; > > -- > 2.20.1 >