From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDCA6C10F27 for ; Tue, 10 Mar 2020 12:02:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F40D2464B for ; Tue, 10 Mar 2020 12:02:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20150623.gappssmtp.com header.i=@brainfault-org.20150623.gappssmtp.com header.b="ci5wG0y+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F40D2464B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3C1046B000D; Tue, 10 Mar 2020 08:02:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 371E86B000E; Tue, 10 Mar 2020 08:02:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 286CD6B0010; Tue, 10 Mar 2020 08:02:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id 0D9606B000D for ; Tue, 10 Mar 2020 08:02:33 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 06763585D for ; Tue, 10 Mar 2020 12:02:33 +0000 (UTC) X-FDA: 76579315386.28.glue33_6d887a59aa95c X-HE-Tag: glue33_6d887a59aa95c X-Filterd-Recvd-Size: 6742 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Mar 2020 12:02:32 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id r7so615809wmg.0 for ; Tue, 10 Mar 2020 05:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=555c87GbFFs7Gl2Fto1Hhng076kIPZ49lUxFSE0iXmM=; b=ci5wG0y+4oqXRODzPPpGIFH2pT+6MWN0PHLmCiFnCSW9G3JU1/qLV25yOCSU3k/k1u WHU8xoVTdZiuDk5Tvwtl26no3yQUMgO++mHX5Nbie8l7Qp60FFqGOGaSt6DQk8Nieb31 Amx9l1NTcb+JjpgBmLqitmQ2wJeXtig6dMcPmQeBbvQbv+KXsbGl6r8ijYF98Xoz0DGQ brph+I7TOwAeA1awklCaWyM3q6A7dAq7N/Mo7EpuqhiEA/qRYqathKprBDOyjdw+h7Um kRv4ftFDSU22qNbPLZAwvYb9DQIQZUMknnu5GH9fMFAjdwE5n6OZUAKwdde6wKN1D9dG R3SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=555c87GbFFs7Gl2Fto1Hhng076kIPZ49lUxFSE0iXmM=; b=Ldymxz9Je/OCgx5dkvKQDn7617OmrK3umgpl2r8hJzW6ThpjCeHLp3VJZx8bxAEZyS WiEMzEzGywItHLRQerq2IaOzU9t2Atlk0F1IALzkWLTjktNltiF+YKhYYCwXarSdMEnH p+NhAtxEXZTgPSeKJA8gwjemMda5tAT55GkPprEYd7t2COs0zfYY8BgjgQtKU8yvZtxy ObcGShEdyRyMl10o3lEhQ0JbbH9eIGFbvxMKWK4Z16CUvbLygDeDegQSi3+hfTk/17uG tlVUd3xagGP5PngB6ENVyKgAWyaUbdkhyuYJj2hT3F+Q9Z5hPufu8JHr8/0xYzhBf4tX jtdg== X-Gm-Message-State: ANhLgQ09KdGL78XK8FYyeoVxVVaQaXjRmloA5D3REP0j0RHIZB3pFTxK 1GxOYayrs9Mlpid6tG1dyKvYxMDCWH+O5TjnGmJtqw== X-Google-Smtp-Source: ADFU+vt5U5LtaY11bQMRekHPPWA1Q6hNAvxUP0NCWiWz/zBO4YoLvoS1nbkQQdo2K9xqg+MY5cvff2TX4lPoagDnx60= X-Received: by 2002:a1c:5452:: with SMTP id p18mr1939389wmi.102.1583841750852; Tue, 10 Mar 2020 05:02:30 -0700 (PDT) MIME-Version: 1.0 References: <202003091047.yO0wlUGy%lkp@intel.com> <293bcd25-934f-dd57-3314-bbcf00833e51@redhat.com> <4932d976-1fff-db01-7e79-bd79ad18d96e@redhat.com> In-Reply-To: <4932d976-1fff-db01-7e79-bd79ad18d96e@redhat.com> From: Anup Patel Date: Tue, 10 Mar 2020 17:32:18 +0530 Message-ID: Subject: Re: [linux-next:master 7003/7050] include/linux/virtio_config.h:113: undefined reference to `page_reporting_unregister' To: David Hildenbrand Cc: Alexander Duyck , kbuild test robot , linux-riscv , Anup Patel , Atish Patra , Palmer Dabbelt , Alistair Francis , Linux Memory Management List , Andrew Morton , "Michael S. Tsirkin" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 10, 2020 at 3:56 PM David Hildenbrand wrote: > > On 10.03.20 11:22, David Hildenbrand wrote: > > On 10.03.20 03:19, Alexander Duyck wrote: > >> On Sun, Mar 8, 2020 at 7:54 PM kbuild test robot wrote: > >>> > >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > >>> head: b86a6a241b7c60ca7a6ca4fb3c0d2aedbbf2c1b6 > >>> commit: 120359931943d2b801ce51a1a045dcc0a5d1a55b [7003/7050] Merge branch 'akpm-current/current' > >>> config: riscv-randconfig-a001-20200308 (attached as .config) > >>> compiler: riscv64-linux-gcc (GCC) 7.5.0 > >>> reproduce: > >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > >>> chmod +x ~/bin/make.cross > >>> git checkout 120359931943d2b801ce51a1a045dcc0a5d1a55b > >>> # save the attached .config to linux build tree > >>> GCC_VERSION=7.5.0 make.cross ARCH=riscv > >>> > >>> If you fix the issue, kindly add following tag > >>> Reported-by: kbuild test robot > >>> > >>> All errors (new ones prefixed by >>): > >>> > >>> drivers/virtio/virtio_balloon.o: In function `leak_balloon': > >>> drivers/virtio/virtio_balloon.c:281: undefined reference to `balloon_page_dequeue' > >>> drivers/virtio/virtio_balloon.o: In function `__virtio_test_bit': > >>>>> include/linux/virtio_config.h:113: undefined reference to `page_reporting_unregister' > >>> drivers/virtio/virtio_balloon.o: In function `virtio_cread32': > >>> include/linux/virtio_config.h:423: undefined reference to `balloon_page_alloc' > >>> drivers/virtio/virtio_balloon.o: In function `fill_balloon': > >>>>> drivers/virtio/virtio_balloon.c:233: undefined reference to `balloon_page_enqueue' > >>> drivers/virtio/virtio_balloon.o: In function `__virtio_test_bit': > >>>>> include/linux/virtio_config.h:113: undefined reference to `page_reporting_register' > >>> drivers/gpu/drm/virtio/virtgpu_drv.o: In function `virtio_gpu_remove': > >>> drivers/gpu/drm/virtio/virtgpu_drv.c:139: undefined reference to `drm_dev_unplug' > >>> drivers/gpu/drm/virtio/virtgpu_drv.c:140: undefined reference to `drm_atomic_helper_shutdown' > >>> drivers/gpu/drm/virtio/virtgpu_drv.c:141: undefined reference to `drm_dev_put' > >>> drivers/gpu/drm/virtio/virtgpu_drv.o: In function `virtio_gpu_probe': > >> > >> It looks like somehow the config has CONFIG_VIRTIO_BALLOON enabled, > >> but didn't select CONFIG_MEMORY_BALLOON nor CONFIG_PAGE_REPORTING That > >> shouldn't be possible since in drivers/virtio/Kconfig we have the > >> following: > >> config VIRTIO_BALLOON > >> tristate "Virtio balloon driver" > >> depends on VIRTIO > >> select MEMORY_BALLOON > >> select PAGE_REPORTING > > > > IMHO that's perfectly valid. You might want to have ballooning without > > page compaction (MEMORY_BALLOON). Same with PAGE_REPORTING. > > > > AFAIK, "select" will still allow you to disable these things - which > > used to work fine with MEMORY_BALLOON (did that myself when debugging a > > compaction issue). > > > > Correction: I disabled BALLOON_COMPACTION back then ... so ignore my > comment regarding that :) > > But we should be able to build VIRTIO_BALLOON without PAGE_REPORTING > somehow IMHO. I have moved all VIRTIO driver selection to defconfigs for RISC-V which was the case before. Here's the patch: https://patchwork.kernel.org/patch/11429217/ Thanks, Anup