From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D71C433ED for ; Fri, 16 Apr 2021 10:42:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A05B61103 for ; Fri, 16 Apr 2021 10:42:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A05B61103 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 178166B0036; Fri, 16 Apr 2021 06:42:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 100DF6B006C; Fri, 16 Apr 2021 06:42:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E95496B0070; Fri, 16 Apr 2021 06:42:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id C4D9F6B0036 for ; Fri, 16 Apr 2021 06:42:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 76EED824934B for ; Fri, 16 Apr 2021 10:42:03 +0000 (UTC) X-FDA: 78037890126.17.DBDDFE6 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf18.hostedemail.com (Postfix) with ESMTP id 363EA200025E for ; Fri, 16 Apr 2021 10:42:04 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id p19so14053094wmq.1 for ; Fri, 16 Apr 2021 03:42:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zex7i7Gm7ilDvh/qRtb14tTVDUsTiPnIyJ8lJBlTVDY=; b=o+NE8pGADgY4FrSGIXWUfJDlnJ1juLdQCdEiocUx/f4kBswMU6EacEfCbch4zfDr8H +8aCGjJXpl6SK20MOt1VpdXaX4BbkHmki5A2hh1gmZ20w2EMJP1VjnEsC8VADb9byTqY lE+sl5rG/g22g2pLcBDdBqPUtuuihLLbi7A6mVCOjdUC+LZqLYwD2VrW6Q33ZmABcitG osCWWS16aeTjD/SapJryOxU2/k5hi64Zs2KKTkPikhugxITJ9wbjvvaZwkFN1zhfoIGY lMbuOFwM6i8S1cr0T1JDeA7IJyAS5SdymT8sxxaVslfrawq50NfS7neQz6FJIXPKg4kh wuBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zex7i7Gm7ilDvh/qRtb14tTVDUsTiPnIyJ8lJBlTVDY=; b=R4uMZ+1hYRUB7ZqNOxcccrMvgRBXrHheTfbPQzSguNIFTvwM5YCQ+oP5qyirVtfBF6 XT8DB4nnLaFfpm/vWGBiELWNsQ6xsN/gD5DoVQ1MRTZHuCJJVjxlqs+V+jPr1VeX0M2/ IzdCDUa/xfKOj8ZtDI21lGvH2YwJHZ3ParVzjDJo/h6cX5Uf/ShgNDxAzS3abVgeLL0K VyasQT1LbX8/eaZ2dp78Srt0+yqeWVJjr+x/mmMyS3jWCLrqAkpU+shT/e9BGe26cKDK bL2IDwuaFfgyRLW5fYhMrrjGbeVYZe1cdCemBhpdBnPBBT7PEqfjdYnxpuoKxQSeXT/Z 7wvQ== X-Gm-Message-State: AOAM531X7OnIk+IsijfflWA5XtED2OpX2Sk4PWZFy7y0whMV7gffwrZY jq/7qIOKPAIogl/p5icsI3hfumyDZy7+N2STE56uPQ== X-Google-Smtp-Source: ABdhPJzSZVwXQXIP/gEzyKiBpeLInXpc+75cZ3dvpf3JNqEHMcXwCYZIJpV2ZQZVzZT+LiXa+F2urN3JdQz1K4fuTB0= X-Received: by 2002:a7b:c348:: with SMTP id l8mr7746989wmj.152.1618569721686; Fri, 16 Apr 2021 03:42:01 -0700 (PDT) MIME-Version: 1.0 References: <20210415110426.2238-1-alex@ghiti.fr> In-Reply-To: <20210415110426.2238-1-alex@ghiti.fr> From: Anup Patel Date: Fri, 16 Apr 2021 16:11:50 +0530 Message-ID: Subject: Re: [PATCH] riscv: Protect kernel linear mapping only if CONFIG_STRICT_KERNEL_RWX is set To: Alexandre Ghiti Cc: Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Arnd Bergmann , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , linux-doc@vger.kernel.org, linux-riscv , "linux-kernel@vger.kernel.org List" , kasan-dev@googlegroups.com, linux-arch , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 363EA200025E X-Stat-Signature: mfaedegnnihdoh7sapg398emx5b7rssb Received-SPF: none (brainfault.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=mail-wm1-f44.google.com; client-ip=209.85.128.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618569724-907559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 15, 2021 at 4:34 PM Alexandre Ghiti wrote: > > If CONFIG_STRICT_KERNEL_RWX is not set, we cannot set different permissions > to the kernel data and text sections, so make sure it is defined before > trying to protect the kernel linear mapping. > > Signed-off-by: Alexandre Ghiti Maybe you should add "Fixes:" tag in commit tag ? Otherwise it looks good. Reviewed-by: Anup Patel Regards, Anup > --- > arch/riscv/kernel/setup.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/setup.c b/arch/riscv/kernel/setup.c > index 626003bb5fca..ab394d173cd4 100644 > --- a/arch/riscv/kernel/setup.c > +++ b/arch/riscv/kernel/setup.c > @@ -264,12 +264,12 @@ void __init setup_arch(char **cmdline_p) > > sbi_init(); > > - if (IS_ENABLED(CONFIG_STRICT_KERNEL_RWX)) > + if (IS_ENABLED(CONFIG_STRICT_KERNEL_RWX)) { > protect_kernel_text_data(); > - > -#if defined(CONFIG_64BIT) && defined(CONFIG_MMU) > - protect_kernel_linear_mapping_text_rodata(); > +#ifdef CONFIG_64BIT > + protect_kernel_linear_mapping_text_rodata(); > #endif > + } > > #ifdef CONFIG_SWIOTLB > swiotlb_init(1); > -- > 2.20.1 >