From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06CC9C3DA63 for ; Tue, 23 Jul 2024 19:56:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 925186B0092; Tue, 23 Jul 2024 15:56:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D5696B0093; Tue, 23 Jul 2024 15:56:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79D146B0095; Tue, 23 Jul 2024 15:56:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5AEDF6B0092 for ; Tue, 23 Jul 2024 15:56:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 093671403FD for ; Tue, 23 Jul 2024 19:56:53 +0000 (UTC) X-FDA: 82372075506.02.CF091D1 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 40234C0018 for ; Tue, 23 Jul 2024 19:56:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=08rrvMh8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of sagis@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=sagis@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721764576; a=rsa-sha256; cv=none; b=F+BTxjLHGv0u3v+XA0GuwRz9e7jxdx4h675uEOXHkoXYXo5r/wqfZg1R1XzlIRUFjTMY/0 JEBDc1fJ+CKy+N6BuBSLntkLmOJOjWBIhktK1KVOVL1Fk87EMG+3lpqLeuApL4dlA1CVPP 5KtxdBp7XFgFb8XZU/6FZe2OuPLox4A= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=08rrvMh8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of sagis@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=sagis@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721764576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DQ8gVf5B0wPtEoet4zm24rxnx8GgSxUPU5gw6kjX2ns=; b=mI/Y/f7rW5PzpDh5KiaXN5keyS/LLBQTxn0KS02bGSFDmz5mtwnV0+nrHwspfexGeu27S3 aM1SZNnyyx465HrIz6MtaQjgZLaLpRp2B+cbsXrPvPn3oDIoLvuTfD15e3EJa8f+DB79/M Y2XTFTw0UfH6V841vt31FQomBkox42A= Received: by mail-yb1-f182.google.com with SMTP id 3f1490d57ef6-e087c7ef68bso3091933276.3 for ; Tue, 23 Jul 2024 12:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721764610; x=1722369410; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DQ8gVf5B0wPtEoet4zm24rxnx8GgSxUPU5gw6kjX2ns=; b=08rrvMh8EjbNNXVh2sqESrSSBP1cNu5fN4ZkJV4Sbro/uOcjCrQglqyMjDmoIJelxG b3KWp+yXXYqPwCc/bqkZTr1hHiRqPDWMeqXZMHjQkbSpR3H0MNUqeXg4Wv/fuSYvon8M 65mcQObRdzcJJlQhmWaEmwWkPTxdiMfDzJ2585YHUyUZ7ZbbCIb7O1fD+GvXrLgDN5vI i6ytbdJ1uyEXSFkplv1Uu9QpvCAt7eoI7BRHr1Xj28xRD82BBnw/KteiRkoIrgnfWRJI v8LUJtQ8FkpNH5a2sYnisaT7MPjZleK/BzEccZr4d3AHRJvpZVMHBOf5lNlC5YDgH/zQ eJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721764610; x=1722369410; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DQ8gVf5B0wPtEoet4zm24rxnx8GgSxUPU5gw6kjX2ns=; b=sIXjO1ah/JY8TX3Zu2oiYgxGHqn9tPDPZdndSzidhElqWfKnPpwCZxyU/HFTwzk3zI vJkOeLaF0j9B24ZwR/7be+AItiOFNX1h6PDqEHp1MUUUQbO77zO1P4Siro3jb3S9Yz3d zQiwRUSATKcuJ5XHiQv5Obd04uRzrmD38derQANnRYHlPcp5qbnpnmeJj+MFiedwv4q2 +XPxZxAq1R/nOciR8B2l++idi0lZ9dszqIWDFFgUiwD+napjHd86glLmWbMfucZdrdqT pTOMudYj1iTJlxQuyS/JMPFGP9crZddpAQ25rhcC+uciM+mGxLhwgzPoy1HDb5dRlbhI /fuA== X-Forwarded-Encrypted: i=1; AJvYcCVPc2fcJV0C0WxnKtLtLPrijjhCNpKe7d4pwzMLoVwXTMN2P/6AtoEXohCD2U8CTd1RAv8YI3yfT9KkFQJ/mDP9aQg= X-Gm-Message-State: AOJu0Yx9o+WqxtxFq/MH7DJEYQXz1dsrhHEToOq/g2OeoTgMLfFSzBM4 bnjO7zPwk2L5pgqvsuZcfaoz5gZmnKjpmraP49ElLqRaxh9XffZ6BwgxpLzbuWT6MvTsFbaYM3v CCt6jzdfWJd2FmxfKHW/m8vMGOf94cjfM06Sj X-Google-Smtp-Source: AGHT+IGDERizmWaRZSYrEeosGY/RVvaTx8fAfVuWpYPQS52G6odr3z9alx6euwKiIoGuRdU+jKSkuTTpA0Br5WZBQTo= X-Received: by 2002:a05:6902:a07:b0:e05:ae3f:7ae8 with SMTP id 3f1490d57ef6-e087b9e574emr13923095276.52.1721764610048; Tue, 23 Jul 2024 12:56:50 -0700 (PDT) MIME-Version: 1.0 References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-2-sagis@google.com> <797bfae3-6419-4a7a-991a-1d203691d2cb@intel.com> In-Reply-To: <797bfae3-6419-4a7a-991a-1d203691d2cb@intel.com> From: Sagi Shahar Date: Tue, 23 Jul 2024 14:56:39 -0500 Message-ID: Subject: Re: [RFC PATCH v5 01/29] KVM: selftests: Add function to allow one-to-one GVA to GPA mappings To: "Zhang, Dongsheng X" Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 40234C0018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yht96y763o6eoje54g7xp9r6oobkmbky X-HE-Tag: 1721764611-752787 X-HE-Meta: U2FsdGVkX1+m4ojc8lTLi9QeKvMiTGoXIO4Kv5yTwmlXNMDHW5Eqo13JV2fdUtISbFpzn9buRz6MlDiTHdFA6UZaG4A+Qej4AR7zdf5Dz2Dvby1+Ph+dB53g58FgeA212B9Rq4OUetijxadRJeNezAu7a/zuxsaSGScFwiSG26saa1UEenJwSfHONPUUrq1pwliucR08vkRn0PAULn3ptojDA3jRfcJDzmaXjsGPWx/gbQ/7D5xMtxpR0LcqgbaOjHm/3nrqOeYsitAscWc/9Rmz1nnxHBV7W1rerPuFQNGmcFUk9/SkSYMAj5vBcxL5PfyakrmLkmPJbgMcky29FNZsUigy0KwYwd4BM/aCiorBV95lJT8KIO77h5DuzUaSXa7NOJbDWULQewNaUcTQY21Vq9z6bewYVYfvdJ24j3GIl6oj4Wqa0rdxqJEpeo9AI7AVZNNlb3KLha83mFTJBxRGzJWgvRlZ3Ht1L3kqnh0Id7HkB3JRv0WE5bECYdJ0p28rKiKEU3rrqWyH3qizg4ltOJr5ZbWtCrDp+lzOlHg0LQ683ZqX3Uzz6CZa8nmW0B7qNvlYVe9hmmjRRwGWnTXF+NTd2o7SCj5pnSyrUVA8bq3BOw09gMmBRRByJVhkdX21n7nyk1xZtCFMjm+oXeCfr3uLzTxw71GslqsXe7gdSk0Xlgsv3Rn4Fdpjzqp59x0ByjJwNcznkRBLdO06M7gcHZCf7YfA9ZZqhm7uQBDvDl8nRZDudzxqllSHlNEaaA1db0QoIhr84wdrPq9dmLkHY/fpG06CmyWKYM1U2OuHVtg7nvmPEpFqmzIONaMQyRwvNGqubK5Ein38GqHFtjNgz4fe3QmCmSDB+2Z925ToQCyRnwunU1HdYr88hmo0MzzLaSv8rOzNcxAi0mMXxpoB4epw4eEXP5pYnrQ0eCEi55qC0IydaWMaiYLw4J+EehQm2SkwJwzAsTEsE67 XsPLuj0f nPxbSSxp9lgQmXzp4RH8ZgpRJFNcUT4jEsxV5RB+qqxDD262WTk4k/LQSCUuqaQvh+m9Aq34KD52jCOtuZBzQI+IMjCqXL/4E4Z5PE5/nRwkO0H0flrSvTDaM7SasOQePwXQHZyqyhhSNckwWjYEomPlS55SAb/tuXrJqQzX/huHnw3BgYZ2IHgvTCBmJ2m7+/+VclHS+SP8xq3S1lDGImq9hZ2ygv4rbDK8S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 21, 2024 at 5:29=E2=80=AFPM Zhang, Dongsheng X wrote: > > > > On 12/12/2023 12:46 PM, Sagi Shahar wrote: > > From: Ackerley Tng > > > > One-to-one GVA to GPA mappings can be used in the guest to set up boot > > sequences during which paging is enabled, hence requiring a transition > > from using physical to virtual addresses in consecutive instructions. > > > > Signed-off-by: Ackerley Tng > > Signed-off-by: Ryan Afranji > > Signed-off-by: Sagi Shahar > > --- > > .../selftests/kvm/include/kvm_util_base.h | 2 + > > tools/testing/selftests/kvm/lib/kvm_util.c | 63 ++++++++++++++++--- > > 2 files changed, 55 insertions(+), 10 deletions(-) > > > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tool= s/testing/selftests/kvm/include/kvm_util_base.h > > index 1426e88ebdc7..c2e5c5f25dfc 100644 > > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > > @@ -564,6 +564,8 @@ vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, size_t= sz, vm_vaddr_t vaddr_min); > > vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t v= addr_min, > > enum kvm_mem_region_type type); > > vm_vaddr_t vm_vaddr_alloc_shared(struct kvm_vm *vm, size_t sz, vm_vadd= r_t vaddr_min); > > +vm_vaddr_t vm_vaddr_alloc_1to1(struct kvm_vm *vm, size_t sz, > > + vm_vaddr_t vaddr_min, uint32_t data_memslo= t); > > vm_vaddr_t vm_vaddr_alloc_pages(struct kvm_vm *vm, int nr_pages); > > vm_vaddr_t __vm_vaddr_alloc_page(struct kvm_vm *vm, > > enum kvm_mem_region_type type); > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing= /selftests/kvm/lib/kvm_util.c > > index febc63d7a46b..4f1ae0f1eef0 100644 > > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > > @@ -1388,17 +1388,37 @@ vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *v= m, size_t sz, > > return pgidx_start * vm->page_size; > > } > > > > +/* > > + * VM Virtual Address Allocate Shared/Encrypted > > + * > > + * Input Args: > > + * vm - Virtual Machine > > + * sz - Size in bytes > > + * vaddr_min - Minimum starting virtual address > > + * paddr_min - Minimum starting physical address > > + * data_memslot - memslot number to allocate in > > + * encrypt - Whether the region should be handled as encrypted > > + * > > + * Output Args: None > > + * > > + * Return: > > + * Starting guest virtual address > > + * > > + * Allocates at least sz bytes within the virtual address space of the= vm > > + * given by vm. The allocated bytes are mapped to a virtual address >= =3D > > + * the address given by vaddr_min. Note that each allocation uses a > > + * a unique set of pages, with the minimum real allocation being at le= ast > > + * a page. > > + */ > > static vm_vaddr_t ____vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, > > - vm_vaddr_t vaddr_min, > > - enum kvm_mem_region_type type, > > - bool encrypt) > > + vm_vaddr_t vaddr_min, vm_paddr_t pad= dr_min, > > + uint32_t data_memslot, bool encrypt) > > { > > uint64_t pages =3D (sz >> vm->page_shift) + ((sz % vm->page_size)= !=3D 0); > > > > virt_pgd_alloc(vm); > > - vm_paddr_t paddr =3D _vm_phy_pages_alloc(vm, pages, > > - KVM_UTIL_MIN_PFN * vm->page= _size, > > - vm->memslots[type], encrypt= ); > > + vm_paddr_t paddr =3D _vm_phy_pages_alloc(vm, pages, paddr_min, > > + data_memslot, encrypt); > > > > /* > > * Find an unused range of virtual page addresses of at least > > @@ -1408,8 +1428,7 @@ static vm_vaddr_t ____vm_vaddr_alloc(struct kvm_v= m *vm, size_t sz, > > > > /* Map the virtual pages. */ > > for (vm_vaddr_t vaddr =3D vaddr_start; pages > 0; > > - pages--, vaddr +=3D vm->page_size, paddr +=3D vm->page_si= ze) { > > - > > + pages--, vaddr +=3D vm->page_size, paddr +=3D vm->page_size)= { > > virt_pg_map(vm, vaddr, paddr); > > > > sparsebit_set(vm->vpages_mapped, vaddr >> vm->page_shift)= ; > > @@ -1421,12 +1440,16 @@ static vm_vaddr_t ____vm_vaddr_alloc(struct kvm= _vm *vm, size_t sz, > > vm_vaddr_t __vm_vaddr_alloc(struct kvm_vm *vm, size_t sz, vm_vaddr_t v= addr_min, > > enum kvm_mem_region_type type) > > { > > - return ____vm_vaddr_alloc(vm, sz, vaddr_min, type, vm->protected)= ; > > + return ____vm_vaddr_alloc(vm, sz, vaddr_min, > > + KVM_UTIL_MIN_PFN * vm->page_size, > > + vm->memslots[type], vm->protected); > > } > > > > vm_vaddr_t vm_vaddr_alloc_shared(struct kvm_vm *vm, size_t sz, vm_vadd= r_t vaddr_min) > > { > > - return ____vm_vaddr_alloc(vm, sz, vaddr_min, MEM_REGION_TEST_DATA= , false); > > + return ____vm_vaddr_alloc(vm, sz, vaddr_min, > > + KVM_UTIL_MIN_PFN * vm->page_size, > > + vm->memslots[MEM_REGION_TEST_DATA], fal= se); > > } > > > > /* > > @@ -1453,6 +1476,26 @@ vm_vaddr_t vm_vaddr_alloc(struct kvm_vm *vm, siz= e_t sz, vm_vaddr_t vaddr_min) > > return __vm_vaddr_alloc(vm, sz, vaddr_min, MEM_REGION_TEST_DATA); > > } > > > > +/** > > + * Allocate memory in @vm of size @sz in memslot with id @data_memslot= , > > + * beginning with the desired address of @vaddr_min. > > + * > > + * If there isn't enough memory at @vaddr_min, find the next possible = address > > + * that can meet the requested size in the given memslot. > > + * > > + * Return the address where the memory is allocated. > > + */ > > +vm_vaddr_t vm_vaddr_alloc_1to1(struct kvm_vm *vm, size_t sz, > > + vm_vaddr_t vaddr_min, uint32_t data_memslo= t) > > +{ > > + vm_vaddr_t gva =3D ____vm_vaddr_alloc(vm, sz, vaddr_min, > > + (vm_paddr_t)vaddr_min, data_m= emslot, > > + vm->protected); > > + TEST_ASSERT_EQ(gva, addr_gva2gpa(vm, gva)); > > By 1to1, do you mean virtual address=3Dphysical address?, community tends= to call this identity mapping. > Examples (function name): > create_identity_mapping_pagetables() > hellcreek_setup_tc_identity_mapping() > identity_mapping_add() Thanks for the input. Will switch to vm_vaddr_identity_alloc() > > > + > > + return gva; > > +} > > + > > /* > > * VM Virtual Address Allocate Pages > > * >