From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55CFD5B155 for ; Tue, 29 Oct 2024 08:06:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 689DE6B00A0; Tue, 29 Oct 2024 04:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63CC16B00AA; Tue, 29 Oct 2024 04:06:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 505216B00AC; Tue, 29 Oct 2024 04:06:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2FA1A6B00A0 for ; Tue, 29 Oct 2024 04:06:36 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D35071C5109 for ; Tue, 29 Oct 2024 08:06:35 +0000 (UTC) X-FDA: 82725907278.12.2586C58 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf30.hostedemail.com (Postfix) with ESMTP id 1FE188000E for ; Tue, 29 Oct 2024 08:05:47 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HSKtwmcK; spf=pass (imf30.hostedemail.com: domain of zhang.lyra@gmail.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=zhang.lyra@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730189113; a=rsa-sha256; cv=none; b=PTlwDXOTe2Ah4UuPgrMNZZfGWbbXt56K7vk/nRCkx71YakENUxIoAZheQGrwRoKiQh32Rf JMaCWDzRA0sTTBafb8PeDNq4ZJhMsL3obTiPyGpksZ5O6TInc5G31DUaUN5U8RFXNkEQJ+ 1oy1pqS8w/FdrA9bckAEXZyOqv+3xjk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HSKtwmcK; spf=pass (imf30.hostedemail.com: domain of zhang.lyra@gmail.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=zhang.lyra@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730189113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erYrvbuM+zOt800Pswb5/FeIgISJC9qqJWCYratTQZU=; b=mS2iwrOu17Jh8rULX4X1RP9t69u3RwD3cvBVps2EKqZxwCVZtQcN9lFZK+yVvpPlIz+AD0 dihPar9HDxcKq/Mz1HaIxblgJhfbjaWKRIneSSky4c4CJfCo51Ro0zFx9D5EGPnuHXEwvs TqBtrIq/xb/9J5+o50JwvUA5Iu+pl6U= Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-71811c7eb8dso2502914a34.0 for ; Tue, 29 Oct 2024 01:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730189193; x=1730793993; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=erYrvbuM+zOt800Pswb5/FeIgISJC9qqJWCYratTQZU=; b=HSKtwmcKztB15gJyJvw1f15y7h/EuS25lS0JbXrJ4KZQldnjv17qRXlk1aOwAlFPTa tdWLvyzj+w/tHCm5DWiOHkdir5LozDEOjwlSD8OUi6yNDfiXQAYX3dryVJ1YNwuGUP6m Z4pcoD3LqLSpp7gJVJLRfBBbAzxgb+cJNhWiZWSWr2y/uTrapV1YHTGdPY4yVXBADEPf plE5I4lsGjmDTDkvHEh0Cw9NtZCeSDUgaHLsRBZbbLSdlLqdrr2XfVCwMyQSHbDpdI2T c5DvjEUbEc9astBM9z2OMsFK/jdrG60PCObUAtrU+Si7Jy0pRReljJekbt42K8NZmHp8 h8LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730189193; x=1730793993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=erYrvbuM+zOt800Pswb5/FeIgISJC9qqJWCYratTQZU=; b=To+m4uYLS+/MwYBeWwhLdgWWduTyUPTvHMArAY7RkNTtEm/2uQQFlOoy/OdTESoRoG ZJ9HlVaH0csmmVnsGgpHLIlRMRn9Rd+tmuYwJ+CZP9b3a69Ompuw1EmsdMDCiku7x/ko RBoyMQtLJdxRHWS5tY6tGogngPssh5i0yqxRaccD+aioiXbA739cE44DK7SAniag5/74 WY8yvqIS/VqposmMsvz5qB4ODpaGczcEbfX5LofLsfv8woOUQ7wLe5O3f7veXSsuXiST t3dsg50jMPMVi1HHTYl6Z7tfZB4bd9NrwbGnrcZ+CosTclq1y/3iP64wK4CFKSaFAVIx L8LA== X-Forwarded-Encrypted: i=1; AJvYcCXTAboxzQmewoOsQd+ELs4wmxz2HjlNiViB7BbFSIEPANA/AYpsUUOzOIZbOUlZXrK8givrEI+Fag==@kvack.org X-Gm-Message-State: AOJu0YxqL8wbek2H31t8xJ+FxcwdZf3/F/r4+xZDY13jDAAM1bSSYKnI MYa0lJv7KuFw6btjb9Z3SZjbzWBGEyRPQXUv4DFlieMtatc+USwkD6o+O+7IyoWv1cPKQcw9SJW 1Yc4AJ7ywg3cnO50E37yoUKrXx0Y= X-Google-Smtp-Source: AGHT+IFDFWL4mUjTprma/osZp1KJIoCHwGw0y8thgiAfWKZzlyBnrv8BrxgAMiSJRJIJRIEpMo2FiY9XYcdbCsPmb4I= X-Received: by 2002:a05:6830:4189:b0:718:678:56e3 with SMTP id 46e09a7af769-71867f1012cmr11989419a34.5.1730189192952; Tue, 29 Oct 2024 01:06:32 -0700 (PDT) MIME-Version: 1.0 References: <20241008094141.549248-5-zhangchunyan@iscas.ac.cn> In-Reply-To: From: Chunyan Zhang Date: Tue, 29 Oct 2024 16:05:56 +0800 Message-ID: Subject: Re: [PATCH V2 4/4] selftests/mm: skip virtual_address_range tests on riscv To: Andrew Morton Cc: zhangchunyan@iscas.ac.cn, shuah@kernel.org, Paul Walmsley , alex@ghiti.fr, Charlie Jenkins , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 4fotgk63kf84gk5fqx3pzdq6fa99ewg3 X-Rspamd-Queue-Id: 1FE188000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1730189147-515183 X-HE-Meta: U2FsdGVkX1+Ap7ASSkPo87R2KiMzQe+FIb1iv0jlBXdHgy43RkfJX2JMqO1uj92HVDWg46sYEvHBKZ5MIdqo1nLYsq/jtlBhrj9HhM0tJ4l7b5E/ddQK2sbxLesm05iMh7NFkb+Zp9QkHxRZh07EvLAqm5TYuUIo3vKOorSgtXjCq0o9ieGHRZJYKctj78O46c4EMygykyT+psW+JgBjtWTOcSYcfvDpX6n45TZyvUMMSAYvIpHzBlJlEnX3oOjrmeSFl3Vosj4BWCxXpy0xnT+ju4HC5ilMrYMN34a9lRrJ5AbuoDEb96W2+R8Q7pOB1su8R/63bODdt+YVZdl9XT3LRMjUuliDfGiHgzV7+LDnHytR/6WEllKtU98JF9RFRsen+37/1MqTOO8Llk3joVZ9V39wYIUbMmikscctHBmJ6JbqkDjF5xT0gfbiGFizwYQAXbqysEXtnUgAmEAlkW9Bhi/ogjOEHst05jGwaMQs3UvUoILPvJP7Bl7hNy86R2kIKJkVjwJVKLiPpHHEmxqhFdN9/C54ygnS4AnbEnrLFDYQyCbJCspk0Kspy3hvBgqxh6ZpHTezboXmwZKqXszBtq86xBQKrPzv0d3KbjRRiWGnk8rb8hT82aYyPjz4QlaSR1bLY6tTU6CUe+GG2UBJOD6rw6Ot4szEIk+avLe5FMo89RY+WrPs2PS9JgZ2XN1G/JKIY9r/gNoNs0F0zjYp4BEj+ihOp+qSlc+g94tmip8r++xv9ObuFB9PPhrTB3qWyyjTi/+VPv4Palo0blgZzau/uGk5UTX3M3zv3UYlB65YCmRnJpa8ge4ZdPTrEskFbda9HLCEIX+mzDMBUVLMhVxMS1AweE3+1rNkR8BFM8H0CYZ7esSlAwUwJi7HSO5FXZWK61/y4TKK7XiEyk5DEK+Q7NGLuBFghzEKwyEtIyL+0fcOQAF7KHp9lMAFc73VJBYk12EC8wZ9rc+ SqCaYTfS THWEcbzybUWgXyj54UlbAILHrYdkiv6GeW1o5UqqDYsGWB81bJzga7Y8t5YtW5T8FXsB6/JQ+WCLhCsPqoXOzo9o8BMnHs+PYOAzTtxhyRPG76zAJjWEJc6veGvR3CrOvRD3hb3OWuQy17NZo3QFIuHlErJ3kL6iqzxjuNYlbzIQ2e1nr5dzvu6kju3nXPPMDZDxz+JBN5kajo9wIv88sJqP+XcztEc+jYDHgMK7JULDgTax9c/DTO8Hj0Q5Zq9I7EavZrhO0xK1ll/uv+AFXtz4igoLUJWpLB1os31lrGKXjlsRjm4my7sEI+DMXs5EHLRNXVo0BlV40vk/Ga3Z0nFnKQaYfgAvhpMdq7Rasi2cBKUAcDvV1syunU7bsItYMTXUKPP+IyUaq16oPwfX8Ag2u1QA1fMN8ChxCCl6nuypF3iKXPenbjVj2PyxPgoUZorWwDSAQK2exRDWEKOYVX9/M2E9RYPuVCeow5btzGCYI4Lo2OpYWUS6QT6XWvCT4IorygUfQiN822cUk58jedpkaosbt/UduDvtW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew=EF=BC=8C On Fri, 25 Oct 2024 at 02:00, Palmer Dabbelt wrote: > > On Tue, 08 Oct 2024 02:41:41 PDT (-0700), zhangchunyan@iscas.ac.cn wrote: > > RISC-V doesn't currently have the behavior of restricting the virtual > > address space which virtual_address_range tests check, this will > > cause the tests fail. So lets disable the whole test suite for riscv64 > > for now, not build it and run_vmtests.sh will skip it if it is not pres= ent. > > > > Reviewed-by: Charlie Jenkins > > Signed-off-by: Chunyan Zhang > > --- > > V1: https://lore.kernel.org/linux-mm/ZuOuedBpS7i3T%2Fo0@ghost/T/ > > --- > > tools/testing/selftests/mm/Makefile | 2 ++ > > tools/testing/selftests/mm/run_vmtests.sh | 10 ++++++---- > > 2 files changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selfte= sts/mm/Makefile > > index 02e1204971b0..76a378c5c141 100644 > > --- a/tools/testing/selftests/mm/Makefile > > +++ b/tools/testing/selftests/mm/Makefile > > @@ -115,7 +115,9 @@ endif > > > > ifneq (,$(filter $(ARCH),arm64 mips64 parisc64 powerpc riscv64 s390x s= parc64 x86_64 s390)) > > TEST_GEN_FILES +=3D va_high_addr_switch > > +ifneq ($(ARCH),riscv64) > > TEST_GEN_FILES +=3D virtual_address_range > > +endif > > TEST_GEN_FILES +=3D write_to_hugetlbfs > > endif > > > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/= selftests/mm/run_vmtests.sh > > index c5797ad1d37b..4493bfd1911c 100755 > > --- a/tools/testing/selftests/mm/run_vmtests.sh > > +++ b/tools/testing/selftests/mm/run_vmtests.sh > > @@ -347,10 +347,12 @@ if [ $VADDR64 -ne 0 ]; then > > # allows high virtual address allocation requests independent > > # of platform's physical memory. > > > > - prev_policy=3D$(cat /proc/sys/vm/overcommit_memory) > > - echo 1 > /proc/sys/vm/overcommit_memory > > - CATEGORY=3D"hugevm" run_test ./virtual_address_range > > - echo $prev_policy > /proc/sys/vm/overcommit_memory > > + if [ -x ./virtual_address_range ]; then > > + prev_policy=3D$(cat /proc/sys/vm/overcommit_memory) > > + echo 1 > /proc/sys/vm/overcommit_memory > > + CATEGORY=3D"hugevm" run_test ./virtual_address_range > > + echo $prev_policy > /proc/sys/vm/overcommit_memory > > + fi > > > > # va high address boundary switch test > > ARCH_ARM64=3D"arm64" > > Acked-by: Palmer Dabbelt > > (I'm taking the first two as they're RISC-V bits) Could you please pick up the last two through your tree? Thanks, Chunyan