From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1EA0EEE27F for ; Fri, 13 Sep 2024 02:08:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12058D0005; Thu, 12 Sep 2024 22:08:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C08D8D0001; Thu, 12 Sep 2024 22:08:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AFE38D0005; Thu, 12 Sep 2024 22:08:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 670C78D0001 for ; Thu, 12 Sep 2024 22:08:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E54021C60AA for ; Fri, 13 Sep 2024 02:08:08 +0000 (UTC) X-FDA: 82558079856.08.9741052 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf15.hostedemail.com (Postfix) with ESMTP id 23A66A000F for ; Fri, 13 Sep 2024 02:08:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nz7L1sIF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of zhang.lyra@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=zhang.lyra@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726193200; a=rsa-sha256; cv=none; b=k08DOP4ond1AESu4zsSBOPjr27yU52HK/6RPN3f9o0lhJRe+T80UHb65nrEQpxkKacjYYC b1afQw8qF8SKafV50AEGyrPYd23RxShmkSLPWYBs3+vGFBCNFU7EPLFJu67q7MO2tZKsF/ TH1gBqo+vB+HqX15x5JH84vo6lfMBo8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nz7L1sIF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of zhang.lyra@gmail.com designates 209.85.167.175 as permitted sender) smtp.mailfrom=zhang.lyra@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726193200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s7cimPnDbBKYHrFkLn6Bf+Cga62onzQ+Q3eQb/Boxbw=; b=ad+qWYEIGypLdmSwcC0JOQKgFJQDyqDIY6ANOkudWDfvackSILoDyeIY04jc1vA17BRbzf cmlSC6NpcxQPRNZA4Z/5yiMLoxXZE5Dl+e4oqK4+A+/3h1eelRN41VpL03uhHfop45yeVB uDQgMdzHrfRqhXb/i5eCgsemM/YMIZY= Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-3e0379a8d96so148379b6e.3 for ; Thu, 12 Sep 2024 19:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726193285; x=1726798085; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=s7cimPnDbBKYHrFkLn6Bf+Cga62onzQ+Q3eQb/Boxbw=; b=Nz7L1sIF9umBr9ZZAK9yx246YbOeasFljt7w0NcXMc7+6i+seys30+9HEJYe3Ry082 YW9yvBI7qVjyAEwKp4Xl81b3zgWm1m9lmPxMS4DJ1HHKKXEmyBQwpFxqn8UzaRum6dZU 8K3DuJMZ7PX0E/LiZl65MAhhRWOMPaY5YVKBfOxc/11OW6QVXE4K+d9Vc2MHQ12dKF4S e2E0aofsttT6f9E0YV67F0C6+JzcPki0xil5GQdYVDqLO1c1RDFoiyWa3OeDNFggAvF7 22uRqoqiGdsLAncKGS7KpHVPFdQ7WBA2Fh1f5GLPQ1+E662Sn3tTBFlHtRYoVrmG8aej uarg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726193285; x=1726798085; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s7cimPnDbBKYHrFkLn6Bf+Cga62onzQ+Q3eQb/Boxbw=; b=YFHMNC/LkLmMLqlUxeAj0qvR/rYinWBf3ywqujbeZSuYlmPrtDTAdY0HT6u2VfFDHJ QVLKRYqo7ryGZBdluwWtpsrUkNLpaTVkAe0NMMjjr/IN3b97M72R80zoTSMbLlqMz9B7 Gis7os4GWPuKnZW0qNqom3GbI0ODGmlMZGLdpTfiYny0fPSKVn4YDhuhs9EQAz9mbGfU MlNzCERdtJEtend6GIemasJM0ArQP+NeyAsvNdAMQHF+zLCLDvNFH8ILbe8I92bH0jAz 8Zq6YHsMD/+LQxf7FOEOAZDeGqgItkPNtwPc2CKe3lfYKRrg8NW8VBQGiVz8Hww0yirT f/Fw== X-Forwarded-Encrypted: i=1; AJvYcCVXh37httKD5M+9WlKtoQSKiVdCNfXPh6Nq7tUX6EQUIj8XSHJjSBmtKE0euQh7hUEE9ZZooniAzA==@kvack.org X-Gm-Message-State: AOJu0Ywy/URuEFiARhyLlHE5yl7OXsSbNaf6repXwFign/M+vseqtVL3 vR0KuP4vqnFqRcG3rBM2Y76A7U6JX3x/VkmMqQ3tFeT0dCvb8SQw1+f6BDlv0F+1CYlesOkv+GA EsHWcD07BC2eLs0c6mWk2DbRr69Y= X-Google-Smtp-Source: AGHT+IHggupOHNWQQGi87kpgjxoBFmwiJyJeCdJM1Ufdym7+4NlW81mIMtLq1f/ocpWT1XwYREsvFBgQ5gHmWI0LRtQ= X-Received: by 2002:a05:6808:14cf:b0:3dd:cc7:957c with SMTP id 5614622812f47-3e07a0eee2bmr659522b6e.8.1726193284860; Thu, 12 Sep 2024 19:08:04 -0700 (PDT) MIME-Version: 1.0 References: <20240912100018.736447-1-zhangchunyan@iscas.ac.cn> In-Reply-To: From: Chunyan Zhang Date: Fri, 13 Sep 2024 10:07:28 +0800 Message-ID: Subject: Re: [PATCH] selftest/mm: Do not use hint for riscv mmap To: Charlie Jenkins Cc: Chunyan Zhang , Andrew Morton , Shuah Khan , Paul Walmsley , Palmer Dabbelt , Alexandre Ghiti , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 23A66A000F X-Stat-Signature: u9zd98af1bw879aczm37rk8u55ptoa9b X-Rspam-User: X-HE-Tag: 1726193285-383237 X-HE-Meta: U2FsdGVkX18yi+6uy2n4YGomxQgSN55ruzu5deGPGv61Zwdj62kRRliXURb2RjFqTONtYjXgBAi3E8S3MtKQSLM1UERLsGvL5oFztpIFAYUS3e8ZJNn+SfWwvgf4GsBn0HNxtyZD8UoPSgLHFqqhy0UXl1QtDRy/K8kqYT7mWNtxowJGqOMraAY/Edwo0dWNtb7icRN/1t/kPorAsmyzXarshZs7V54/Ls8WazI3T7O4F4qpDgFDIx7jAv9h4AciajzMRS+2HPlmQsx7EcuGIY1Quh7fvGDqI5mChDPeRt9ySw/nYHdrNf7d/2MF5tyrK4doVXU42Jkzjgp9MGIbzgJOvYL23JPTXQBVKfS5LqOHOItgA8Ww/D8ZZhYIBfEf23zpwroTRBcmGCQ4sObUkNzg0FxcAO1yxctc82mKd1tkVkrzV2F6H67ewbP1PZ6jsTCrg7bwwCs/UtdLKZ0yQwc/k3hisZEfngkNit4Msdhc8/NuwgOe8c6A/9dKQ42xB0GRZiRvb+ZJJobl5ZNJG47UlYx+UBolWcybW2Rm/tOt1l6rnu4GoBn7gt88JtfVhUbSqkWkv2yZnCWAGQPJaNbsTvkL8hAJd0RAuzH1o/FqmbIh0JXKQpr8eQp0/+9Slm5+Bgef6i0AuO7IF2g6lHSOvf8fTnmrhm4fkA+WEeC37HdtZB8ofkZJIrWXgzmgWlnuLMvNKqV5ZIVtNzrHmXmbfHzqWjj1HpMIHuB1T9XQ/D0STDCCrDtvRj2A59A12xpQDdiztu3JKQ/O8WAISeQ5PZdlzkN8vKyeYcGfXcq8Ltr5vZShd3jiZENgpFJImdL8hE6slF91w0UtZQJs5aMWt8tCjtDWn4GrRL0Sv81+FK04RH+6vj0ToYXwhdrIFKIZdPYBBgxxbVjmO42j2ew+d2Zy4gKLTsvDXWKs3GxEdLC2ipyaVuKuTw9qZmT/Z0Ae1AgkzBKkFzUmP/z 3TSpoiY1 Oz46PuCHcUADBJmKhsM5gyYRFGltKug1cci8Sqi2ay9UpLFWC8pphOYgJ8D3gi2JObHzV2m56m1rya0Gxx8yJxW2Wzh7dICMWZ38e9+2tcWdGMDRWoMVGbX/lROYlLoS0IcwSkGV7PsblQ0lj7rVyaOScV49W9U2l7mrYixpiklLImk3uKiYp+fl3JNY/crL4tZL1sAFKtaUEH4K9aYKR708X5j7R7/S67wqy522kjrEeAFODh15fE554Pnspo+SK+lClG/SaTOlq6FG/CBeaN7v+SP6N4dLlrmMrDz5ZPZdwTxh183LOVJg6nJM68m5kgJUlrt9sajk9VwQzw3kwpkdcofYawSrc1CL0+tGa6WJVLOQvL79emmTFd2QeeXA6zYOUa7sl5fWU4LQZF3YyYFr+236KinZNTxqTTU/llnjyXvYyhApfG/S7kfq6drNinnwmQxveYiV2tdU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 13 Sept 2024 at 04:47, Charlie Jenkins wrote: > > On Thu, Sep 12, 2024 at 06:00:18PM +0800, Chunyan Zhang wrote: > > When the virtual address range selftest is run on RISC-V platforms, > > it is observed that using the hint address when calling mmap cannot > > get the address in the range of that validate_addr() checks, also > > that will cause '/proc/self/maps' have gaps larger than MAP_CHUNK_SIZE. > > > > Signed-off-by: Chunyan Zhang > > --- > > tools/testing/selftests/mm/virtual_address_range.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/tools/testing/selftests/mm/virtual_address_range.c b/tools/testing/selftests/mm/virtual_address_range.c > > index 4e4c1e311247..25f3eb304999 100644 > > --- a/tools/testing/selftests/mm/virtual_address_range.c > > +++ b/tools/testing/selftests/mm/virtual_address_range.c > > @@ -64,6 +64,14 @@ > > #define NR_CHUNKS_HIGH NR_CHUNKS_384TB > > #endif > > > > +#if defined(__riscv) && (__riscv_xlen == 64) > > +static char *hind_addr(void) > > This is not a typo by you since this is the name of the original > function but this should be "hint_addr" right? Right, didn't notice this typo, let me fix it. > > > +{ > > + return NULL; > > +} > > + > > +static void validate_addr(char *ptr, int high_addr) { } > > +#else > > This is something that I am trying to solve over at > https://lore.kernel.org/lkml/20240905-patches-below_hint_mmap-v3-0-3cd5564efbbb@rivosinc.com/ > (the solution is still in flux). Since riscv doesn't currently have this > behavior of restricting the virtual address space, I think it is more > reasonable to disable this test entirely. After we have a longer-term > solution with the patch I have up we can adjust the test and re-enable > it. What do you think? That also makes sense, I will send another patch to do that. Thanks, Chunyan > > - Charlie > > > static char *hind_addr(void) > > { > > int bits = HIGH_ADDR_SHIFT + rand() % (63 - HIGH_ADDR_SHIFT); > > @@ -81,6 +89,7 @@ static void validate_addr(char *ptr, int high_addr) > > if (addr > HIGH_ADDR_MARK) > > ksft_exit_fail_msg("Bad address %lx\n", addr); > > } > > +#endif > > > > static int validate_lower_address_hint(void) > > { > > -- > > 2.34.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-riscv