From: Tahsin Erdogan <tahsin@google.com>
To: Tejun Heo <tj@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Wilson <chris@chris-wilson.co.uk>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Roman Pen <r.peniaev@gmail.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
zijun_hu <zijun_hu@htc.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers
Date: Mon, 27 Feb 2017 13:12:11 -0800 [thread overview]
Message-ID: <CAAeU0aPGvoYr=dtbRWT3=S5x9HmkUEiGmGWQy0JdFVu3F40N9g@mail.gmail.com> (raw)
In-Reply-To: <20170227204527.GG8707@htj.duckdns.org>
>> Doing preallocations would probably work but not sure if that can be
>> done without
>> complicating code too much. Could you describe what you have in mind?
>
> So, blkg_create() already takes @new_blkg argument which is the
> preallocated blkg and used during q init. Wouldn't it work to make
> blkg_lookup_create() take @new_blkg too and pass it down to
> blkg_create() (and also free it if it doesn't get used)? Then,
> blkg_conf_prep() can always (or after a failure with -ENOMEM) allocate
> a new blkg before calling into blkg_lookup_create(). I don't think
> it'll complicate the code path that much.
That makes sense. I will work a patch that does that (unless you are
interested in implementing it yourself).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-27 21:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 21:00 [PATCH " Tahsin Erdogan
2017-02-25 23:54 ` kbuild test robot
2017-02-26 0:48 ` kbuild test robot
2017-02-26 4:38 ` [PATCH v2 " Tahsin Erdogan
2017-02-27 9:52 ` Michal Hocko
2017-02-27 13:00 ` Tahsin Erdogan
2017-02-27 15:25 ` Michal Hocko
2017-02-27 17:01 ` Tahsin Erdogan
2017-02-27 17:07 ` Michal Hocko
2017-02-27 17:14 ` Michal Hocko
2017-02-27 19:32 ` Tahsin Erdogan
2017-02-27 19:47 ` Michal Hocko
2017-02-27 19:51 ` Tejun Heo
2017-02-27 20:27 ` Tahsin Erdogan
2017-02-27 20:29 ` Tejun Heo
2017-02-27 20:37 ` Tahsin Erdogan
2017-02-27 20:45 ` Tejun Heo
2017-02-27 21:12 ` Tahsin Erdogan [this message]
2017-02-27 21:28 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeU0aPGvoYr=dtbRWT3=S5x9HmkUEiGmGWQy0JdFVu3F40N9g@mail.gmail.com' \
--to=tahsin@google.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=chris@chris-wilson.co.uk \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=r.peniaev@gmail.com \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=zijun_hu@htc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox