From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3599C3815B for ; Tue, 14 Apr 2020 14:46:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8AAB12078B for ; Tue, 14 Apr 2020 14:46:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ta8EpRAk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AAB12078B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0BAAD8E0003; Tue, 14 Apr 2020 10:46:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06B7D8E0001; Tue, 14 Apr 2020 10:46:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E743B8E0003; Tue, 14 Apr 2020 10:46:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id CF9BD8E0001 for ; Tue, 14 Apr 2020 10:46:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8D74652A6 for ; Tue, 14 Apr 2020 14:46:20 +0000 (UTC) X-FDA: 76706736120.28.level61_5468589a88547 X-HE-Tag: level61_5468589a88547 X-Filterd-Recvd-Size: 6848 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 14:46:19 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id o1so4453860pjs.4 for ; Tue, 14 Apr 2020 07:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+zdkQJpk00tVVHPg9wMx+YTK7BOImj+ZGknhGf2n6U8=; b=ta8EpRAk05LKXQ35LBCbaNvLK4+nvOJfu5MTkOmCDcljBwwJjtHxaziC/PkPzul0Pi 7ta77J87xTp2EfehPJDMYE/y1liWoG9F+3pw3W89fDj3+KWYjHm8VBrW4xqaBtoSpVsg jvcxfXrZldJ6mQTHHXGToE8YtGpO+BQlbLeeB3GTayoJF3rf5SC/5B/KRVQritC1kmNa GlZYrCT+WGkEZXrK9tejNlacjpcgFRdDEBsg//n/9zHzVSjOrBXSNi7ABnkRxfwGEVi9 q8QB7skt9uspgF3YRN4gQquGacZ/L0Foq7IUSeCHCS/4ZRS+HY4HQJ4y7ALSiyLKGQ6K S5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+zdkQJpk00tVVHPg9wMx+YTK7BOImj+ZGknhGf2n6U8=; b=HfvzIpvWvIDr7c5FT7Ge2rR7xzpMsCtfLbn5u4J/udSfOpTwld/k0sh822g0RZun4Z UBf56WdwC5AfKbIizAOesPY7KbjufSrK9kUlIzJgdKYENMHHkjW62hcHfG1ryNiDtiJI hK180/2sxPbnri7L272kdsLV/kwyfaX3p2ulcra9e3spUpPNtD5ImdNtqFJlp7KQtOUL SZFTJ9Ahdoy3qgZvjkFoPS9BBUoQlK7RQ043uIdWNOVuupdznJiwVtipvWB+/N3sQZP3 iikLVMpTQgRtbZ9oJ8R5H0eDo8SxukwE6iMuMb8Z4njng1ELs1odZlkjpg8V2ldJ+gDP CLWg== X-Gm-Message-State: AGi0PuZZjHsqAs6EeRsnAu6cXmFK0fYh4tJ1HrKQVGwz5+N3oK0npq2Q EkEj9juIQCYgGojN4BoAqtQSg5Oz9EFklYoaDHptfQ== X-Google-Smtp-Source: APiQypLIwfCMsNGYEYLc7Q0DZEoYpOKXRhb89xWsEoWyyq1HVJvLJGZKejhJPor0pHjVH2IUCXzQ5atqt9YCVozsnNg= X-Received: by 2002:a17:902:b58f:: with SMTP id a15mr291030pls.336.1586875578627; Tue, 14 Apr 2020 07:46:18 -0700 (PDT) MIME-Version: 1.0 References: <20200325161249.55095-1-glider@google.com> <20200325161249.55095-21-glider@google.com> In-Reply-To: <20200325161249.55095-21-glider@google.com> From: Andrey Konovalov Date: Tue, 14 Apr 2020 16:46:07 +0200 Message-ID: Subject: Re: [PATCH v5 20/38] kmsan: handle memory sent to/from USB To: Alexander Potapenko , Alan Stern Cc: Andrew Morton , Greg Kroah-Hartman , Eric Dumazet , Wolfram Sang , Petr Mladek , Vegard Nossum , Dmitry Vyukov , Marco Elver , Linux Memory Management List , Alexander Viro , Andreas Dilger , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Christoph Hellwig , "Darrick J. Wong" , "David S. Miller" , Dmitry Torokhov , Eric Biggers , Eric Van Hensbergen , Harry Wentland , Herbert Xu , Ilya Leoshkevich , Ingo Molnar , Jason Wang , Jens Axboe , Marek Szyprowski , Mark Rutland , "Martin K. Petersen" , Martin Schwidefsky , Matthew Wilcox , "Michael S . Tsirkin" , Michal Hocko , Michal Simek , Qian Cai , Randy Dunlap , Robin Murphy , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vasily Gorbik Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 25, 2020 at 5:14 PM wrote: > > Depending on the value of is_out kmsan_handle_urb() KMSAN either > marks the data copied to the kernel from a USB device as initialized, > or checks the data sent to the device for being initialized. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Eric Dumazet > Cc: Wolfram Sang > Cc: Petr Mladek > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: Marco Elver > Cc: Andrey Konovalov > Cc: linux-mm@kvack.org > > --- > > This patch was previously called "kmsan: call KMSAN hooks where needed" > > v4: > - split this patch away > > Change-Id: Idd0f8ce858975112285706ffb7286f570bd3007b > --- > drivers/usb/core/urb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c > index da923ec176122..4a0b0ac0f52f9 100644 > --- a/drivers/usb/core/urb.c > +++ b/drivers/usb/core/urb.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -402,6 +403,7 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags) > URB_SETUP_MAP_SINGLE | URB_SETUP_MAP_LOCAL | > URB_DMA_SG_COMBINED); > urb->transfer_flags |= (is_out ? URB_DIR_OUT : URB_DIR_IN); > + kmsan_handle_urb(urb, is_out); I guess this could simply accept urb and then check urb->transfer_flags instead of also accepting is_out? Alan, do you think this is a good place for a call to kmsan_handle_urb(), which is supposed to check that the memory we pass to a USB device is initialized (so we don't leak uninitialized memory) and mark memory received from the device as initialized? You can find the implementation here: https://github.com/google/kmsan/commit/491a67cf03fa9e0f240fd6eb53a6074e4bfd1a2c#diff-020c941e2b8fc67f5ddca598cd954d57R322 > > if (xfertype != USB_ENDPOINT_XFER_CONTROL && > dev->state < USB_STATE_CONFIGURED) > -- > 2.25.1.696.g5e7596f4ac-goog >