From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE3F2C433DB for ; Fri, 15 Jan 2021 13:11:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A0472256F for ; Fri, 15 Jan 2021 13:11:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A0472256F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D2C538D0167; Fri, 15 Jan 2021 08:11:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CDBED8D0162; Fri, 15 Jan 2021 08:11:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C19058D0167; Fri, 15 Jan 2021 08:11:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id AD62C8D0162 for ; Fri, 15 Jan 2021 08:11:50 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 78BBE181AEF21 for ; Fri, 15 Jan 2021 13:11:50 +0000 (UTC) X-FDA: 77708046780.12.eggs44_18146f42752f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 5003518016BE2 for ; Fri, 15 Jan 2021 13:11:50 +0000 (UTC) X-HE-Tag: eggs44_18146f42752f X-Filterd-Recvd-Size: 4936 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 15 Jan 2021 13:11:49 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id q20so5463027pfu.8 for ; Fri, 15 Jan 2021 05:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6umvCsAyn8LNlLKR4Gh0cZmveVk8fGwHsSK6SRMZEbU=; b=SnDXl4aRWGAJQrgks0Grcn4RXlp7beT1MVhlVxEpU3TYCdsLusC3zjvFEdBUuJbxv9 voc4nnYlVMenWvl4emWLynQg+zP6dbg9orCRq6jch6Xo+bBEqF506NWzvkctVJt5RoXt gnC48NAEujee9t3+ov6QKNCwmWWsfv8FKzMu8tM6nwCi2XgYtRdDuycsaKnU+f43+vzN l5J0ux4ZYcJL1DWNpDSX+3O5LQiFQqs4O06LVTo9aEBm8GY2jy8s7s1bDiyn4LjH+RVp 4JR5HOFLoFUtEs9SLWWEeZIQERqV0NJe4sRXdgr05pMjVLS8WRsA/yMk8hhEsR4eQp/5 /kew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6umvCsAyn8LNlLKR4Gh0cZmveVk8fGwHsSK6SRMZEbU=; b=U+iLEry0cJnHrvt2nh9ZVpSvndLlWKi974z4havltOKnsN3qY2q7aKoWc6+eRvLoKf OPjaHoK5lbjIyRglGXcsvNvxBmj3xzKbwRL2PnrdggWMdzDva4+NuwN7GmG4QtKTtatR Aid1JeG/Y6sZAdT2yK/l8Gh9qJlAVs/1duBpiQgQuBVHlEzQHUuX7XGnNZXuXqK/TMC4 uZocNn4FuwJLekSLkq3auheRijX+A+YECHDH4rFdMunHLR2juVjeqheNrlVIngDl+0/e SNdyhq1fdG/ruv3+e3r/fBTrCPqbNaKS83I1BMFwMma1FeYTwSJf0cKJn3ACipi16kPx 67ow== X-Gm-Message-State: AOAM532+HCWn6NeZpphdead9tvpVGFA58xeojE19nllLHaG82fAiQo2p OslM/DkBZlPFe0zEONGVpPLdLxBmVS/2RutN6q1oRQ== X-Google-Smtp-Source: ABdhPJxP4nRrKwZSBlUFpmikVpl6k4pzHnULL/yc60R1uCe8Ns1peu8s87V06K5tB60ue3skQrwX/CMP31Tu2zYjM9o= X-Received: by 2002:a62:e309:0:b029:1ae:5b4a:3199 with SMTP id g9-20020a62e3090000b02901ae5b4a3199mr12292780pfh.24.1610716308705; Fri, 15 Jan 2021 05:11:48 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Fri, 15 Jan 2021 14:11:37 +0100 Message-ID: Subject: Re: [PATCH 05/11] kasan, arm64: allow using KUnit tests with HW_TAGS mode To: Catalin Marinas Cc: Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Andrew Morton , Will Deacon , Andrey Ryabinin , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 12, 2021 at 8:01 PM Catalin Marinas wrote: > > On Tue, Jan 05, 2021 at 07:27:49PM +0100, Andrey Konovalov wrote: > > diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c > > index 3c40da479899..57d3f165d907 100644 > > --- a/arch/arm64/mm/fault.c > > +++ b/arch/arm64/mm/fault.c > > @@ -302,12 +302,20 @@ static void die_kernel_fault(const char *msg, unsigned long addr, > > static void report_tag_fault(unsigned long addr, unsigned int esr, > > struct pt_regs *regs) > > { > > - bool is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > + static bool reported; > > + bool is_write; > > + > > + if (READ_ONCE(reported)) > > + return; > > + > > + if (mte_report_once()) > > + WRITE_ONCE(reported, true); > > I guess the assumption here is that you don't get any report before the > tests start and temporarily set report_once to false. It's probably > fine, if we get a tag check failure we'd notice in the logs anyway. Good point. I'll add a note in a comment in v4. > > /* > > * SAS bits aren't set for all faults reported in EL1, so we can't > > * find out access size. > > */ > > + is_write = ((esr & ESR_ELx_WNR) >> ESR_ELx_WNR_SHIFT) != 0; > > I now noticed, you could write this in a shorter way: > > is_write = !!(esr & ESR_ELx_WNR); > > > kasan_report(addr, 0, is_write, regs->pc); > > } Will do in v4. > The patch looks fine to me. > > Reviewed-by: Catalin Marinas Thanks!