From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A46CC433DF for ; Mon, 19 Oct 2020 17:34:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1220222EA for ; Mon, 19 Oct 2020 17:34:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bQfZ0uUm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1220222EA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E37946B005D; Mon, 19 Oct 2020 13:34:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE9C06B0062; Mon, 19 Oct 2020 13:34:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD6DD6B0068; Mon, 19 Oct 2020 13:34:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 9AF816B005D for ; Mon, 19 Oct 2020 13:34:11 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1DA3E3623 for ; Mon, 19 Oct 2020 17:34:11 +0000 (UTC) X-FDA: 77389373502.21.gun20_5e0144227238 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id E97D5180442C0 for ; Mon, 19 Oct 2020 17:34:10 +0000 (UTC) X-HE-Tag: gun20_5e0144227238 X-Filterd-Recvd-Size: 4070 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Mon, 19 Oct 2020 17:34:10 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id y14so345057pgf.12 for ; Mon, 19 Oct 2020 10:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G5rjackHCXux/EOEOhw9b0KT9npfluDyAp2p7HpwGaQ=; b=bQfZ0uUmc4a1+7282KvpS6VxDOyxzFiVk30B1cfvXgHWoucBI4PlZgrrWHLNiBqLF9 f43GVvAQUG6ZcHbr/HCZXMv7FJvDA1bD/JSn6eyOfVhXJxGBlmn+tZvdnj7ePcIXhCbY /UU10phXk9rYjC7NPJ08YUEvken2H+rOvMS5jOA9bpSyv3O3iE/x0oqBBR7M6UuUx4l0 j7xZN3QgfELWcgZAX0nZ+w2djGvq6hbTVKhaaujFnJUPxjUGf6jPzIvejH7YCt6o16+V hVYO+dScnRRv2jhfxxQUXuASJyWUrr6wUOGAwB8CkCOJavodmPtqieHOFjD4aGLenNv1 s75g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G5rjackHCXux/EOEOhw9b0KT9npfluDyAp2p7HpwGaQ=; b=ia+hkXaHXPJQ8mVmLueGKeNYI0og/h7UOYCeQvZjUEZ83vgnijQ8ggLY1NWvvzZN7l Glz+e53j5I6ZYZCQMNZB2XQ/w9hfEIBf5DsDmJ1u23EQH4XFOPb0/5me3M8bM2+MJg9I 6v7QFM/i42/cGdSZULq8xJK5R6+F0Al2dwno0y65uDu1t21vGPiSsfwmgKx8IVxAWWN+ jb05Z4SBZGf/sxhkUgUDh7MgAvnsnE5R51JrFidSoYIwDsxDMvTRy6xa8m5cXSuaW0bv U+1ID42H1UXYYCDsj56fycfxCwVnlZ9gqL4ayK2KLlGxpog6CoOaRWJLK4CmDEpe+W60 p8Eg== X-Gm-Message-State: AOAM532FyARfc0Ege5nFNo2GBDejIhynjDvtOyoUs4+7FXYy0rQVMLwJ jUEWCsmO5veT7vXS1T5h19AT9DRELxDHfaVHlHexKA== X-Google-Smtp-Source: ABdhPJwEcZvdVEQl4Pv26jjEuNJj+teJXpN4LQ9zSwZ/v1q1cuw4bCYWpOp3mgzjKLNTNLgiBoxwpb7HgB1kDGeJKhE= X-Received: by 2002:a63:1906:: with SMTP id z6mr686372pgl.286.1603128849279; Mon, 19 Oct 2020 10:34:09 -0700 (PDT) MIME-Version: 1.0 References: <44861eaca17ffbb51726473bc8e86ad9e130c67e.1602876780.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 19 Oct 2020 19:33:58 +0200 Message-ID: Subject: Re: [PATCH] kasan: adopt KUNIT tests to SW_TAGS mode To: David Gow Cc: Andrew Morton , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Vincenzo Frascino , kasan-dev , Linux Memory Management List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 17, 2020 at 9:42 AM David Gow wrote: > Hi David, [...] > This looks good to me. Though, as you mention, writing to freed memory > might not bode well for system stability after the test runs. I don't > think that needs to be a goal for these tests, though. We generally tried to avoid this, since we run multiple tests, and if one crashes the kernel, the rest won't work. I'll fix this in v2. > One thing which we're hoping to add to KUnit soon is support for > skipping tests: once that's in place, we can use it to mark tests as > explicitly skipped if they rely on the GENERIC mode. That'll take a > little while to get upstream though, so I wouldn't want to hold this > up for it. This will indeed be useful. > Otherwise, from the KUnit side, this looks great. > > I also tested it against the GENERIC mode on x86_64 (which is all I > have set up here at the moment), and nothing obviously had broken. > So: > Tested-by: David Gow Perfect, thank you!