From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F8F2C433E6 for ; Fri, 8 Jan 2021 18:25:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E09BD23A7C for ; Fri, 8 Jan 2021 18:25:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E09BD23A7C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 31BC88D0190; Fri, 8 Jan 2021 13:25:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A7348D0156; Fri, 8 Jan 2021 13:25:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16EB08D0190; Fri, 8 Jan 2021 13:25:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id F24EE8D0156 for ; Fri, 8 Jan 2021 13:25:41 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BB4C98245571 for ; Fri, 8 Jan 2021 18:25:41 +0000 (UTC) X-FDA: 77683436082.10.blade61_3903a7e274f5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 9558116A046 for ; Fri, 8 Jan 2021 18:25:41 +0000 (UTC) X-HE-Tag: blade61_3903a7e274f5 X-Filterd-Recvd-Size: 4062 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 Jan 2021 18:25:40 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id v3so6069813plz.13 for ; Fri, 08 Jan 2021 10:25:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TvvXV7bEAAhRZbN5Xzp/cblWdK/NVPGWOn4od85Z6/w=; b=d+L+HGQnJ8GkivLJcq4DSA2uJmUEaepv00NVO6HXnXJPKMFc+PtcXC1FqGYoEuOMyT s0pXM7/rVZSEDTRSIpT0t7Rd5Ha5ua5EkBbHlDLbrV82y4x5LFvv9+DKrxf2mNewLhOA oGwdlDMpLGuBuvDgbAgAeHZWF4BmA3bl/h5vs5xK9x43q3QakNcdeCuV+Edzegzk8S3f XLZDkOrFMrItw47dJOMCaGb0qkDDVq8mYsC6UXU0Z9t0t09FLfNAqWiikYHfXz6MSSBq 4GKoC01+QiIWSjcxFl8QSUjD9ZlV+xv8AnZlaqcp4j+Jdg9qGFXMYI3dAmqV8mLxDtVQ z4pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TvvXV7bEAAhRZbN5Xzp/cblWdK/NVPGWOn4od85Z6/w=; b=aWy4tSzHdVSz3uJuRw+F/4+ndjeco1lHRk5XMoKZry/MRX9kOYyxqr7lUp2YhB2Wr5 lLZpsoWDsbp98EIEvMsDXcdXfUy81VmVl+t/BXCsuAlbrgKKYBxp1twNGnRI7rc/OMut JDM7dDGJsVb8uKGP+Z56ad0ryhLnEWdIrZeC0FoLNGTTOj9nmI87HG+LmpgnrAe6rO0t TfLI29ha75mkOyNAnpliYMaRUFzFrXNM1hZaHBfkXultUPsKdUM7//BzU9FSGq8gPjFv bvsK4T3i+NLXOM8GojQgQF7Stz36YwCnJE5O+OJuK+l9dn8hIBGgDxi+n5mUI2T4g4Xw e2hA== X-Gm-Message-State: AOAM533S04ygJUNpmEnK1yQXq4u1zecTDnCQ56B+t/qYBQvav7spdHcC nHxyFtE+UnWkMnlfCUfVFxGHVNRLM3Z+CFv5aL4Rww== X-Google-Smtp-Source: ABdhPJyeJJzO6h/di2HJL1UmMv07+bcKcaBYuL/EVRKkCR5n8bUJwaYA/emooOx9egKITTXFLdGAXEu23w8IL5O6hTg= X-Received: by 2002:a17:902:9009:b029:dc:52a6:575 with SMTP id a9-20020a1709029009b02900dc52a60575mr4902482plp.57.1610130339630; Fri, 08 Jan 2021 10:25:39 -0800 (PST) MIME-Version: 1.0 References: <20210103063847.5963-1-lecopzer@gmail.com> In-Reply-To: <20210103063847.5963-1-lecopzer@gmail.com> From: Andrey Konovalov Date: Fri, 8 Jan 2021 19:25:28 +0100 Message-ID: Subject: Re: [PATCH] kasan: fix incorrect arguments passing in kasan_add_zero_shadow To: Lecopzer Chen Cc: LKML , Linux Memory Management List , kasan-dev , Dan Williams , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com, Lecopzer Chen Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 3, 2021 at 7:39 AM Lecopzer Chen wrote: > > kasan_remove_zero_shadow() shall use original virtual address, start > and size, instead of shadow address. > > Fixes: 0207df4fa1a86 ("kernel/memremap, kasan: make ZONE_DEVICE with work with KASAN") > Signed-off-by: Lecopzer Chen > --- > mm/kasan/init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index bc0ad208b3a7..67051cfae41c 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -481,7 +481,6 @@ int kasan_add_zero_shadow(void *start, unsigned long size) > > ret = kasan_populate_early_shadow(shadow_start, shadow_end); > if (ret) > - kasan_remove_zero_shadow(shadow_start, > - size >> KASAN_SHADOW_SCALE_SHIFT); > + kasan_remove_zero_shadow(start, size); > return ret; > } > -- > 2.25.1 Reviewed-by: Andrey Konovalov