From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D4DDC433E1 for ; Thu, 27 Aug 2020 12:38:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBCC72177B for ; Thu, 27 Aug 2020 12:38:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="crL7nHRg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBCC72177B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D81C900006; Thu, 27 Aug 2020 08:38:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4611F8E0006; Thu, 27 Aug 2020 08:38:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 328AA900006; Thu, 27 Aug 2020 08:38:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 18AAB8E0006 for ; Thu, 27 Aug 2020 08:38:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C00D2180AD806 for ; Thu, 27 Aug 2020 12:38:09 +0000 (UTC) X-FDA: 77196301098.27.fight85_58031172706d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 91E6A3D668 for ; Thu, 27 Aug 2020 12:38:09 +0000 (UTC) X-HE-Tag: fight85_58031172706d X-Filterd-Recvd-Size: 4247 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 12:38:09 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id 67so3242828pgd.12 for ; Thu, 27 Aug 2020 05:38:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5sih6/oMnkYkkS4cZqAk1lLuHR7D9bxWXGtKLgy7ous=; b=crL7nHRgDL6EYVd4SPOphDL7ayvhOANRH0SS14x5PME3S6QDy/8CjwFEhnh5jNMMsX +aGRaEjd8vkwjKv3A0GgdlYsHTz/PIxBLY+sqbXxDoZGLpI829YiRwLYHdjXhj7HMkKo XdI6PWvxhTZHL5fo5aYbpxgVu54v3pRbUtHC0KXp1W7zdnDpfJ3dGN0CGc1UASxvteCa g4RZhpt3yCS7niq/EkYg8sX+siekdpNjdQ1/O4Mm5/fLmqsCAGWBPp/rrSE/pYujCcvI 0dj2sxYci3WMyZPdZAVla5Y8RvrIFgjFUyXJ6sSaXGzHMoehwVOeOPc1UyOx9r8jBB2P dV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5sih6/oMnkYkkS4cZqAk1lLuHR7D9bxWXGtKLgy7ous=; b=kw2uXQZBSEN2///tBpg0RSlUfFAvTCrx5j82Yhggo2pOE1aEw9urXpMIRdgRmjD6YD imQw5DDDkCkQrp3rpUvcR6peW3ZjQ1ssysVqMNze1c6R5FRSUgZyTuDgMTR4DQoW3ogd YsC2GTh0+hcqHiTK7lsO8K7G2qhBAHKNgNBqhVqcVIYN5SV2Liex2R9n9jabgCV8EBMl IqJsOIy5zjxmztKNNwLPOe7cSU0QGtX7Bx9Hpey9SpXJDZ8XCxnNtCE3oYAnINtbQE++ jUZU1BljoIkAXZUnXE7HraZj4+sAIrUiVGY4qQYI3MjnmJB0W/CpirYWZVZGR0e2gePB wjdA== X-Gm-Message-State: AOAM533iUV/L3WCgYLMQXA3z34OK+dAn30i0de568l90xZOtVTt4xjAm rcNrft6C7qHLfqXibIiHpYw4IB1vXdweqIMCSmqrdg== X-Google-Smtp-Source: ABdhPJwcv+HIw2fTTEzf/r324JRbSbst5zk+Xxyw2x8H8damlHOBL7tGL4/iW+RZZqqulewQX1qyqFolYBORJa+oZQA= X-Received: by 2002:a62:2bcc:: with SMTP id r195mr7684877pfr.123.1598531888012; Thu, 27 Aug 2020 05:38:08 -0700 (PDT) MIME-Version: 1.0 References: <4e86d422f930831666137e06a71dff4a7a16a5cd.1597425745.git.andreyknvl@google.com> <20200827104517.GH29264@gaia> In-Reply-To: <20200827104517.GH29264@gaia> From: Andrey Konovalov Date: Thu, 27 Aug 2020 14:37:57 +0200 Message-ID: Subject: Re: [PATCH 31/35] kasan, arm64: implement HW_TAGS runtime To: Catalin Marinas Cc: Dmitry Vyukov , Vincenzo Frascino , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 91E6A3D668 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 12:45 PM Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:13PM +0200, Andrey Konovalov wrote: > > diff --git a/mm/kasan/mte.c b/mm/kasan/mte.c > > new file mode 100644 > > index 000000000000..43b7d74161e5 > > --- /dev/null > > +++ b/mm/kasan/mte.c > > Since this is an arm64-specific kasan backend, I wonder whether it makes > more sense to keep it under arch/arm64 (mte-kasan.c). I'm not sure if we do. I'd rather keep everything together, spreading the implementation around the kernel is inconvenient. We already have software tag-based KASAN implementation (which is also arm64-specific) in the common code. We could, perhaps, rename mte.c into something more generic, with other potential future hardware modes in mind. > > diff --git a/mm/kasan/report_mte.c b/mm/kasan/report_mte.c > > new file mode 100644 > > index 000000000000..dbbf3aaa8798 > > --- /dev/null > > +++ b/mm/kasan/report_mte.c > > Same for this one.