From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F599C433DB for ; Mon, 8 Mar 2021 14:14:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E9E86651D3 for ; Mon, 8 Mar 2021 14:14:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9E86651D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 666528D002E; Mon, 8 Mar 2021 09:14:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63CB28D001D; Mon, 8 Mar 2021 09:14:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52CD98D002E; Mon, 8 Mar 2021 09:14:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 3121D8D001D for ; Mon, 8 Mar 2021 09:14:34 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E48F352A0 for ; Mon, 8 Mar 2021 14:14:33 +0000 (UTC) X-FDA: 77896902426.23.126608E Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf11.hostedemail.com (Postfix) with ESMTP id 56F2320003BF for ; Mon, 8 Mar 2021 14:14:29 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id cl21-20020a17090af695b02900c61ac0f0e9so4084357pjb.1 for ; Mon, 08 Mar 2021 06:14:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gw2zAlnEvV8GmMv5rpZu0isYBOrALdBIALM778oYDbQ=; b=PVVo8+KwgkIH14fT6zZn7SWmQIG6hT4lQcWpMRyFkRHYymWycNwu1GmHW8VV1Rn+Ic pjG+NUM0FIOyCuPjuoxCixxmMoy01TmvG2szp96o6F1VmPbucm77SBAjUiMd8MnLnJQm OQxBvMZukbTKCSaEFzRKsATCWKgvQPZX1+djycAP86AB6RHVMqVUTHDkXsI135EY5mto ygdazUk1kuQT2XVPQJDBNdWaBqU8T/EXvs+x83qE+zOzhpXX9PyhA7e/w7fV1OH9iImH GIaA1x74J1U3vQJtwbIbZkyp+Qu+11cZEpRGVMbyGLeqN7DSCzq5Kp2hnQ8dkILChPlY r0lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gw2zAlnEvV8GmMv5rpZu0isYBOrALdBIALM778oYDbQ=; b=ql3v+D79lWvFsDXVSNPdl5Wzg+PBevhQPCBcPi0iI19mp+Cuy7k+lZRYdYmTWgUDhp XNP4sKxqqWI2EqNqmvakWLGiAPoPfX9oYDYM9bpFnAufjt0zHVttIGhk5IrWFaLTsJ8z WbAzl2wX5eyt4FVxfYDnvlCVW8rhRSakmuHC6B18aTShRERymSq/mcM5TNT2Hne6suk7 2DPuvuba0ODtlyTDfd5s4y3PMi5S19MzoBOEZGUGQDuLtDex/p1YszUYNGUjNwN+yQ7F DOMuVF9LyKCXmc6NtFTHkxKsR+NNIU4+b6UEeeQE87ombZrj8qypVtw/H2Su2x/C5LWi RCIw== X-Gm-Message-State: AOAM532iES5PfpaD4Ces3W0Yl4PCTTWgO89U5/MoJdQlvqhCamMU8udC u0NHKHqgk/tzMjRJebCWCUqUpoNcwX6BCgkzI07RQw== X-Google-Smtp-Source: ABdhPJwQLOEsO6igg+U6iMFD+X/dVMrg/U1V1ChGDrskM8X1TXNS6EhiRPpXVDYrHGOap6Ggho8cp4rTMfIaRvHJ3fw= X-Received: by 2002:a17:903:31ca:b029:e6:65f:ca87 with SMTP id v10-20020a17090331cab02900e6065fca87mr11507964ple.85.1615212872017; Mon, 08 Mar 2021 06:14:32 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 8 Mar 2021 15:14:21 +0100 Message-ID: Subject: Re: [PATCH 3/5] kasan, mm: integrate page_alloc init with HW_TAGS To: Marco Elver Cc: Alexander Potapenko , Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: hsj6cp19yp4c1tz6ujurczra5td4g4rz X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 56F2320003BF Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=mail-pj1-f42.google.com; client-ip=209.85.216.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615212869-951703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 8, 2021 at 12:35 PM Marco Elver wrote: > > > - kasan_free_nondeferred_pages(page, order, fpi_flags); > > + init = want_init_on_free(); > > + if (init && !IS_ENABLED(CONFIG_KASAN_HW_TAGS)) > > Doing the !IS_ENABLED(CONFIG_KASAN_HW_TAGS) check is awkward, and > assumes internal knowledge of the KASAN implementation and how all > current and future architectures that support HW_TAGS work. > > Could we instead add a static inline helper to , e.g. > kasan_supports_init() or so? > > That way, these checks won't grow uncontrollable if a future > architecture implements HW_TAGS but not init. Good idea, I'll add a helper in v2. > Hmm, KASAN certainly "supports" memory initialization always. So maybe > "kasan_has_accelerated_init()" is more accurate? I leave it to you to > decide what the best option is. Let's call it kasan_has_integrated_init(). Thanks!