From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D37D4C433E6 for ; Thu, 14 Jan 2021 18:01:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B9AA23B78 for ; Thu, 14 Jan 2021 18:01:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9AA23B78 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D86C58D0100; Thu, 14 Jan 2021 13:01:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5E108D00F0; Thu, 14 Jan 2021 13:01:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4E438D0100; Thu, 14 Jan 2021 13:01:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id AFB6E8D00F0 for ; Thu, 14 Jan 2021 13:01:54 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7A388181AF5E6 for ; Thu, 14 Jan 2021 18:01:54 +0000 (UTC) X-FDA: 77705148948.20.mouth19_5a0a12d27528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 4008C180C060F for ; Thu, 14 Jan 2021 18:01:53 +0000 (UTC) X-HE-Tag: mouth19_5a0a12d27528 X-Filterd-Recvd-Size: 4292 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 18:01:52 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id x18so3301159pln.6 for ; Thu, 14 Jan 2021 10:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JZv4YjfcgChZSuWtgMAj6ahr1eW9ywFtx/Fxp020AaY=; b=Rm6m7vXoHi68V0d+j08hWcmBizYwZFtmyFLHHMyw4nWdnaUNBfgNjt/JIfOXVqskOp 9s1GsRh+JgM7mCcvmr0fiuSQv2wdylTkfv+1r5y0lcK1dbldOtdLa05ZbHg9vR2LnQAf 4D53VfDIceaWsawDWPBXsE6IntyuOeBk+xNt7ul6WlR7eN0qEJA8WgrXoN9JwmXof8/n pz93OMkOqPZD5SexDtlWJpyKY4t1jojH1tpgGEitEJlzPG4bcWU8RK9YTDnxZ51A5WQV 2igDoFfjj9hpgLSjU1Z1tDdEdYLRrDhi1rm/CDIUlu8mDq5w4cfT7OwipKCi1Obq+gZi ZJ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JZv4YjfcgChZSuWtgMAj6ahr1eW9ywFtx/Fxp020AaY=; b=qcJgPyy6SY5RegzXTHnNL2gPuaikV7WPtQiyNHErxpva+j89FxiQlaheNP/ToK7jnL hyP7m0uQRSaFmzjBdQhaR9c+9Xeg7JATQAmT2hBK8qhvuA736eIzapYh1bqdCnJIbFzA GvQtEsN8BNAtviAIohbTZ3dL4/ShO4e9wWQlyB5FjJu7OF9M342h0qEd/aS1ijewQNYu Oem4HS09ClPyLOiaHjUWvcaB+C03GwzOt0fVfD4H6SaIZTxatQAfHvvf8akA13NZe02R fAlGK2d8ha8HK/TBt/R0BWSiN+Ig9+YJAvlxwv//170UmCwKRgat0SBRgFhMZxiVhkHC hl/A== X-Gm-Message-State: AOAM5316xjS5rXBw3b9GWDxD1dyCurfSz4RUCyqgyMzU6xXsnljSVolj dUYshub5E/aifncjrcv9DGl/5/lhcsWtcroJdOfqgA== X-Google-Smtp-Source: ABdhPJy0s4/a2xn2D2HxerBaHTjLtujT+Fg1JxsQy1qheSdNwkcolbjsyD/LGCmA3l0QYAvncD62Ygr9tvPuRG4oljY= X-Received: by 2002:a17:902:9009:b029:dc:52a6:575 with SMTP id a9-20020a1709029009b02900dc52a60575mr8283559plp.57.1610647311542; Thu, 14 Jan 2021 10:01:51 -0800 (PST) MIME-Version: 1.0 References: <77015767eb7cfe1cc112a564d31e749d68615a0f.1610554432.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 14 Jan 2021 19:01:40 +0100 Message-ID: Subject: Re: [PATCH v2 11/14] kasan: fix bug detection via ksize for HW_TAGS mode To: Marco Elver Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 5:54 PM Marco Elver wrote: > > > +/* > > + * Unlike kasan_check_read/write(), kasan_check_byte() is performed even for > > + * the hardware tag-based mode that doesn't rely on compiler instrumentation. > > + */ > > +bool __kasan_check_byte(const void *addr, unsigned long ip); > > +static __always_inline bool kasan_check_byte(const void *addr, unsigned long ip) > > +{ > > + if (kasan_enabled()) > > + return __kasan_check_byte(addr, ip); > > + return true; > > +} > > Why was this not added to kasan-checks.h? I'd assume including all of > kasan.h is also undesirable for tag-based modes if we just want to do > a kasan_check_byte(). It requires kasan_enabled() definition. I can move both to kasan-checks.h if you prefer. However, the only place where kasan_check_byte() is currently used includes kasan.h anyway.