From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79165C433E0 for ; Mon, 11 Jan 2021 17:40:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE2B520738 for ; Mon, 11 Jan 2021 17:40:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE2B520738 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A9C76B010C; Mon, 11 Jan 2021 12:40:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 55AA46B0136; Mon, 11 Jan 2021 12:40:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D5326B014E; Mon, 11 Jan 2021 12:40:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 286B06B010C for ; Mon, 11 Jan 2021 12:40:21 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D42CE8245571 for ; Mon, 11 Jan 2021 17:40:20 +0000 (UTC) X-FDA: 77694208200.29.army39_10021e32750e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 80239180868C1 for ; Mon, 11 Jan 2021 17:40:20 +0000 (UTC) X-HE-Tag: army39_10021e32750e X-Filterd-Recvd-Size: 4877 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 17:40:19 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id b8so231018plx.0 for ; Mon, 11 Jan 2021 09:40:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qjQEnNzMbx9jfPqlYY0N0jYj1R3Q/O+LmSxzsF9dUuI=; b=vMdJQPxBpe62gqG1pM4PczjRnOrPEyBn6OX27rJgh3RoP9Bb8niJeXWnlLtYASKzs1 3tec2zfE91shpqvsoUtUzkG/s3YvNOUBIs6QRIpbj5A2uTZilfmqSgEHCupMdmtcskw3 z/0Ho9FHyV3j6J1WTeTJ6ki8j0WWTYpMEMl0kNXESAM7BHsOSEN5BvaVIJrRezTX9O++ 54WMwrTMCRPa2hxQD6G+aGtFz3ktlz5+uiSLFgT2YlOhNAAkdL03lR/0nNzjGTsVyTJY FPQNiuvc4oFV+C92Xx1rH933KYdXsTRE6t9fEHQ3WjlZaghphrDKguNdYDsJa+44c0Ob da3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qjQEnNzMbx9jfPqlYY0N0jYj1R3Q/O+LmSxzsF9dUuI=; b=CbbINBwsnT1I7KqMfyJAzgmAKQUskknb7Bo9rSMB9f4aCbIVs9zBnuzb/2Iex3HVgs Z17kgAiRnAyvEdVXCsqMScfSM6KSL3IdNDHNllcSj0UafdBOF9WcnZz0m8kymYvoljWI 4LdpS396169czuYvot9Pt6SHFzataxA5zvKeVu8JU/raf7cDAtca0zqKYkUkAEAPMqNy oxkGdiF2U077sJgTtatM8WSxZNOxE3K2pjoio292ehmWT6IG82y6I6NHyZDcQ2iU0C2v rYZzWreMV0RoR6RcIVYkNiRtcKnQxbRxz7Lqi35Bw5GVTEM8vRCIWfNlZOqGzVQTbRAl uEzw== X-Gm-Message-State: AOAM533qTrNF/ZkrnQqqbcmh81AMvawoU+wejXr0fOPQ9eM0RZWhA5Tz TAlfcL8D3k8HJAG6NOjI/GFCJNp/3vZMCHKFHMLw5Q== X-Google-Smtp-Source: ABdhPJz90wo+LNABRutfNJ9IAurAbJzzUQp2ytJ+Y6N0wWoqRh/YQRSb/ZBZwZsHxcnBTnLqMoLIoyxfsgW7wTllDmY= X-Received: by 2002:a17:90a:f683:: with SMTP id cl3mr383204pjb.136.1610386818720; Mon, 11 Jan 2021 09:40:18 -0800 (PST) MIME-Version: 1.0 References: <20210108040940.1138-1-walter-zh.wu@mediatek.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 11 Jan 2021 18:40:07 +0100 Message-ID: Subject: Re: [PATCH v3] kasan: remove redundant config option To: Arnd Bergmann Cc: Walter Wu , Arnd Bergmann , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Nathan Chancellor , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , "moderated list:ARM/Mediatek SoC..." Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 8, 2021 at 9:31 PM Arnd Bergmann wrote: > > On Fri, Jan 8, 2021 at 7:56 PM Andrey Konovalov wrote: > > On Fri, Jan 8, 2021 at 5:09 AM Walter Wu wrote: > > > > @@ -2,6 +2,12 @@ > > > CFLAGS_KASAN_NOSANITIZE := -fno-builtin > > > KASAN_SHADOW_OFFSET ?= $(CONFIG_KASAN_SHADOW_OFFSET) > > > > > > +ifdef CONFIG_KASAN_STACK > > > + stack_enable := 1 > > > +else > > > + stack_enable := 0 > > > +endif > > > + > > > > AFAIR, Arnd wanted to avoid having KASAN_STACK to be enabled by > > default when compiling with Clang, since Clang instrumentation leads > > to very large kernel stacks, which, in turn, lead to compile-time > > warnings. What I don't remember is why there are two configs. > > > > Arnd, is that correct? What was the reason behind having two configs? > > I think I just considered it cleaner than defining the extra variable in the > Makefile at the time, as this was the only place that referenced > CONFIG_KASAN_STACK. > > The '#if CONFIG_KASAN_STACK' (rather than #ifdef) that got added > later do make my version more confusing though, so I agree that > Walter's second patch improves it. > > Acked-by: Arnd Bergmann Got it, thanks! > On a related note: do you have any hope that clang will ever fix > https://bugs.llvm.org/show_bug.cgi?id=38809 and KASAN_STACK > can be enabled by default on clang without risking stack > overflows? Not sure :( I've filed this on KASAN bugzilla to not forget: https://bugzilla.kernel.org/show_bug.cgi?id=211139