From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B497C433DB for ; Thu, 14 Jan 2021 15:33:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D18442311F for ; Thu, 14 Jan 2021 15:33:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D18442311F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 426298D00EB; Thu, 14 Jan 2021 10:33:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AD0A8D008E; Thu, 14 Jan 2021 10:33:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A02B8D00EB; Thu, 14 Jan 2021 10:33:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 0DD818D008E for ; Thu, 14 Jan 2021 10:33:07 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC51D824556B for ; Thu, 14 Jan 2021 15:33:06 +0000 (UTC) X-FDA: 77704773972.05.house85_0f093cf27527 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id A96D1180991E6 for ; Thu, 14 Jan 2021 15:33:06 +0000 (UTC) X-HE-Tag: house85_0f093cf27527 X-Filterd-Recvd-Size: 6941 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 15:33:06 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id cq1so3266776pjb.4 for ; Thu, 14 Jan 2021 07:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rZ/Nqkyz1NzBbC9d12mdlvYcjVEDi+jgRuueCoXzbVA=; b=eBy7cKZ3wJTClUI2m4kVw3DQiatogxgxrOB9kFInZXzWgT9o1em7B0C8OJhCIexOzK +/sswB2OtP1hVYCA6xofoubvfW34RgqeFLiuf5UkQGIPiAhQtzpaWbz4ue1rGh+9R7uA k9smac70hwrCG8+H4aGrdKpV/OvylmT1FyiSQd9QOmzCkhseRJLHb2OxUrZkKP/spyNS iIF06rNO5kiuxn1nYtwL8r0cKIP85jC+AX+xefTiUHFco4CR6a7vcKK63aY4cH2+k28Y 7c9hN9hUdwZqAQcswUVPvI+hkmFcpjTyS0hwWiAdcD5EYm3nQSuN8AzuUGdeT1G/Sd1L N5WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rZ/Nqkyz1NzBbC9d12mdlvYcjVEDi+jgRuueCoXzbVA=; b=QVJuBC6iBglbyMCahgyN2l5HDB0iFSx3i7CwQcY8YVoZG5kR5mtMWEUARBIT4Qn3EU plZVEF+t6xNW6T8J+O8atU+tT43JScn9dViGwce5gDdGsQ7IzUeEFOvuHaSUZM47tdMC 5ELaBQORMluljdS17laaumseXqA9QEoXnErDW7jAHKaNuxDsEQX2ZzrhaOgRrWPWPzMr zjm5BoX4xVvIeIJIoyt10jejdyxL3yblhG/meelan2ufYFkZQybB2IElegatL9U0Kf2r ggG+kNMhffo9jtemkv9plw58x/u/XKSnNyR8RVeAUaLIRLQvWpEmyYLibblkUszWnQWM /s/g== X-Gm-Message-State: AOAM530wCQjCNHzA1gzduM7Rhqf/qeaxMFWhpyQFX/gMGO4mS4hekerm LIx6PU3G+OtjccSttv+fWuNcQuV3NjXqJioqN3DeRg== X-Google-Smtp-Source: ABdhPJy9YlSK775KH1/FQc1fPdS9o7AWBR5938KXfynV1LFLq0CO1yXSF9AJJK5LDeVRvLPNUiRAuUQSqMPKdmNPjMo= X-Received: by 2002:a17:90b:350b:: with SMTP id ls11mr5447639pjb.166.1610638384902; Thu, 14 Jan 2021 07:33:04 -0800 (PST) MIME-Version: 1.0 References: <0e994d67a05cbf23b3c6186a862b5d22cad2ca7b.1610554432.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 14 Jan 2021 16:32:53 +0100 Message-ID: Subject: Re: [PATCH v2 13/14] kasan: add a test for kmem_cache_alloc/free_bulk To: Marco Elver Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 5:38 PM Marco Elver wrote: > > On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > > > Add a test for kmem_cache_alloc/free_bulk to make sure there are now > > false-positives when these functions are used. > > s/now/no/ (but by itself doesn't necessarily demand a v3) > > > Link: https://linux-review.googlesource.com/id/I2a8bf797aecf81baeac61380c567308f319e263d > > Signed-off-by: Andrey Konovalov > > --- > > lib/test_kasan.c | 39 ++++++++++++++++++++++++++++++++++----- > > 1 file changed, 34 insertions(+), 5 deletions(-) > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > index 5e3d054e5b8c..d9f9a93922d5 100644 > > --- a/lib/test_kasan.c > > +++ b/lib/test_kasan.c > > @@ -479,10 +479,11 @@ static void kmem_cache_oob(struct kunit *test) > > { > > char *p; > > size_t size = 200; > > - struct kmem_cache *cache = kmem_cache_create("test_cache", > > - size, 0, > > - 0, NULL); > > + struct kmem_cache *cache; > > + > > + cache = kmem_cache_create("test_cache", size, 0, 0, NULL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > > + > > p = kmem_cache_alloc(cache, GFP_KERNEL); > > if (!p) { > > kunit_err(test, "Allocation failed: %s\n", __func__); > > @@ -491,11 +492,12 @@ static void kmem_cache_oob(struct kunit *test) > > } > > > > KUNIT_EXPECT_KASAN_FAIL(test, *p = p[size + OOB_TAG_OFF]); > > + > > kmem_cache_free(cache, p); > > kmem_cache_destroy(cache); > > } > > > > -static void memcg_accounted_kmem_cache(struct kunit *test) > > +static void kmem_cache_accounted(struct kunit *test) > > { > > int i; > > char *p; > > @@ -522,6 +524,32 @@ static void memcg_accounted_kmem_cache(struct kunit *test) > > kmem_cache_destroy(cache); > > } > > > > +static void kmem_cache_bulk(struct kunit *test) > > +{ > > + struct kmem_cache *cache; > > + size_t size = 200; > > + size_t p_size = 10; > > s/p_size/ARRAY_SIZE(p)/ > ? > > > + char *p[10]; > > + bool ret; > > + int i; > > + > > + cache = kmem_cache_create("test_cache", size, 0, 0, NULL); > > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > > + > > + ret = kmem_cache_alloc_bulk(cache, GFP_KERNEL, p_size, (void **)&p); > > + if (!ret) { > > + kunit_err(test, "Allocation failed: %s\n", __func__); > > + kmem_cache_destroy(cache); > > + return; > > + } > > + > > + for (i = 0; i < p_size; i++) > > + p[i][0] = p[i][size - 1] = 42; > > + > > + kmem_cache_free_bulk(cache, p_size, (void **)&p); > > + kmem_cache_destroy(cache); > > +} > > + > > static char global_array[10]; > > > > static void kasan_global_oob(struct kunit *test) > > @@ -961,7 +989,8 @@ static struct kunit_case kasan_kunit_test_cases[] = { > > KUNIT_CASE(kfree_via_page), > > KUNIT_CASE(kfree_via_phys), > > KUNIT_CASE(kmem_cache_oob), > > - KUNIT_CASE(memcg_accounted_kmem_cache), > > + KUNIT_CASE(kmem_cache_accounted), > > + KUNIT_CASE(kmem_cache_bulk), > > KUNIT_CASE(kasan_global_oob), > > KUNIT_CASE(kasan_stack_oob), > > KUNIT_CASE(kasan_alloca_oob_left), > > -- > > 2.30.0.284.gd98b1dd5eaa7-goog > > Will fix all in v3, thanks!