From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7373CA9EC6 for ; Wed, 30 Oct 2019 15:50:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 75DCE208C0 for ; Wed, 30 Oct 2019 15:50:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vQsCR0jY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75DCE208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 131856B0269; Wed, 30 Oct 2019 11:50:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BB296B026C; Wed, 30 Oct 2019 11:50:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E75AA6B026F; Wed, 30 Oct 2019 11:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id C0A026B0269 for ; Wed, 30 Oct 2019 11:50:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 65FC6181AEF30 for ; Wed, 30 Oct 2019 15:50:25 +0000 (UTC) X-FDA: 76100888010.02.camp89_5aed9ff629722 X-HE-Tag: camp89_5aed9ff629722 X-Filterd-Recvd-Size: 6171 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Oct 2019 15:50:24 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id l24so1733634pgh.10 for ; Wed, 30 Oct 2019 08:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1HBWBhajrcT+G03xiP3D90hzAEMQ/9Cl+gYkTdRzPMo=; b=vQsCR0jYieMt3vGUQBz9Y8LEOTiJOMcE3OEp3ihZ1ax/rriXHfZVmTbpavsvRGfIu9 SL+u+YxZJGGZL8Et+/ptlolpA1jGHQ9R/7j1NS0/NJqMzHT47bcc1plnFHo6wH+FP8rg 7wvXMSIATaH1ER9jdIEQD2h52B+5riPt9KTN2Qgtq7v9uojs3YhjnytgP7SVW2WwBLSc FrbDNj16ac1/IWkoUOQ4YXcRPoRHP9clTkZaU+19cu2RFpjM7xgTEXmtwMZuvelhIiLI yNiwSwyoTYplr3PkP9GtuB1X/A/iybuaAPTAU1X5A9FMcWFXXNCwVufWxiL7VYXTBvmN 51hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1HBWBhajrcT+G03xiP3D90hzAEMQ/9Cl+gYkTdRzPMo=; b=oKR2xWGaZJVQerB2NvKV8XEEFw8v0epYYiepxEJxWrNi2Ri7oUQynfQs43BExWRKq5 g9ntfpoFGoQWNmDPZjgz45S/T7t0jnCzHFS+LpsBwcU2ynMN/IpN5DRk1hIO7srZOtlz 9jmqh7dY8oLhUBImwyVEK8ObTGSbDQEojA3IiaZa1fnxUR51/4ITlgTuX4G80gOh32c+ czuM10Ur+wjaw7xKbrIJdmbeUlzMBJlsw9ciKVDdIGiFOJSQOfVLwD5GCsfwePQnp4q6 /16oOMsNs4rnN49CAL8jtWE+bWgmnYRB3lHMdGfnmkYVyL5QBsq1KKb+ltUH6i0/s9fc cIbg== X-Gm-Message-State: APjAAAX7OrYkCunhy3z9xyAfySfWxxOfQgcHCnvecnZP51l3FZxxq7Wh lXearxr2pAbH4dqIDuJQQC51oRxt5eP6eJvAQdvOIQ== X-Google-Smtp-Source: APXvYqyA/bQ+TaeUGxwjbRLXY6v6ASAcjhGbNCkSagRZR5uwa+pPNcbkKbOnPdqjmhG4UTSJJtNGLEQLzg2yRXWaiX4= X-Received: by 2002:a63:9d0f:: with SMTP id i15mr83732pgd.286.1572450623229; Wed, 30 Oct 2019 08:50:23 -0700 (PDT) MIME-Version: 1.0 References: <20191030142237.249532-1-glider@google.com> <20191030142237.249532-8-glider@google.com> In-Reply-To: <20191030142237.249532-8-glider@google.com> From: Andrey Konovalov Date: Wed, 30 Oct 2019 16:50:11 +0100 Message-ID: Subject: Re: [PATCH RFC v2 07/25] kmsan: introduce __no_sanitize_memory and __SANITIZE_MEMORY__ To: Alexander Potapenko Cc: Vegard Nossum , Dmitry Vyukov , Linux Memory Management List , Alexander Viro , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Dmitry Torokhov , Eric Dumazet , ericvh@gmail.com, Greg Kroah-Hartman , harry.wentland@amd.com, Herbert Xu , mingo@elte.hu, axboe@kernel.dk, "Martin K. Petersen" , Martin Schwidefsky , "Michael S . Tsirkin" , Michal Simek , pmladek@suse.com, sergey.senozhatsky@gmail.com, Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , wsa@the-dreams.de, gor@linux.ibm.com, iii@linux.ibm.com, Mark Rutland , Matthew Wilcox , Randy Dunlap , Marco Elver Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 30, 2019 at 3:23 PM wrote: > > __no_sanitize_memory is a function attribute that makes KMSAN > ignore the uninitialized values coming from the function's > inputs, and initialize the function's outputs. > > Functions marked with this attribute can't be inlined into functions > not marked with it, and vice versa. > > __SANITIZE_MEMORY__ is a macro that's defined iff the file is > instrumented with KMSAN. This is not the same as CONFIG_KMSAN, which is > defined for every file. > > Signed-off-by: Alexander Potapenko > To: Alexander Potapenko > Cc: Vegard Nossum > Cc: Dmitry Vyukov > Cc: linux-mm@kvack.org > > --- > > Change-Id: I1f1672652c8392f15f7ca8ac26cd4e71f9cc1e4b > --- > include/linux/compiler-clang.h | 8 ++++++++ > include/linux/compiler-gcc.h | 5 +++++ > 2 files changed, 13 insertions(+) > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index 333a6695a918..edba13a069a6 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -24,6 +24,14 @@ > #define __no_sanitize_address > #endif > > +/* KMSAN is a Clang-only tool, thus putting the defines here */ > +#if __has_feature(memory_sanitizer) > +# define __SANITIZE_MEMORY__ > +# define __no_sanitize_memory __attribute__((no_sanitize("kernel-memory"))) For KASAN with Clang we ended up choosing to use no_sanitize("address") instead of no_sanitize("kernel-address") to make it match what GCC uses. Do we want to use no_sanitize("memory") here? > +#else > +# define __no_sanitize_memory > +#endif > + > /* > * Not all versions of clang implement the the type-generic versions > * of the builtin overflow checkers. Fortunately, clang implements > diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h > index d7ee4c6bad48..e5ebc788dde4 100644 > --- a/include/linux/compiler-gcc.h > +++ b/include/linux/compiler-gcc.h > @@ -145,6 +145,11 @@ > #define __no_sanitize_address > #endif > > +/* > + * GCC doesn't support KMSAN. > + */ > +#define __no_sanitize_memory > + > #if GCC_VERSION >= 50100 > #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1 > #endif > -- > 2.24.0.rc0.303.g954a862665-goog >