From: Andrey Konovalov <andreyknvl@google.com>
To: Marco Elver <elver@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Alexander Potapenko <glider@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Elena Petrova <lenaptr@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Will Deacon <will.deacon@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime
Date: Fri, 18 Sep 2020 17:00:06 +0200 [thread overview]
Message-ID: <CAAeHK+z40FP0xJo+uc-Y49LEBTb-G54nNWqePJm9J-2SJ8v5sQ@mail.gmail.com> (raw)
In-Reply-To: <20200918125216.GD2384246@elver.google.com>
On Fri, Sep 18, 2020 at 2:52 PM Marco Elver <elver@google.com> wrote:
>
> [ Sorry for the additional email on this patch; trying to consolidate
> comments now. ]
>
> On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote:
> > Provide implementation of KASAN functions required for the hardware
> > tag-based mode. Those include core functions for memory and pointer
> > tagging (tags_hw.c) and bug reporting (report_tags_hw.c). Also adapt
> > common KASAN code to support the new mode.
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> > ---
> > Change-Id: I8a8689ba098174a4d0ef3f1d008178387c80ee1c
> > ---
> > arch/arm64/include/asm/memory.h | 4 +-
> > arch/arm64/kernel/setup.c | 1 -
> > include/linux/kasan.h | 6 +--
> > include/linux/mm.h | 2 +-
> > include/linux/page-flags-layout.h | 2 +-
> > mm/kasan/Makefile | 5 ++
> > mm/kasan/common.c | 14 +++---
> > mm/kasan/kasan.h | 17 +++++--
> > mm/kasan/report_tags_hw.c | 47 +++++++++++++++++++
> > mm/kasan/report_tags_sw.c | 2 +-
> > mm/kasan/shadow.c | 2 +-
> > mm/kasan/tags_hw.c | 78 +++++++++++++++++++++++++++++++
> > mm/kasan/tags_sw.c | 2 +-
> > 13 files changed, 162 insertions(+), 20 deletions(-)
> > create mode 100644 mm/kasan/report_tags_hw.c
> > create mode 100644 mm/kasan/tags_hw.c
> [...]
> > diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> > index 41c7f1105eaa..412a23d1546b 100644
> > --- a/mm/kasan/common.c
> > +++ b/mm/kasan/common.c
> > @@ -118,7 +118,7 @@ void kasan_free_pages(struct page *page, unsigned int order)
> > */
> > static inline unsigned int optimal_redzone(unsigned int object_size)
> > {
> > - if (IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > + if (!IS_ENABLED(CONFIG_KASAN_GENERIC))
> > return 0;
> >
> > return
> > @@ -183,14 +183,14 @@ size_t kasan_metadata_size(struct kmem_cache *cache)
> > struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache,
> > const void *object)
> > {
> > - return (void *)object + cache->kasan_info.alloc_meta_offset;
> > + return (void *)reset_tag(object) + cache->kasan_info.alloc_meta_offset;
> > }
> >
> > struct kasan_free_meta *get_free_info(struct kmem_cache *cache,
> > const void *object)
> > {
> > BUILD_BUG_ON(sizeof(struct kasan_free_meta) > 32);
> > - return (void *)object + cache->kasan_info.free_meta_offset;
> > + return (void *)reset_tag(object) + cache->kasan_info.free_meta_offset;
> > }
> >
> > void kasan_poison_slab(struct page *page)
> > @@ -272,7 +272,8 @@ void * __must_check kasan_init_slab_obj(struct kmem_cache *cache,
> > alloc_info = get_alloc_info(cache, object);
> > __memset(alloc_info, 0, sizeof(*alloc_info));
>
> Suggested edit below (assuming the line-break wasn't intentional; this
> should still be within checkpatch.pl's 100 col limit):
> ------
> - if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) ||
> - IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> + if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) || IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> object = set_tag(object,
> assign_tag(cache, object, true, false));
>
> @@ -343,8 +342,7 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object,
> redzone_end = round_up((unsigned long)object + cache->object_size,
> KASAN_GRANULE_SIZE);
>
> - if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) ||
> - IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> + if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) || IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> tag = assign_tag(cache, object, false, keep_tag);
> ------
>
> > - if (IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > + if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) ||
> > + IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> > object = set_tag(object,
> > assign_tag(cache, object, true, false));
> >
> > @@ -342,10 +343,11 @@ static void *__kasan_kmalloc(struct kmem_cache *cache, const void *object,
> > redzone_end = round_up((unsigned long)object + cache->object_size,
> > KASAN_GRANULE_SIZE);
> >
> > - if (IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > + if (IS_ENABLED(CONFIG_KASAN_SW_TAGS) ||
> > + IS_ENABLED(CONFIG_KASAN_HW_TAGS))
> > tag = assign_tag(cache, object, false, keep_tag);
> >
> > - /* Tag is ignored in set_tag without CONFIG_KASAN_SW_TAGS */
> > + /* Tag is ignored in set_tag without CONFIG_KASAN_SW/HW_TAGS */
> > kasan_unpoison_memory(set_tag(object, tag), size);
> > kasan_poison_memory((void *)redzone_start, redzone_end - redzone_start,
> > KASAN_KMALLOC_REDZONE);
> [...]
> > diff --git a/mm/kasan/report_tags_hw.c b/mm/kasan/report_tags_hw.c
> > new file mode 100644
> > index 000000000000..c2f73c46279a
> > --- /dev/null
> > +++ b/mm/kasan/report_tags_hw.c
> > @@ -0,0 +1,47 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This file contains hardware tag-based KASAN specific error reporting code.
> > + *
> > + * Copyright (c) 2020 Google, Inc.
> > + * Author: Andrey Konovalov <andreyknvl@google.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
>
> I do not think we put the "This program is ..." preamble in new files
> anymore. It should be covered by SPDX tag above.
>
> > + */
> > +
> > +#include <linux/kasan.h>
> > +#include <linux/kernel.h>
> > +#include <linux/memory.h>
> > +#include <linux/mm.h>
> > +#include <linux/string.h>
> > +#include <linux/types.h>
> [...]
> > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
> > index 4888084ecdfc..ca69726adf8f 100644
> > --- a/mm/kasan/shadow.c
> > +++ b/mm/kasan/shadow.c
> > @@ -111,7 +111,7 @@ void kasan_unpoison_memory(const void *address, size_t size)
> >
> > if (IS_ENABLED(CONFIG_KASAN_SW_TAGS))
> > *shadow = tag;
> > - else
> > + else /* CONFIG_KASAN_GENERIC */
> > *shadow = size & KASAN_GRANULE_MASK;
> > }
> > }
> > diff --git a/mm/kasan/tags_hw.c b/mm/kasan/tags_hw.c
> > new file mode 100644
> > index 000000000000..c93d43379e39
> > --- /dev/null
> > +++ b/mm/kasan/tags_hw.c
> > @@ -0,0 +1,78 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * This file contains core hardware tag-based KASAN code.
> > + *
> > + * Copyright (c) 2020 Google, Inc.
> > + * Author: Andrey Konovalov <andreyknvl@google.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
>
> I do not think we put the "This program is ..." preamble in new files
> anymore. It should be covered by SPDX tag above.
>
> > + */
> > +
> > +#include <linux/kasan.h>
> > +#include <linux/kernel.h>
> > +#include <linux/memory.h>
> > +#include <linux/mm.h>
> > +#include <linux/string.h>
> > +#include <linux/types.h>
> > +
> > +#include "kasan.h"
> > +
> > +void kasan_init_tags(void)
> > +{
> > + init_tags(KASAN_TAG_MAX);
> > +}
> > +
> > +void *kasan_reset_tag(const void *addr)
> > +{
> > + return reset_tag(addr);
> > +}
> > +
>
> To help readability, would this edit be ok?
> ------
> void kasan_poison_memory(const void *address, size_t size, u8 value)
> {
> - set_mem_tag_range(reset_tag(address),
> - round_up(size, KASAN_GRANULE_SIZE), value);
> + set_mem_tag_range(reset_tag(address), round_up(size, KASAN_GRANULE_SIZE), value);
> }
>
> void kasan_unpoison_memory(const void *address, size_t size)
> {
> - set_mem_tag_range(reset_tag(address),
> - round_up(size, KASAN_GRANULE_SIZE), get_tag(address));
> + set_mem_tag_range(reset_tag(address), round_up(size, KASAN_GRANULE_SIZE), get_tag(address));
> }
> ------
>
> > +void kasan_poison_memory(const void *address, size_t size, u8 value)
> > +{
> > + set_mem_tag_range(reset_tag(address),
> > + round_up(size, KASAN_GRANULE_SIZE), value);
> > +}
> > +
> > +void kasan_unpoison_memory(const void *address, size_t size)
> > +{
> > + set_mem_tag_range(reset_tag(address),
> > + round_up(size, KASAN_GRANULE_SIZE), get_tag(address));
> > +}
> > +
> > +u8 random_tag(void)
> > +{
> > + return get_random_tag();
> > +}
> > +
> > +bool check_invalid_free(void *addr)
> > +{
> > + u8 ptr_tag = get_tag(addr);
> > + u8 mem_tag = get_mem_tag(addr);
> > +
>
>
> Why not just:
> ------
> - if (shadow_byte == KASAN_TAG_INVALID)
> - return true;
> - if (tag != KASAN_TAG_KERNEL && tag != shadow_byte)
> - return true;
> - return false;
> + return shadow_byte == KASAN_TAG_INVALID ||
> + (tag != KASAN_TAG_KERNEL && tag != shadow_byte);
> }
> ------
>
> > + if (mem_tag == KASAN_TAG_INVALID)
> > + return true;
> > + if (ptr_tag != KASAN_TAG_KERNEL && ptr_tag != mem_tag)
> > + return true;
> > + return false;
> > +}
> > +
Will fix all these in v3, thanks!
next prev parent reply other threads:[~2020-09-18 15:00 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 21:15 [PATCH v2 00/37] kasan: add hardware tag-based mode for arm64 Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 01/37] kasan: KASAN_VMALLOC depends on KASAN_GENERIC Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 02/37] kasan: group vmalloc code Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 03/37] kasan: shadow declarations only for software modes Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 04/37] kasan: rename (un)poison_shadow to (un)poison_memory Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 05/37] kasan: rename KASAN_SHADOW_* to KASAN_GRANULE_* Andrey Konovalov
2020-09-18 8:04 ` Alexander Potapenko
2020-09-18 10:42 ` Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 06/37] kasan: only build init.c for software modes Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 07/37] kasan: split out shadow.c from common.c Andrey Konovalov
2020-09-18 8:17 ` Alexander Potapenko
2020-09-18 10:39 ` Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 08/37] kasan: rename generic/tags_report.c files Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 09/37] kasan: don't duplicate config dependencies Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 10/37] kasan: hide invalid free check implementation Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 11/37] kasan: decode stack frame only with KASAN_STACK_ENABLE Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 12/37] kasan, arm64: only init shadow for software modes Andrey Konovalov
2020-09-17 17:05 ` Catalin Marinas
2020-09-15 21:15 ` [PATCH v2 13/37] kasan, arm64: only use kasan_depth " Andrey Konovalov
2020-09-17 17:05 ` Catalin Marinas
2020-09-15 21:15 ` [PATCH v2 14/37] kasan: rename addr_has_shadow to addr_has_metadata Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 15/37] kasan: rename print_shadow_for_address to print_memory_metadata Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 16/37] kasan: kasan_non_canonical_hook only for software modes Andrey Konovalov
2020-09-15 21:15 ` [PATCH v2 17/37] kasan: rename SHADOW layout macros to META Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 18/37] kasan: separate metadata_fetch_row for each mode Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 19/37] kasan: don't allow SW_TAGS with ARM64_MTE Andrey Konovalov
2020-09-17 17:05 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 20/37] kasan: rename tags.c to tags_sw.c Andrey Konovalov
2020-09-18 9:41 ` Alexander Potapenko
2020-09-18 9:44 ` Alexander Potapenko
2020-09-18 9:46 ` Alexander Potapenko
2020-09-18 10:42 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 21/37] kasan: introduce CONFIG_KASAN_HW_TAGS Andrey Konovalov
2020-09-18 12:32 ` Marco Elver
2020-09-18 15:06 ` Andrey Konovalov
2020-09-18 15:36 ` Marco Elver
2020-09-18 15:45 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 22/37] arm64: mte: Add in-kernel MTE helpers Andrey Konovalov
2020-09-17 13:46 ` Catalin Marinas
2020-09-17 14:21 ` Vincenzo Frascino
2020-09-18 9:36 ` Catalin Marinas
2020-09-22 10:16 ` Vincenzo Frascino
2020-09-17 16:17 ` Vincenzo Frascino
2020-09-17 17:07 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 23/37] arm64: kasan: Add arch layer for memory tagging helpers Andrey Konovalov
2020-09-17 17:05 ` Catalin Marinas
2020-09-18 13:00 ` Marco Elver
2020-09-18 14:56 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 24/37] arm64: mte: Add in-kernel tag fault handler Andrey Konovalov
2020-09-17 14:03 ` Catalin Marinas
2020-09-17 14:24 ` Vincenzo Frascino
2020-09-17 14:59 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 25/37] arm64: kasan: Enable in-kernel MTE Andrey Konovalov
2020-09-17 16:35 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 26/37] arm64: mte: Convert gcr_user into an exclude mask Andrey Konovalov
2020-09-17 17:06 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 27/37] arm64: mte: Switch GCR_EL1 in kernel entry and exit Andrey Konovalov
2020-09-17 16:52 ` Catalin Marinas
2020-09-17 16:58 ` Catalin Marinas
2020-09-17 18:47 ` Vincenzo Frascino
2020-09-18 9:39 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 28/37] arm64: kasan: Enable TBI EL1 Andrey Konovalov
2020-09-17 16:54 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 29/37] arm64: kasan: Align allocations for HW_TAGS Andrey Konovalov
2020-09-17 17:06 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 30/37] kasan: define KASAN_GRANULE_SIZE " Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 31/37] kasan, x86, s390: update undef CONFIG_KASAN Andrey Konovalov
2020-09-18 10:52 ` Marco Elver
2020-09-18 15:07 ` Andrey Konovalov
2020-09-24 21:35 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 32/37] kasan, arm64: expand CONFIG_KASAN checks Andrey Konovalov
2020-09-17 17:06 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 33/37] kasan, arm64: implement HW_TAGS runtime Andrey Konovalov
2020-09-17 17:06 ` Catalin Marinas
2020-09-18 10:46 ` Marco Elver
2020-09-18 12:28 ` Andrey Konovalov
2020-09-18 12:52 ` Marco Elver
2020-09-18 15:00 ` Andrey Konovalov [this message]
2020-09-18 15:19 ` Marco Elver
2020-09-18 15:52 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 34/37] kasan, arm64: print report from tag fault handler Andrey Konovalov
2020-09-17 17:04 ` Catalin Marinas
2020-09-18 12:26 ` Andrey Konovalov
2020-09-15 21:16 ` [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata Andrey Konovalov
2020-09-18 14:44 ` Marco Elver
2020-09-18 14:55 ` Andrey Konovalov
2020-09-18 15:29 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 36/37] kasan, arm64: enable CONFIG_KASAN_HW_TAGS Andrey Konovalov
2020-09-17 17:04 ` Catalin Marinas
2020-09-15 21:16 ` [PATCH v2 37/37] kasan: add documentation for hardware tag-based mode Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAeHK+z40FP0xJo+uc-Y49LEBTb-G54nNWqePJm9J-2SJ8v5sQ@mail.gmail.com \
--to=andreyknvl@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kevin.brodsky@arm.com \
--cc=lenaptr@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox