From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDF1C433DB for ; Fri, 5 Feb 2021 20:51:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3F4B64E4E for ; Fri, 5 Feb 2021 20:51:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3F4B64E4E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0FD796B0006; Fri, 5 Feb 2021 15:51:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B0806B006C; Fri, 5 Feb 2021 15:51:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F07536B006E; Fri, 5 Feb 2021 15:51:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0196.hostedemail.com [216.40.44.196]) by kanga.kvack.org (Postfix) with ESMTP id D1C866B0006 for ; Fri, 5 Feb 2021 15:51:08 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 96100362B for ; Fri, 5 Feb 2021 20:51:08 +0000 (UTC) X-FDA: 77785409016.24.tank26_0a07000275e7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 799C61A4A5 for ; Fri, 5 Feb 2021 20:51:08 +0000 (UTC) X-HE-Tag: tank26_0a07000275e7 X-Filterd-Recvd-Size: 9336 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Feb 2021 20:51:07 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id my11so7179163pjb.1 for ; Fri, 05 Feb 2021 12:51:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WZLU4c8CFtN82E3juz+QcV9FF1JDMzfdyAO1GFaD3hY=; b=J97dVjLjNvVby8Zj4bXfcz649DPZ5fll8CrBpuA3qsFXESA71JYiLLqk+X5dDf8a0j ikNvcC0IAmPZP9XrKnHt9U/nl8zMeP6sp8swP1r7kG6gSV9cg3XGj6Ko1sTUpE2/sCAh eE5GKW8Q1KkIwGB4vAgreo8VVLF94i+b6AaR8nGGUcM0Qiyhwr/yR+/nPeNRCVugL96m epq0XpBdpwKhuGLuMCPlSb14MqbXvZ7SHT5a9B+S9itLinpXDAKG82KEXd0IK8yR48Qk LzdU3dMG8eMMwLoIGGQ+g9EqSwy3OuwJjyGscGtU9rzazozWwYDT2eo/U9O0DLq374qW H9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WZLU4c8CFtN82E3juz+QcV9FF1JDMzfdyAO1GFaD3hY=; b=LZPRDNhCqQvdhPigT+x1oqbxgu0pQ2kDLvR17UgXIfLk0NtzbOObivM0jqR11QVnnb KcRwzIvefZYhOgfKuInPyZ5oOnla9SGlo6JVJ23Im8JmB0Uaa0skM5ppolEGjNCofm9P qkEODLf4y6eenK4zVeizpO3jNRVnZoK8PpnH92lff7HHyybIP0PgVKLtuMtCsm9lmLA9 pZ6i61fOPhVZ4243p0AWMuMqe5ezImqeJ9nVlYDl219z/Qy8FRrhg++J5Fu+Bn1igojK sNpiQ72BjPgddDH0Vx99+H2KNVEwkth5OWLBk97NrarBYCbepF8JI0byNLz3U4cHTvPn FQIg== X-Gm-Message-State: AOAM531Y32IVumRU3tQsDZ0Z63OgVTKJDvQK13irFw4+4KAgZTFvmEwb F+Wu+8p8eNfDB6iTUPTNX2XRIdXHyromigmGCW89JQ== X-Google-Smtp-Source: ABdhPJyapOvhRRqZ+bQIBXS8rWxLcpUPYbQDSO/D7VDIaq2PS0n8HmEJl5SVaOYTt6EAsXuZBRAOpQBkCOHcYirmJBs= X-Received: by 2002:a17:90b:3756:: with SMTP id ne22mr5531867pjb.41.1612558266710; Fri, 05 Feb 2021 12:51:06 -0800 (PST) MIME-Version: 1.0 References: <20210204150100.GE20815@willie-the-truck> <20210204163721.91295-1-lecopzer@gmail.com> <20210205171859.GE22665@willie-the-truck> <20210205174301.GF22665@willie-the-truck> In-Reply-To: <20210205174301.GF22665@willie-the-truck> From: Andrey Konovalov Date: Fri, 5 Feb 2021 21:50:55 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC To: Will Deacon Cc: Lecopzer Chen , Andrew Morton , Ard Biesheuvel , Andrey Ryabinin , Mark Brown , Catalin Marinas , Dan Williams , Dmitry Vyukov , Alexander Potapenko , gustavoars@kernel.org, kasan-dev , Lecopzer Chen , Linux ARM , LKML , "moderated list:ARM/Mediatek SoC..." , Linux Memory Management List , Guenter Roeck , Robin Murphy , rppt@kernel.org, tyhicks@linux.microsoft.com, Vincenzo Frascino , yj.chiang@mediatek.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 5, 2021 at 6:43 PM Will Deacon wrote: > > On Fri, Feb 05, 2021 at 06:30:44PM +0100, Andrey Konovalov wrote: > > On Fri, Feb 5, 2021 at 6:19 PM Will Deacon wrote: > > > > > > On Fri, Feb 05, 2021 at 12:37:21AM +0800, Lecopzer Chen wrote: > > > > > > > > > On Thu, Feb 04, 2021 at 10:46:12PM +0800, Lecopzer Chen wrote: > > > > > > > On Sat, Jan 09, 2021 at 06:32:49PM +0800, Lecopzer Chen wrote: > > > > > > > > Linux support KAsan for VMALLOC since commit 3c5c3cfb9ef4da9 > > > > > > > > ("kasan: support backing vmalloc space with real shadow memory") > > > > > > > > > > > > > > > > Like how the MODULES_VADDR does now, just not to early populate > > > > > > > > the VMALLOC_START between VMALLOC_END. > > > > > > > > similarly, the kernel code mapping is now in the VMALLOC area and > > > > > > > > should keep these area populated. > > > > > > > > > > > > > > > > Signed-off-by: Lecopzer Chen > > > > > > > > --- > > > > > > > > arch/arm64/mm/kasan_init.c | 23 ++++++++++++++++++----- > > > > > > > > 1 file changed, 18 insertions(+), 5 deletions(-) > > > > > > > > > > > > > > > > diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c > > > > > > > > index d8e66c78440e..39b218a64279 100644 > > > > > > > > --- a/arch/arm64/mm/kasan_init.c > > > > > > > > +++ b/arch/arm64/mm/kasan_init.c > > > > > > > > @@ -214,6 +214,7 @@ static void __init kasan_init_shadow(void) > > > > > > > > { > > > > > > > > u64 kimg_shadow_start, kimg_shadow_end; > > > > > > > > u64 mod_shadow_start, mod_shadow_end; > > > > > > > > + u64 vmalloc_shadow_start, vmalloc_shadow_end; > > > > > > > > phys_addr_t pa_start, pa_end; > > > > > > > > u64 i; > > > > > > > > > > > > > > > > @@ -223,6 +224,9 @@ static void __init kasan_init_shadow(void) > > > > > > > > mod_shadow_start = (u64)kasan_mem_to_shadow((void *)MODULES_VADDR); > > > > > > > > mod_shadow_end = (u64)kasan_mem_to_shadow((void *)MODULES_END); > > > > > > > > > > > > > > > > + vmalloc_shadow_start = (u64)kasan_mem_to_shadow((void *)VMALLOC_START); > > > > > > > > + vmalloc_shadow_end = (u64)kasan_mem_to_shadow((void *)VMALLOC_END); > > > > > > > > + > > > > > > > > /* > > > > > > > > * We are going to perform proper setup of shadow memory. > > > > > > > > * At first we should unmap early shadow (clear_pgds() call below). > > > > > > > > @@ -241,12 +245,21 @@ static void __init kasan_init_shadow(void) > > > > > > > > > > > > > > > > kasan_populate_early_shadow(kasan_mem_to_shadow((void *)PAGE_END), > > > > > > > > (void *)mod_shadow_start); > > > > > > > > - kasan_populate_early_shadow((void *)kimg_shadow_end, > > > > > > > > - (void *)KASAN_SHADOW_END); > > > > > > > > + if (IS_ENABLED(CONFIG_KASAN_VMALLOC)) { > > > > > > > > > > > > > > Do we really need yet another CONFIG option for KASAN? What's the use-case > > > > > > > for *not* enabling this if you're already enabling one of the KASAN > > > > > > > backends? > > > > > > > > > > > > As I know, KASAN_VMALLOC now only supports KASAN_GENERIC and also > > > > > > KASAN_VMALLOC uses more memory to map real shadow memory (1/8 of vmalloc va). > > > > > > > > > > The shadow is allocated dynamically though, isn't it? > > > > > > > > Yes, but It's still a cost. > > > > > > > > > > There should be someone can enable KASAN_GENERIC but can't use VMALLOC > > > > > > due to memory issue. > > > > > > > > > > That doesn't sound particularly realistic to me. The reason I'm pushing here > > > > > is because I would _really_ like to move to VMAP stack unconditionally, and > > > > > that would effectively force KASAN_VMALLOC to be set if KASAN is in use. > > > > > > > > > > So unless there's a really good reason not to do that, please can we make > > > > > this unconditional for arm64? Pretty please? > > > > > > > > I think it's fine since we have a good reason. > > > > Also if someone have memory issue in KASAN_VMALLOC, > > > > they can use SW_TAG, right? > > > > > > > > However the SW_TAG/HW_TAG is not supported VMALLOC yet. > > > > So the code would be like > > > > > > > > if (IS_ENABLED(CONFIG_KASAN_GENERIC)) > > > > > > Just make this CONFIG_KASAN_VMALLOC, since that depends on KASAN_GENERIC. > > > > > > > /* explain the relationship between > > > > * KASAN_GENERIC and KASAN_VMALLOC in arm64 > > > > * XXX: because we want VMAP stack.... > > > > */ > > > > > > I don't understand the relation with SW_TAGS. The VMAP_STACK dependency is: > > > > > > depends on !KASAN || KASAN_HW_TAGS || KASAN_VMALLOC > > > > This means that VMAP_STACK can be only enabled if KASAN_HW_TAGS=y or > > if KASAN_VMALLOC=y for other modes. > > > > > > > > which doesn't mention SW_TAGS at all. So that seems to imply that SW_TAGS > > > and VMAP_STACK are mutually exclusive :( > > > > SW_TAGS doesn't yet have vmalloc support, so it's not compatible with > > VMAP_STACK. Once vmalloc support is added to SW_TAGS, KASAN_VMALLOC > > should be allowed to be enabled with SW_TAGS. This series is a step > > towards having that support, but doesn't implement it. That will be a > > separate effort. > > Ok, thanks. Then I think we should try to invert the dependency here, if > possible, so that the KASAN backends depend on !VMAP_STACK if they don't > support it, rather than silently disabling VMAP_STACK when they are > selected. SGTM. Not sure if I will get to this in the nearest future, so I filed a bug: https://bugzilla.kernel.org/show_bug.cgi?id=211581