From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E66B5C43463 for ; Fri, 18 Sep 2020 14:56:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72F9B2388B for ; Fri, 18 Sep 2020 14:56:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UpKAXNLb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72F9B2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E2A776B005A; Fri, 18 Sep 2020 10:56:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E00B26B005C; Fri, 18 Sep 2020 10:56:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D17108E0001; Fri, 18 Sep 2020 10:56:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id BBF176B005A for ; Fri, 18 Sep 2020 10:56:26 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7C0C1180AD80F for ; Fri, 18 Sep 2020 14:56:26 +0000 (UTC) X-FDA: 77276483172.01.rate89_631649d2712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 689521004A304 for ; Fri, 18 Sep 2020 14:56:26 +0000 (UTC) X-HE-Tag: rate89_631649d2712c X-Filterd-Recvd-Size: 5505 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 14:56:25 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id bg9so3124068plb.2 for ; Fri, 18 Sep 2020 07:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nPppQo1Knuq6bNt9Dk0KPBwC7NFNhQQ/T4+rrskH/0M=; b=UpKAXNLbKR/gLEzv1N/o8R1oae37pRxnVIb+/wF9aSLtEfFTe08YJs2c/eMEnyGMKP k8mXfqcJgEWeB/rotkIyM4Lfv8/HmB/7q5xpkKw3+2BdOjHc2qsElK8jxQIfDM4DBeof kzqYKQF6bmsMAigKgAXRNeggnJkFcqxw3ACgnrrquJQQ+ZL0ezLY44tAcNkaDgwXHXhk uvtmHnRvAdmaEzgvMGBgmChHO4FdacRj8KfDDOJBtfgv1bcj96vuOVxH33UUD4lY4SsE 28CaoUQ3vaqryubL5Jxfaf4V+/qXqlcrndOenAUxvFkA/j9qcVaLW99/AyCnuZqwoYBs M+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nPppQo1Knuq6bNt9Dk0KPBwC7NFNhQQ/T4+rrskH/0M=; b=UxvvMwIIaOSem3J0FwhZx9HHX+4n0RJ2spv5vB3sOp48htWrC/3pHv8bFyt8TTPFHs jMIuOrch20svbGBUt6XvMSLW+MsZJlE8CIKyv3Y3TpIqVIsFtCSgu6lRWbD33inG7dov gKkKs26DLKKgvSsEpGTUF8p87SUCwyXw2T0Rksw17YTySDBvXogLh0gHmFLylhZ+Vkf+ oAdhc2PnX+5ADJbla+frS9lKV20PPwUSwsOY4ToyObycx/M78OkE08yOTbEmxz1P3DyA x3Qtb89L9CZ4ErqbeVNhIQFFeaBzhhu0YJnbwcQDCawBgVxtQOEueuk53UGlWxYoG5qA hNWg== X-Gm-Message-State: AOAM532RyyPDrOgysk7u4hsorcFwxYPqwUAfuZgrL8LWTPCON9rEhCgZ PALr2qzi9vsAVcA40AC7iJwBHp3bH6/64Pw0uGoEJQ== X-Google-Smtp-Source: ABdhPJzTCVbQjKWCWzmwvQlbcF7xCiKysY7++hSlpO780ijsSg6AOHdCNquk7KXlEL1paRECsgpFnOpNdM3wVtiGglI= X-Received: by 2002:a17:902:b117:b029:d1:e5e7:bdf5 with SMTP id q23-20020a170902b117b02900d1e5e7bdf5mr15057635plr.85.1600440984513; Fri, 18 Sep 2020 07:56:24 -0700 (PDT) MIME-Version: 1.0 References: <20200918130037.GE2384246@elver.google.com> In-Reply-To: <20200918130037.GE2384246@elver.google.com> From: Andrey Konovalov Date: Fri, 18 Sep 2020 16:56:13 +0200 Message-ID: Subject: Re: [PATCH v2 23/37] arm64: kasan: Add arch layer for memory tagging helpers To: Marco Elver Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 3:00 PM Marco Elver wrote: > > On Tue, Sep 15, 2020 at 11:16PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > > This patch add a set of arch_*() memory tagging helpers currently only > > defined for arm64 when hardware tag-based KASAN is enabled. These helpers > > will be used by KASAN runtime to implement the hardware tag-based mode. > > > > The arch-level indirection level is introduced to simplify adding hardware > > tag-based KASAN support for other architectures in the future by defining > > the appropriate arch_*() macros. > > > > Signed-off-by: Andrey Konovalov > > Co-developed-by: Vincenzo Frascino > > Signed-off-by: Vincenzo Frascino > > --- > > Change-Id: I42b0795a28067872f8308e00c6f0195bca435c2a > > --- > > arch/arm64/include/asm/memory.h | 8 ++++++++ > > mm/kasan/kasan.h | 19 +++++++++++++++++++ > > 2 files changed, 27 insertions(+) > > > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > > index e424fc3a68cb..268a3b6cebd2 100644 > > --- a/arch/arm64/include/asm/memory.h > > +++ b/arch/arm64/include/asm/memory.h > > @@ -231,6 +231,14 @@ static inline const void *__tag_set(const void *addr, u8 tag) > > return (const void *)(__addr | __tag_shifted(tag)); > > } > > > > +#ifdef CONFIG_KASAN_HW_TAGS > > +#define arch_init_tags(max_tag) mte_init_tags(max_tag) > > +#define arch_get_random_tag() mte_get_random_tag() > > +#define arch_get_mem_tag(addr) mte_get_mem_tag(addr) > > +#define arch_set_mem_tag_range(addr, size, tag) \ > > + mte_set_mem_tag_range((addr), (size), (tag)) > > Suggested edit below, assuming you're fine with checkpatch.pl's new > 100col limit: > > -#define set_mem_tag_range(addr, size, tag) \ > - arch_set_mem_tag_range((addr), (size), (tag)) > +#define set_mem_tag_range(addr, size, tag) arch_set_mem_tag_range((addr), (size), (tag)) Will do in v3, thanks!