From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52625C433E1 for ; Thu, 27 Aug 2020 12:02:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B19622B40 for ; Thu, 27 Aug 2020 12:02:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CKVMeJcB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B19622B40 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 99FAE8E0016; Thu, 27 Aug 2020 08:02:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 950BC8E0006; Thu, 27 Aug 2020 08:02:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83F048E0016; Thu, 27 Aug 2020 08:02:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 6A6E48E0006 for ; Thu, 27 Aug 2020 08:02:39 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1D865824805A for ; Thu, 27 Aug 2020 12:02:39 +0000 (UTC) X-FDA: 77196211638.11.jam50_06171d12706c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id DB1C8180F8B82 for ; Thu, 27 Aug 2020 12:02:38 +0000 (UTC) X-HE-Tag: jam50_06171d12706c X-Filterd-Recvd-Size: 5088 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Thu, 27 Aug 2020 12:02:38 +0000 (UTC) Received: by mail-pg1-f194.google.com with SMTP id l191so3202141pgd.5 for ; Thu, 27 Aug 2020 05:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7wwPhOxGIRjLkN/opTRViTv7LvuoBwuvf4nfx6OU/cE=; b=CKVMeJcBEircN6dVAHJ/bskVCId7inXED/HGe3X/FQRoqV+Io7AGOKBBKJA6zHxFAb gOn0NYY+FFf5FSS/W81X3jXiwyuhLAc5MTSzWMajcklKc25MDYprwShYHStiq5mSQv5Q 8hb5qC1ml7G3dDeLhMSKix96eh+uRdo1PvleeDysANFs0criSweSzIMp/OprHbw61+AO dvO6+G10hwQ0awgaIqpYyR4H6TsYZKWjRnd2EOk1PkiO/9407dL5bkK5nMn+/yoZShxY RW4YdOLbm80pahqHVwOXVPKbZtJROCMUwjfJHuSmnXAk/xaIzG8mh/0Pr+DI2YKTdHpq jM3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7wwPhOxGIRjLkN/opTRViTv7LvuoBwuvf4nfx6OU/cE=; b=P2Z2/AIwpB+Bf8X6DZPpwDCYnzPLeMGPfzRwSrQ0Q282kNkSuTLqmnKbkxSN2oROaJ bYcvLgQsuKjPi9Ans+TuUVW/TNG1SVKDrDYpbgTUCBIPFRaJ80mlMTvNEfFJZ4ZeNoxu TttXE+5QVyMxECoDDlO5JnpmY83CyR/S6dhqIBBajixrKv8nBWSvJVj9S/5tI7jqSi+R XHzwOpz8kPm7RUjsmO5KBAR1qntKdEzM15IDsjcKi4nHHD8O9Tioqd4KU4ZasnrLTThB 5CAVUqc290Vt4BQl08y9xLnjFdS18OYPpcjTG8sXotz6rMgEWMz1Ax4emgdsHfnFMJzl sXUw== X-Gm-Message-State: AOAM530xLAiRUpiu5RoSjx1WTMOMbvg19qC0jBxIaJQyTx42a1SPYHCV GjtvUsd3OwCCaBN3Jb0mTDgBBQbTl9BAJzTSjfeGrA== X-Google-Smtp-Source: ABdhPJxWTmElGdsbHABsAV6DJ0YuQtSHjUbzvfvruuAVjBFut8sQeWqYvmsUPFtMJVgNihgR1cKI/TJQCPNGqjnhchE= X-Received: by 2002:a17:902:8d89:: with SMTP id v9mr15849073plo.289.1598529756898; Thu, 27 Aug 2020 05:02:36 -0700 (PDT) MIME-Version: 1.0 References: <5185661d553238884613a432cf1d71b1480a23ba.1597425745.git.andreyknvl@google.com> <20200827080442.GA29264@gaia> <56ba1b14-36af-31ea-116b-23300525398d@arm.com> In-Reply-To: <56ba1b14-36af-31ea-116b-23300525398d@arm.com> From: Andrey Konovalov Date: Thu, 27 Aug 2020 14:02:25 +0200 Message-ID: Subject: Re: [PATCH 19/35] kasan: don't allow SW_TAGS with ARM64_MTE To: Vincenzo Frascino Cc: Catalin Marinas , Dmitry Vyukov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DB1C8180F8B82 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 27, 2020 at 11:52 AM Vincenzo Frascino wrote: > > Hi Andrey, > > On 8/27/20 9:04 AM, Catalin Marinas wrote: > > On Fri, Aug 14, 2020 at 07:27:01PM +0200, Andrey Konovalov wrote: > >> Software tag-based KASAN provides its own tag checking machinery that > >> can conflict with MTE. Don't allow enabling software tag-based KASAN > >> when MTE is enabled. > >> > >> Signed-off-by: Andrey Konovalov > >> --- > >> lib/Kconfig.kasan | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > >> index b4cf6c519d71..e500c18cbe79 100644 > >> --- a/lib/Kconfig.kasan > >> +++ b/lib/Kconfig.kasan > >> @@ -69,6 +69,7 @@ config KASAN_GENERIC > >> config KASAN_SW_TAGS > >> bool "Software tag-based mode" > >> depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS > >> + depends on !ARM64_MTE > > > > I think that's better as: > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 10cf81d70657..736c32bd8905 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -131,7 +131,7 @@ config ARM64 > > select HAVE_ARCH_JUMP_LABEL > > select HAVE_ARCH_JUMP_LABEL_RELATIVE > > select HAVE_ARCH_KASAN if !(ARM64_16K_PAGES && ARM64_VA_BITS_48) > > - select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN > > + select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN && !ARM64_MTE > > select HAVE_ARCH_KGDB > > select HAVE_ARCH_MMAP_RND_BITS > > select HAVE_ARCH_MMAP_RND_COMPAT_BITS if COMPAT > > > > I agree with Catalin here, "select HAVE_ARCH_KASAN_SW_TAGS if HAVE_ARCH_KASAN && > !ARM64_MTE" should be sufficient. Sounds good, will do in v2, thanks!