From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39BA9C433E0 for ; Thu, 14 Jan 2021 15:32:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C497123A24 for ; Thu, 14 Jan 2021 15:32:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C497123A24 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0C95B8D00EA; Thu, 14 Jan 2021 10:32:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 07ADE8D008E; Thu, 14 Jan 2021 10:32:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EABA98D00EA; Thu, 14 Jan 2021 10:32:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id D21E78D008E for ; Thu, 14 Jan 2021 10:32:45 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8D091180921D0 for ; Thu, 14 Jan 2021 15:32:45 +0000 (UTC) X-FDA: 77704773090.17.crowd02_380615d27527 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 70022180CF5F9 for ; Thu, 14 Jan 2021 15:32:45 +0000 (UTC) X-HE-Tag: crowd02_380615d27527 X-Filterd-Recvd-Size: 4315 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 15:32:44 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id c13so3530940pfi.12 for ; Thu, 14 Jan 2021 07:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hhCmnieS6x/7jX7jC0A67czRT8RpEOexXMJwHSjcG8w=; b=F+h+U5OX5I2zlGXN1bvc3pRP91uslplbDiy80/f/k3e71YErhqPRypEZ0JJj/UhdKt 2AigAsEV5L/t7EwODcHMEj4p+2QgpvIc1RD6t1zDtK1H2XRQne5e5GCtxSM/hy6QryIJ 7mQjkTB+WjHmD56SIaVjqmPDXdLix3UGuFKyOHuFwxRUJE9GvjooZqnbfoB+ElDcVMCg 2W12T+MnjHX38ZLQo86AJN5z6vq3SgfSw0K0jFXy0tHmw6sHgAyTFP9XjJ+UXpnrj9TT BWNZwlOSbLBi1IpqhBalOOmwGvs3KEiemTY1vzigmGeMamDLfWBNfYBf+ca3tADpgzJn SVGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hhCmnieS6x/7jX7jC0A67czRT8RpEOexXMJwHSjcG8w=; b=Hx/7zTJxTh9E1KfLGLJl+bFWe8f0zDrK4SWTK7ih2caJjhcUtDbLutr4rvD8Ybeo4P VfwKjsX7wfNQU4vJUdK3CSy0/w+xMEp3hICwBZMWXhMHSM+m6gi4IdDQiVv26E+uaIi1 0w1Vor1t6alhC/sJ4/d7GjFotmKCnG6jHiBRVC7bAj3RTDn+CCKKOB6uNdc3CURLZDsb QL9034OC4TwYuCgVrowPp4V6L7aHvsLnVLjCnpWTQ7maTLILeTARP2FhBwFQIh5FJ2d/ iohyM66oOi7CA0+/Y/YeAvTSjecWaghYiXuREZvt16wrBNHsPMzO2xQ72Z8ewjHos9wG QIUA== X-Gm-Message-State: AOAM5326h4CcjmDbbqctMjt74Te/F4MTKsN+dYwA5BbH/nEnLRu7vCkw EzOZWffH7ufkrP1yJ0/nLquO2sTpOuZ4p21NAWjvIQ== X-Google-Smtp-Source: ABdhPJwxwjEmYCc7k3Kie++FnZeFTarrf4Gsa6+W+ZVUNd+3l6SG5jx3zUwQsiq6GdK62p4Znm8ZMaWwvuG6Lksc80s= X-Received: by 2002:a65:430b:: with SMTP id j11mr7862747pgq.130.1610638363793; Thu, 14 Jan 2021 07:32:43 -0800 (PST) MIME-Version: 1.0 References: <654bdeedde54e9e8d5d6250469966b0bdf288010.1610554432.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 14 Jan 2021 16:32:32 +0100 Message-ID: Subject: Re: [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled To: Marco Elver Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 5:39 PM Marco Elver wrote: > > On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > > > Don't run KASAN tests when it's disabled with kasan.mode=off to avoid > > corrupting kernel memory. > > > > Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e > > Signed-off-by: Andrey Konovalov > > --- > > lib/test_kasan.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > > index d9f9a93922d5..0c8279d9907e 100644 > > --- a/lib/test_kasan.c > > +++ b/lib/test_kasan.c > > @@ -47,6 +47,9 @@ static bool multishot; > > */ > > static int kasan_test_init(struct kunit *test) > > { > > + if (!kasan_enabled()) > > + return -1; > > This should WARN_ON() or pr_err(). Otherwise it's impossible to say > why the test couldn't initialize. Will do in v3, thanks!