From: Andrey Konovalov <andreyknvl@google.com>
To: Marco Elver <elver@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will.deacon@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Peter Collingbourne <pcc@google.com>,
Evgenii Stepanov <eugenis@google.com>,
Branislav Rankov <Branislav.Rankov@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled
Date: Thu, 14 Jan 2021 16:32:32 +0100 [thread overview]
Message-ID: <CAAeHK+yXQN2QWUEATrdpAuEC=s1+VSZ1JzxxJbEuhpXv3nCtAQ@mail.gmail.com> (raw)
In-Reply-To: <CANpmjNPOtohFy800icx1LU_hzuQZNMQqqTBUSDXZ_9wWO_vHWw@mail.gmail.com>
On Wed, Jan 13, 2021 at 5:39 PM Marco Elver <elver@google.com> wrote:
>
> On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov <andreyknvl@google.com> wrote:
> >
> > Don't run KASAN tests when it's disabled with kasan.mode=off to avoid
> > corrupting kernel memory.
> >
> > Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > ---
> > lib/test_kasan.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> > index d9f9a93922d5..0c8279d9907e 100644
> > --- a/lib/test_kasan.c
> > +++ b/lib/test_kasan.c
> > @@ -47,6 +47,9 @@ static bool multishot;
> > */
> > static int kasan_test_init(struct kunit *test)
> > {
> > + if (!kasan_enabled())
> > + return -1;
>
> This should WARN_ON() or pr_err(). Otherwise it's impossible to say
> why the test couldn't initialize.
Will do in v3, thanks!
prev parent reply other threads:[~2021-01-14 15:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 16:21 [PATCH v2 00/14] kasan: HW_TAGS tests support and fixes Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 01/14] kasan: prefix global functions with kasan_ Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 02/14] kasan: clarify HW_TAGS impact on TBI Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 03/14] kasan: clean up comments in tests Andrey Konovalov
2021-01-13 16:24 ` Marco Elver
2021-01-13 16:21 ` [PATCH v2 04/14] kasan: add macros to simplify checking test constraints Andrey Konovalov
2021-01-13 16:25 ` Marco Elver
2021-01-13 16:45 ` Alexander Potapenko
2021-01-13 16:21 ` [PATCH v2 05/14] kasan: add match-all tag tests Andrey Konovalov
2021-01-13 16:26 ` Marco Elver
2021-01-13 16:21 ` [PATCH v2 06/14] kasan, arm64: allow using KUnit tests with HW_TAGS mode Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 07/14] kasan: rename CONFIG_TEST_KASAN_MODULE Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 08/14] kasan: add compiler barriers to KUNIT_EXPECT_KASAN_FAIL Andrey Konovalov
2021-01-13 16:28 ` Marco Elver
2021-01-13 16:21 ` [PATCH v2 09/14] kasan: adapt kmalloc_uaf2 test to HW_TAGS mode Andrey Konovalov
2021-01-13 16:31 ` Marco Elver
2021-01-13 16:32 ` Alexander Potapenko
2021-01-13 16:21 ` [PATCH v2 10/14] kasan: fix memory corruption in kasan_bitops_tags test Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 11/14] kasan: fix bug detection via ksize for HW_TAGS mode Andrey Konovalov
2021-01-13 16:54 ` Marco Elver
2021-01-14 17:58 ` Andrey Konovalov
2021-01-14 18:01 ` Andrey Konovalov
2021-01-14 19:56 ` Marco Elver
2021-01-13 16:21 ` [PATCH v2 12/14] kasan: add proper page allocator tests Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 13/14] kasan: add a test for kmem_cache_alloc/free_bulk Andrey Konovalov
2021-01-13 16:37 ` Marco Elver
2021-01-14 15:32 ` Andrey Konovalov
2021-01-13 16:21 ` [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled Andrey Konovalov
2021-01-13 16:39 ` Marco Elver
2021-01-14 15:32 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAeHK+yXQN2QWUEATrdpAuEC=s1+VSZ1JzxxJbEuhpXv3nCtAQ@mail.gmail.com' \
--to=andreyknvl@google.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pcc@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox