From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40D9CC433DB for ; Fri, 5 Mar 2021 15:43:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD15764F69 for ; Fri, 5 Mar 2021 15:43:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD15764F69 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 534E26B0073; Fri, 5 Mar 2021 10:43:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5996B0074; Fri, 5 Mar 2021 10:43:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3863D6B0075; Fri, 5 Mar 2021 10:43:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id 17D726B0073 for ; Fri, 5 Mar 2021 10:43:38 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 729291801C63E for ; Fri, 5 Mar 2021 15:43:37 +0000 (UTC) X-FDA: 77886240474.14.EB80B71 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf26.hostedemail.com (Postfix) with ESMTP id EE49B40B8CD5 for ; Fri, 5 Mar 2021 15:43:28 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id t9so2076077pjl.5 for ; Fri, 05 Mar 2021 07:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qTbQ4CYrvEtOKN3sK9Cdx0Ymm+PDCdjrJdMZxf0RYq0=; b=lwmLF3IOiErjUcagy+4Ncf8810NXSVX+conGSxCWmNt/riBnUgVJQZVMWcg3vcnxXv 6f6wcdEu/uIoZ0KcuP0/IjGSQ0QpIdsVeQ1JJ6TE4O1dOXtmLxvyjHSp7cqN2hvewarc Yw0aNC9TY9kky0pPSGWvkHljTp486c72ju0FrI7R92ojx4ZGsWQ6e/gRElVirmLIK+WQ hWwIyIUyssBSxqzgh8oLFNsccj6aO2DCnM77KkbqIjeUEpI0IdPH6Obwp9dF09e1z4C4 8mlYPiPar785lv8uIL/0PMEEX7f7XAOvkdDyLc4UEfHY9daDyNe/L7+4tET/s1eLH4aT Nd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qTbQ4CYrvEtOKN3sK9Cdx0Ymm+PDCdjrJdMZxf0RYq0=; b=XxnCHEaeZs3u8KVvAfjMNZzz6u0MkuJPkN2s9tgdayJLQa2vmjeqnkOol+Ln3RghLJ 0RQqDC8NWN5MbvEqXD/qV+CM67PM+8hLYi9kl9n4orrH7OjlweRs1E6XDConki2m6rf1 YjGZDsDjB0FNHI6jOzI63hyfxW3zGVT6v45JRufV0e6h5AaoXKILtx91V1UuSudM/p5F LsupLf6o17Ko3/ZjI2+RsaSR59eYRQ6XRzgFZQibxIz2upK0c3akMfzSoHHG+Pn0YaTS k5bSzGpW0lZvue013P9XiVjvPqZRVMgdikc4N3S6yRLQumkjGSJIqR9LdnFatTk0wzeE VtCQ== X-Gm-Message-State: AOAM530ORUDMMWGqBW9pzpvbOcF9O7imgXpdHUe92cK8d8NPftH9DSdZ +ZNm7S09Rm122s4kVnfFepbtD+gs2061kkpAw/3CGQ== X-Google-Smtp-Source: ABdhPJzdb3CY0QwcYOqHImrSnnH70zbmg63DQ3nvCH+FSGncxT3ZHCijk26cQodq50iP8kPOOhtL3hkAiA5TAMpm3G4= X-Received: by 2002:a17:902:7898:b029:e4:182f:e31d with SMTP id q24-20020a1709027898b02900e4182fe31dmr9028328pll.13.1614959002581; Fri, 05 Mar 2021 07:43:22 -0800 (PST) MIME-Version: 1.0 References: <1aa83e48627978de8068d5e3314185f3a0d7a849.1614302398.git.andreyknvl@google.com> <20210303152355.fa7c3bcb02862ceefea5ca45@linux-foundation.org> In-Reply-To: <20210303152355.fa7c3bcb02862ceefea5ca45@linux-foundation.org> From: Andrey Konovalov Date: Fri, 5 Mar 2021 16:43:11 +0100 Message-ID: Subject: Re: [PATCH] kasan, mm: fix crash with HW_TAGS and DEBUG_PAGEALLOC To: Andrew Morton Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Christoph Hellwig , kasan-dev , Linux ARM , Linux Memory Management List , LKML , stable Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EE49B40B8CD5 X-Stat-Signature: 3smkeyg4ft1kyusr1ia4bgjzq6y7szoh Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-pj1-f44.google.com; client-ip=209.85.216.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614959008-293429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 4, 2021 at 12:23 AM Andrew Morton wrote: > > On Fri, 26 Feb 2021 02:25:37 +0100 Andrey Konovalov wrote: > > > Currently, kasan_free_nondeferred_pages()->kasan_free_pages() is called > > after debug_pagealloc_unmap_pages(). This causes a crash when > > debug_pagealloc is enabled, as HW_TAGS KASAN can't set tags on an > > unmapped page. > > > > This patch puts kasan_free_nondeferred_pages() before > > debug_pagealloc_unmap_pages(). > > > > Besides fixing the crash, this also makes the annotation order consistent > > with debug_pagealloc_map_pages() preceding kasan_alloc_pages(). > > > > This bug exists in 5.12, does it not? > > If so, is cc:stable appropriate and if so, do we have a suitable Fixes: > commit? Sure: Fixes: 94ab5b61ee16 ("kasan, arm64: enable CONFIG_KASAN_HW_TAGS") Cc: