From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463BCC433E6 for ; Wed, 27 Jan 2021 21:26:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DEA9160C3F for ; Wed, 27 Jan 2021 21:26:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEA9160C3F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ECCC68D0005; Wed, 27 Jan 2021 16:26:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B918D0001; Wed, 27 Jan 2021 16:26:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9B558D0005; Wed, 27 Jan 2021 16:26:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id 8D02F8D0001 for ; Wed, 27 Jan 2021 16:26:09 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 54214180AD830 for ; Wed, 27 Jan 2021 21:26:09 +0000 (UTC) X-FDA: 77752838058.14.base03_45051162759a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 33CA818229835 for ; Wed, 27 Jan 2021 21:26:09 +0000 (UTC) X-HE-Tag: base03_45051162759a X-Filterd-Recvd-Size: 4136 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 21:26:08 +0000 (UTC) Received: by mail-pf1-f169.google.com with SMTP id y205so2158989pfc.5 for ; Wed, 27 Jan 2021 13:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H4wYdYZxwdbWGzK2JDLYdiHMKyIE6uo335eyGMtSLco=; b=pVvARrOgazAx47oDVr+JRrz3THFq6XZdUlV/9hocdgX6rmuAoOUbnhNma9j5cf2qq9 HExK2XtTjt9AOgnHY8n0Qn9QvTUnJcA2/SYPBJg1hiPKZ56sbs8MnPAQv09rDk/XQSdK /RtYc8ClMUFRPQOONGh8q/rTjY8nf6+N1fnNWwDbWRsSK1M6fY1MqQRUpxieuX9YiCbZ wiaYOkKn9InRJYdHlt80E17MqvH5K7g5KJDMVw4V4JhRHknnHF+Sm6Km/qxJyoxi+kwc AAJYk6Hc+92YI3tl13bNmoM5OfHt7+7+VwDN502Hf28vWOJtWWjmoEyPaUsJEFUbrR+u msUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H4wYdYZxwdbWGzK2JDLYdiHMKyIE6uo335eyGMtSLco=; b=r1s3PM5KvivP2KmKbI6S+vB1VAR+QPfXObHOqDkT6M9WqA80++udFJx7cMVNmjf9Rw UdL37dE4+h8dTng8tCh+SAhXW+yZkfRsKFAGuHYWcf42nJs+6bIA53GMVHpSFoar+O+J sihF2Me/gPqyerFfjVClTJALRQ3+CoFgeJnLCitMuTFXFoKpJhPHFQRx3+gK9Dl3W5cA 9AnRHthNOVt1HVHQ8DqGqqqChemYEYau348kYgOJBTzPZm2vu+07gPWGzLHQhQYLGmvB db2D2H6teqsAWpoBEF6vemzXdpun33AxWoxK0+yuofWQCWuvAGD9+Gdoi+0VR/GxU5Vy CTlQ== X-Gm-Message-State: AOAM530wlGDLGke0eqG9triwqX4/8CCCsWUXmNUV7jnljMB3EDHYo6Tb 54uy2ep75R4zYApbw4xl8WmIQs7ZsKLb8felOs+IAw== X-Google-Smtp-Source: ABdhPJwqCNPlPDpaL1i90PWLetMonQPmkN+B816BhKFxVw2dI+707/Lr0UAOHEgTEbKHZPdYieTwKogk1rPqlXc4qsc= X-Received: by 2002:a62:18d6:0:b029:1bf:1c5f:bfa4 with SMTP id 205-20020a6218d60000b02901bf1c5fbfa4mr12428501pfy.24.1611782767499; Wed, 27 Jan 2021 13:26:07 -0800 (PST) MIME-Version: 1.0 References: <20210125112831.2156212-1-arnd@kernel.org> In-Reply-To: <20210125112831.2156212-1-arnd@kernel.org> From: Andrey Konovalov Date: Wed, 27 Jan 2021 22:25:56 +0100 Message-ID: Subject: Re: [PATCH] kasan: export kasan_poison To: Arnd Bergmann Cc: Andrey Ryabinin , Andrew Morton , Stephen Rothwell , Marco Elver , Alexander Potapenko , Arnd Bergmann , Dmitry Vyukov , Vincenzo Frascino , Walter Wu , kasan-dev , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 25, 2021 at 12:28 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The unit test module fails to build after adding a reference > to kasan_poison: > > ERROR: modpost: "kasan_poison" [lib/test_kasan.ko] undefined! > > Export this symbol to make it available to loadable modules. Could you share the config you used to trigger this? > Fixes: b9b322c2bba9 ("kasan: add match-all tag tests") > Signed-off-by: Arnd Bergmann > --- > mm/kasan/shadow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index de6b3f074742..32e7a5c148e6 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -94,6 +94,7 @@ void kasan_poison(const void *address, size_t size, u8 value) > > __memset(shadow_start, value, shadow_end - shadow_start); > } > +EXPORT_SYMBOL_GPL(kasan_poison); Should this be _GPL? All of the other EXPORT_SYMBOL() we use in KASAN are without the GPL suffix. > > void kasan_unpoison(const void *address, size_t size) > { > -- > 2.29.2 >