From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31654C43464 for ; Fri, 18 Sep 2020 14:56:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A90BD2376F for ; Fri, 18 Sep 2020 14:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="szlsuR3S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A90BD2376F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3072C6B0037; Fri, 18 Sep 2020 10:55:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B7136B005A; Fri, 18 Sep 2020 10:55:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CDB48E0001; Fri, 18 Sep 2020 10:55:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 090356B0037 for ; Fri, 18 Sep 2020 10:55:59 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AE76D3621 for ; Fri, 18 Sep 2020 14:55:58 +0000 (UTC) X-FDA: 77276481996.18.sign25_12006b42712c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 7F6A1100CCC27 for ; Fri, 18 Sep 2020 14:55:58 +0000 (UTC) X-HE-Tag: sign25_12006b42712c X-Filterd-Recvd-Size: 4305 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Sep 2020 14:55:57 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id j7so3099877plk.11 for ; Fri, 18 Sep 2020 07:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=F2wjI5wyvHuB1DQE3VdNJfmgr0lLxVLpaWfOkRz2kHI=; b=szlsuR3SmVeVfl8jR5xN/Klz+kUmjgRAAo2NJL43BVNeC6udv4XGrZ7XKb7d5K+2ZT qMdolIv4NMMLrjU7xBBKh6sYgWAisOLY7jzZpZXDsNE/7P7ZCDdSMQHmZZ2uq7piDkAY blTrBbvuxXWv6WfeQKFKPbmoc0ZMxeSO0eW4VH/5g9eYZy0WxDHuDbw7BGb5iHEB26cc b0+wo4qNPZ1Day2m3mA8xdr87XF7mk+kkt730o42ZSxAngSaacN0Dz5WtLlihMmnr7ba 3Gru7/5/vytt8+UXOrPuOWyD9Juy1ZwA5Jy1FKLzFsRg+aauUnoLF19VnG4nvaoWep/1 Y6MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=F2wjI5wyvHuB1DQE3VdNJfmgr0lLxVLpaWfOkRz2kHI=; b=ejOzjdzBsP81wqJUtzGymYrt0WXX7bqPzh70Dt9fipLtLEtyhX81xbqzXzvHwu9YmS bRxDHF+Q9xg4IvP5MnpD8UGNhov5NXzbQAYDxcVMx+nsdHTuR++jCopGRBva0zliMUER GR+74ZZp7s3ZOEtO6vlfWAMW/aurnwVvxN7TIz5phpBWPr6V/JxZreFqw269FihzdqDb xu+ddfq14YEN7oJSp9gcbIYMIiwQsEJ5xdFJWSge3By0/bwpZjawU1USLPpRv6vT3G23 1E9aFvvWbujwbcXmPCgzX4uavaMjiiKEPgWZD5PGGTFbIReKFe2RKaYq3jt7F2fA3XjF OmVQ== X-Gm-Message-State: AOAM5330JkwW9351OA1b+VTxQXTUZP2nJIF1Ye82FL0sXeWSNyf1E4ni Pe8n5xmiwbgwG6o1fvctulq+zBNd4xQl42YPgk/ubg== X-Google-Smtp-Source: ABdhPJzi1tlbDphfl6SIdhj+afAqadotLeH1GeHkXsSe+RJ+PBqLlrI2nbWKP1+GRtl8/svQfqEgm5gETw/JR/FOAqo= X-Received: by 2002:a17:902:d888:b029:d0:cb2d:f274 with SMTP id b8-20020a170902d888b02900d0cb2df274mr33383728plz.13.1600440956745; Fri, 18 Sep 2020 07:55:56 -0700 (PDT) MIME-Version: 1.0 References: <20200918144423.GF2384246@elver.google.com> In-Reply-To: <20200918144423.GF2384246@elver.google.com> From: Andrey Konovalov Date: Fri, 18 Sep 2020 16:55:45 +0200 Message-ID: Subject: Re: [PATCH v2 35/37] kasan, slub: reset tags when accessing metadata To: Marco Elver Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 18, 2020 at 4:44 PM Marco Elver wrote: > > On Tue, Sep 15, 2020 at 11:16PM +0200, Andrey Konovalov wrote: > [...] > > static void set_track(struct kmem_cache *s, void *object, > > @@ -583,7 +585,8 @@ static void set_track(struct kmem_cache *s, void *object, > > unsigned int nr_entries; > > > > metadata_access_enable(); > > - nr_entries = stack_trace_save(p->addrs, TRACK_ADDRS_COUNT, 3); > > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > > + TRACK_ADDRS_COUNT, 3); > > Suggested edit (below 100 cols): > > - nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), > - TRACK_ADDRS_COUNT, 3); > + nr_entries = stack_trace_save(kasan_reset_tag(p->addrs), TRACK_ADDRS_COUNT, 3); > Ah, yes, it's a 100 lines now :) Will do in v3, thanks!