From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6718EC433E4 for ; Mon, 25 May 2020 17:36:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E9D02073B for ; Mon, 25 May 2020 17:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vrKxB8Ua" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E9D02073B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A9AF280059; Mon, 25 May 2020 13:36:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4BE48E0008; Mon, 25 May 2020 13:36:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9604D80059; Mon, 25 May 2020 13:36:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 7CECC8E0008 for ; Mon, 25 May 2020 13:36:40 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 20320181AC9CB for ; Mon, 25 May 2020 17:36:40 +0000 (UTC) X-FDA: 76855946160.03.alley28_1d13edb8e3457 X-HE-Tag: alley28_1d13edb8e3457 X-Filterd-Recvd-Size: 6793 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 17:36:39 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id n15so200888pjt.4 for ; Mon, 25 May 2020 10:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IJjU5AD78PQmMgIoxlhUE3XdqOGH2pnJ5GvxPy/ZWeA=; b=vrKxB8Ua+XZv4ykKGQgav6FhXKVJzsqZQi6l56ji2rRpxEXy+U0uFSAqqvLXB59YM0 2msyq81bVTgHfqK1FdOumNDJOpeqzHcN+anyUyzdYd1b44EJu0EE+KyyQGK2cmGJCoIG ctxMlfJr9abZC4SFziuymzvUKKJ3ffJQ51PZUNeRBB084rim2V8/Aiq2ro76qwYi4XMO eHmtL/MBn5MCH5n6wnNm607QikhtfJzzD/tQLjCxlPOyYb9rfABOUj02gOqim7FQMVPb xd9nqr3CPh4Zc2mpGJTmD1gG6o+DuyFWZxpTMcTd86jxAvYgrndO34XI5WQhegqcftN7 iV1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IJjU5AD78PQmMgIoxlhUE3XdqOGH2pnJ5GvxPy/ZWeA=; b=DiV15onsNm5AgfSsxTxZyjs/ttlwBmDGAY7tvaENx30eXLzWtckvo6pmr9kKlcK9ax RhSyQJfp5oi9XtmqIGy4FLP0cCD0kvYd7TjJhiwzWNC4gQ+uXgcr6HZRjraC6R2Iw7Qs kC5zEmvsJ/vOIPFC8E8nwdpYi047I4jsFnDPgVA0l4DT8zHkcnw0il9hcD9iC3593pKo RU2/RH+uvat4Fz7hfst74LRN5WKnGHytxDfUGKQ5CPL4f7Z30jU2tmVSiaKIYnk4G4zt nysetE70+rz5DR1w2lP2+7ndmUzR+QiSPAslBTHR4AzqRgnzRL5pDnV+RVoW431Pdt4O YR3Q== X-Gm-Message-State: AOAM533aocL+/0C9da9Fd5R2hSCJk4XHQ/ADFMBeRqkGoxROT6LvZePY qaXFqH73CNK2OWCcZKOOdVR8PTC2O7QZr7oYi5weeA== X-Google-Smtp-Source: ABdhPJz0kSa4s6ANDBb+YqExevdOdc33aV3eoTivjXP7z1lS4l97h5suRM2uOi232ee0BDQo2/+CwFWu+Jw4ExRID7M= X-Received: by 2002:a17:90b:1994:: with SMTP id mv20mr21281595pjb.41.1590428198538; Mon, 25 May 2020 10:36:38 -0700 (PDT) MIME-Version: 1.0 References: <20200522015757.22267-1-walter-zh.wu@mediatek.com> In-Reply-To: <20200522015757.22267-1-walter-zh.wu@mediatek.com> From: Andrey Konovalov Date: Mon, 25 May 2020 19:36:27 +0200 Message-ID: Subject: Re: [PATCH v6 0/4] kasan: memorize and print call_rcu stack To: Walter Wu Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , "Paul E . McKenney" , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 22, 2020 at 3:58 AM Walter Wu wrote: > > This patchset improves KASAN reports by making them to have > call_rcu() call stack information. It is useful for programmers > to solve use-after-free or double-free memory issue. > > The KASAN report was as follows(cleaned up slightly): > > BUG: KASAN: use-after-free in kasan_rcu_reclaim+0x58/0x60 > > Freed by task 0: > kasan_save_stack+0x24/0x50 > kasan_set_track+0x24/0x38 > kasan_set_free_info+0x18/0x20 > __kasan_slab_free+0x10c/0x170 > kasan_slab_free+0x10/0x18 > kfree+0x98/0x270 > kasan_rcu_reclaim+0x1c/0x60 > > Last call_rcu(): > kasan_save_stack+0x24/0x50 > kasan_record_aux_stack+0xbc/0xd0 > call_rcu+0x8c/0x580 > kasan_rcu_uaf+0xf4/0xf8 > > Generic KASAN will record the last two call_rcu() call stacks and > print up to 2 call_rcu() call stacks in KASAN report. it is only > suitable for generic KASAN. > > This feature considers the size of struct kasan_alloc_meta and > kasan_free_meta, we try to optimize the structure layout and size > , let it get better memory consumption. > > [1]https://bugzilla.kernel.org/show_bug.cgi?id=198437 > [2]https://groups.google.com/forum/#!searchin/kasan-dev/better$20stack$20traces$20for$20rcu%7Csort:date/kasan-dev/KQsjT_88hDE/7rNUZprRBgAJ Reviewed-by: Andrey Konovalov for the series. Thanks! > > Changes since v2: > - remove new config option, default enable it in generic KASAN > - test this feature in SLAB/SLUB, it is pass. > - modify macro to be more clearly > - modify documentation > > Changes since v3: > - change recording from first/last to the last two call stacks > - move free track into kasan free meta > - init slab_free_meta on object slot creation > - modify documentation > > Changes since v4: > - change variable name to be more clearly > - remove the redundant condition > - remove init free meta-data and increasing object condition > > Changes since v5: > - add a macro KASAN_KMALLOC_FREETRACK in order to check whether > print free stack > - change printing message > - remove descriptions in Kocong.kasan > > Changes since v6: > - reuse print_stack() in print_track() > > Walter Wu (4): > rcu/kasan: record and print call_rcu() call stack > kasan: record and print the free track > kasan: add tests for call_rcu stack recording > kasan: update documentation for generic kasan > > Documentation/dev-tools/kasan.rst | 3 +++ > include/linux/kasan.h | 2 ++ > kernel/rcu/tree.c | 2 ++ > lib/test_kasan.c | 30 ++++++++++++++++++++++++++++++ > mm/kasan/common.c | 26 ++++---------------------- > mm/kasan/generic.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > mm/kasan/generic_report.c | 1 + > mm/kasan/kasan.h | 23 +++++++++++++++++++++-- > mm/kasan/quarantine.c | 1 + > mm/kasan/report.c | 54 +++++++++++++++++++++++++++--------------------------- > mm/kasan/tags.c | 37 +++++++++++++++++++++++++++++++++++++ > 11 files changed, 171 insertions(+), 51 deletions(-) > > -- > You received this message because you are subscribed to the Google Groups "kasan-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kasan-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kasan-dev/20200522015757.22267-1-walter-zh.wu%40mediatek.com.