From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB80C433E2 for ; Fri, 10 Jul 2020 12:12:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 94B1C20748 for ; Fri, 10 Jul 2020 12:12:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S4XEGO0V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94B1C20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 415956B0002; Fri, 10 Jul 2020 08:12:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C54B8D0002; Fri, 10 Jul 2020 08:12:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DAA16B0006; Fri, 10 Jul 2020 08:12:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 1855F6B0002 for ; Fri, 10 Jul 2020 08:12:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A8E9E5DF0 for ; Fri, 10 Jul 2020 12:12:09 +0000 (UTC) X-FDA: 77022053178.17.trail89_2e0be4e26ece Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id AEA24180D01B8 for ; Fri, 10 Jul 2020 12:12:06 +0000 (UTC) X-HE-Tag: trail89_2e0be4e26ece X-Filterd-Recvd-Size: 8500 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jul 2020 12:12:06 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id q17so2459304pfu.8 for ; Fri, 10 Jul 2020 05:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IN9H5ASk47JrPm/uxU0Hsrdkvt3YqGaqE3VjCA3yDW0=; b=S4XEGO0VaLS31l+1ohgQp+xPpy6vRnWQ85u38r9oeieMzDmidMouplEtyKlo0+IXwq uLRXNgZCRgSQgBTwLkui9yfwQUrkCMlwNVXXsh0f0qWBIMTl1RvnhzH0NwIexzfEmBMe OwDIogWmSYnWqXqdlgvFw1xyC014H79E8Gg0/L08xOL8cXEWs0V70zYQUvqhVsgFBiiB AVSb8iYT1ZE3nwfdMuRANwaR+hv4ENWbTyuYiFJILSiJ0pNLfYpHunvISFRzPllebYeN YRrqR6ULPhSv/RWZ/5VZnjdr/C8S7gjdOBF39ppr4v8WbDbRPlnj5D4d8GTewGdrOdIi XeEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IN9H5ASk47JrPm/uxU0Hsrdkvt3YqGaqE3VjCA3yDW0=; b=avkXLUoTbE/uXRJVjT48Mobo7xzACxUa/uxmBkbFEQPv1SMrwy0QojwSx2xUyEucUf L4izJvy+1A6BS71+F4suK+MwepgbFvDx+XRMArgLbcvb2frLBcrZuWJz9cQjyl+qN31W WQtGwzNZQZLYhWglHr2aMvweJQ60UJp2U7I0Fvtd331WGYLwYm9zeWZ025uzpfw4uWq6 5oLfh9gurc+fGQNKeA3D7IRQ4B2qbAvIqDC4Xe9WkPUYe1G4+aepe3Ygf7dBQ0OQHNbr +m4eon7MOAvjxuKe28EUUh/5DxGSipJy4LDMCpOKFnpquL6D3vz5GUiVTCU2aMg4pdoT RW5w== X-Gm-Message-State: AOAM531e+biPnw4HVCqGcCjVKXGiliADT++cU5D0CHlMSbmxVt0o8uF8 3mHBq0IwE+oHCW7wxaCOzkscJLw2ZKisEYqq/RCxTQ== X-Google-Smtp-Source: ABdhPJy+gOJaNpgIItq2bABCFa+wqMjQjvStmQq0en2QmvlofUi5wyEFQjrki4kpml7qkAbrg1008YWh+JJTlV2H88U= X-Received: by 2002:a62:52cd:: with SMTP id g196mr62897823pfb.178.1594383124718; Fri, 10 Jul 2020 05:12:04 -0700 (PDT) MIME-Version: 1.0 References: <202007092350.t5BEzzME%lkp@intel.com> <1594346070.11779.10.camel@mtksdccf07> In-Reply-To: <1594346070.11779.10.camel@mtksdccf07> From: Andrey Konovalov Date: Fri, 10 Jul 2020 14:11:53 +0200 Message-ID: Subject: Re: [hnaz-linux-mm:master 145/290] mm/kasan/report.c:185:20: error: 'struct kasan_alloc_meta' has no member named 'free_track' To: Walter Wu Cc: kernel test robot , kbuild-all@lists.01.org, Johannes Weiner , Dmitry Vyukov , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: AEA24180D01B8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000160, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 10, 2020 at 3:54 AM Walter Wu wrote: > > On Thu, 2020-07-09 at 23:34 +0800, kernel test robot wrote: > > tree: https://urldefense.com/v3/__https://github.com/hnaz/linux-mm__;!!CTRNKA9wMg0ARbw!3r5leFwzjxeyTP9aAUqGEUfLd1nx0fI3_vptGFWPtxjK1xVnFERaYP7Z44cpE7WytQ6N8A$ master > > head: 12c0de83d877ea6b9078782f10f7a4a196aa16b1 > > commit: 16d798d57643c9b50fe8922c8324081f3c5bec78 [145/290] rcu: kasan: record and print call_rcu() call stack > > config: s390-allyesconfig (attached as .config) > > compiler: s390-linux-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://urldefense.com/v3/__https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross__;!!CTRNKA9wMg0ARbw!3r5leFwzjxeyTP9aAUqGEUfLd1nx0fI3_vptGFWPtxjK1xVnFERaYP7Z44cpE7XOATg3qw$ -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout 16d798d57643c9b50fe8922c8324081f3c5bec78 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > Note: the hnaz-linux-mm/master HEAD 12c0de83d877ea6b9078782f10f7a4a196aa16b1 builds fine. > > It only hurts bisectibility. > > > > All error/warnings (new ones prefixed by >>): > > > > mm/kasan/report.c: In function 'kasan_addr_to_page': > > mm/kasan/report.c:130:12: warning: ordered comparison of pointer with null pointer [-Wextra] > > 130 | if ((addr >= (void *)PAGE_OFFSET) && > > | ^~ > > mm/kasan/report.c: In function 'kasan_get_free_track': > > >> mm/kasan/report.c:185:20: error: 'struct kasan_alloc_meta' has no member named 'free_track' > > 185 | return &alloc_meta->free_track[i]; > > | ^~ > > >> mm/kasan/report.c:172:6: warning: variable 'i' set but not used [-Wunused-but-set-variable] > > 172 | int i = 0; > > | ^ > > >> mm/kasan/report.c:186:1: warning: control reaches end of non-void function [-Wreturn-type] > > 186 | } > > | ^ > > -- > > mm/kasan/common.c: In function 'kasan_set_free_info': > > >> mm/kasan/common.c:316:23: error: 'struct kasan_alloc_meta' has no member named 'free_track' > > 316 | set_track(&alloc_meta->free_track[idx], GFP_NOWAIT); > > | ^~ > > Hi, > > It should not be a problem, this commit("rcu: kasan: record and print > call_rcu() call stack") need to depend my another commit ("kasan: record > and print the free track"). They is the same series, please see below > information. Thanks. Hi Walter, If one commit depends on another, then that one commit should go before that other one in the series. In other words, all commits from a series should be applicable one by one and the kernel should remain in a working state. Thanks! > > The series (4): > rcu: kasan: record and print call_rcu() call stack > kasan: record and print the free track > kasan: add tests for call_rcu stack recording > kasan: update documentation for generic kasan > > > > > >> mm/kasan/common.c:306:5: warning: variable 'idx' set but not used [-Wunused-but-set-variable] > > 306 | u8 idx = 0; > > | ^~~ > > > > vim +185 mm/kasan/report.c > > > > 0c06f1f86c87b1 Andrey Konovalov 2017-05-03 167 > > ae8f06b31a83e5 Walter Wu 2019-09-23 168 static struct kasan_track *kasan_get_free_track(struct kmem_cache *cache, > > ae8f06b31a83e5 Walter Wu 2019-09-23 169 void *object, u8 tag) > > ae8f06b31a83e5 Walter Wu 2019-09-23 170 { > > ae8f06b31a83e5 Walter Wu 2019-09-23 171 struct kasan_alloc_meta *alloc_meta; > > ae8f06b31a83e5 Walter Wu 2019-09-23 @172 int i = 0; > > ae8f06b31a83e5 Walter Wu 2019-09-23 173 > > ae8f06b31a83e5 Walter Wu 2019-09-23 174 alloc_meta = get_alloc_info(cache, object); > > ae8f06b31a83e5 Walter Wu 2019-09-23 175 > > ae8f06b31a83e5 Walter Wu 2019-09-23 176 #ifdef CONFIG_KASAN_SW_TAGS_IDENTIFY > > ae8f06b31a83e5 Walter Wu 2019-09-23 177 for (i = 0; i < KASAN_NR_FREE_STACKS; i++) { > > ae8f06b31a83e5 Walter Wu 2019-09-23 178 if (alloc_meta->free_pointer_tag[i] == tag) > > ae8f06b31a83e5 Walter Wu 2019-09-23 179 break; > > ae8f06b31a83e5 Walter Wu 2019-09-23 180 } > > ae8f06b31a83e5 Walter Wu 2019-09-23 181 if (i == KASAN_NR_FREE_STACKS) > > ae8f06b31a83e5 Walter Wu 2019-09-23 182 i = alloc_meta->free_track_idx; > > ae8f06b31a83e5 Walter Wu 2019-09-23 183 #endif > > ae8f06b31a83e5 Walter Wu 2019-09-23 184 > > ae8f06b31a83e5 Walter Wu 2019-09-23 @185 return &alloc_meta->free_track[i]; > > ae8f06b31a83e5 Walter Wu 2019-09-23 @186 } > > ae8f06b31a83e5 Walter Wu 2019-09-23 187 > > > > :::::: The code at line 185 was first introduced by commit > > :::::: ae8f06b31a83e54777514308a63f669a1fed519e kasan: add memory corruption identification for software tag-based mode > > > > :::::: TO: Walter Wu > > :::::: CC: Linus Torvalds > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://urldefense.com/v3/__https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org__;!!CTRNKA9wMg0ARbw!3r5leFwzjxeyTP9aAUqGEUfLd1nx0fI3_vptGFWPtxjK1xVnFERaYP7Z44cpE7XCqxNtRA$ >