From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6FAC433E0 for ; Mon, 11 Jan 2021 19:03:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A98522A84 for ; Mon, 11 Jan 2021 19:03:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A98522A84 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 747516B0196; Mon, 11 Jan 2021 14:03:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7DC6B019A; Mon, 11 Jan 2021 14:03:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C93F6B019B; Mon, 11 Jan 2021 14:03:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 466B96B0196 for ; Mon, 11 Jan 2021 14:03:49 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0C52C1EE6 for ; Mon, 11 Jan 2021 19:03:49 +0000 (UTC) X-FDA: 77694418578.24.act69_551820d2750f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id C67561A4BE for ; Mon, 11 Jan 2021 19:03:42 +0000 (UTC) X-HE-Tag: act69_551820d2750f X-Filterd-Recvd-Size: 4271 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 19:03:42 +0000 (UTC) Received: by mail-pf1-f172.google.com with SMTP id w2so479940pfc.13 for ; Mon, 11 Jan 2021 11:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0M90n7WjWo+X1yIVKHdOTyfvfwcWqL9tkBr22HLMVsY=; b=mQxWWfxrpoJqQpQ0teH0JWLWjRlCD6LzwnF9DaADN1VituMO7/JZhJSc19maKjmKa0 XAhLsG6GziZLcTS2nrs4aZgJyR1MwzUKmkGihnYT4kRyKGczg0UL7kcyLDEfJM67gV4o C6Qe1DfX/qHHCoZSiQr1IC3yt5haB46iMoLbiVigq5Z4Wk9LZWV1EsqDj7jVKI0Idjm+ 9FgiQytvEQ6ZkCGZeiYITKvdh+L8AFRXr2eHwaMMEDY3+zyb7fJvMawbCCycvQOicRPY 459LZinhBEH0OuPe0NVfJ99MWMN4iZoQOUkf3GKueztCB5U3p47j+G6zeNylLPU3TE3A l7/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0M90n7WjWo+X1yIVKHdOTyfvfwcWqL9tkBr22HLMVsY=; b=euU9x/PAxoGDWv0+PpsJRySImsv1nPTVyVAXc2KUn1c0gAXulZrGecWuRyA2HrAqqv B1UdiaDqea9V59r440iqsjStN5kuUS4TklvlorVBr9tyNnaQFmoHRWezly6tPJuE/XI7 KpmZtymu5ufrWdm2Sl6yCl/uH97Plcbs8gn9nnsYeYMbnycAkKoRkEWHUwmYuAzQTunQ YlMji8XOkKq5w0J1RdU3pP4wxhUMdsW5E/K6dPZbSqZNryF5yDO7WKGm05sbcHNLMegQ nOJylTDUghEy3b/znkGv7qITkBIbtFFLaUlmESFpo6GdYSuoQXB0HYYjnLc0Z2Rp0A6m vVhg== X-Gm-Message-State: AOAM531SicBE/dRkBFC9mCD0n/vyNnk4xgOhAfjvJhdK7iHB2bgm7QsY PbemTvXZMtD8nkDjfkQSPWIqxvUHoKWjkdSOtq+zkw== X-Google-Smtp-Source: ABdhPJwE4imAaZmMhSvygLJ7bWjPPKzRbOvPeN2tNIIdl6OeQBhwMi9C6hF05YOIW4ESl/Tn4KeOeJ11tsXFRkISwUg= X-Received: by 2002:a62:14c4:0:b029:19d:d3f5:c304 with SMTP id 187-20020a6214c40000b029019dd3f5c304mr991822pfu.55.1610391820883; Mon, 11 Jan 2021 11:03:40 -0800 (PST) MIME-Version: 1.0 References: <20210108040940.1138-1-walter-zh.wu@mediatek.com> <20210111185902.GA2112090@ubuntu-m3-large-x86> In-Reply-To: <20210111185902.GA2112090@ubuntu-m3-large-x86> From: Andrey Konovalov Date: Mon, 11 Jan 2021 20:03:29 +0100 Message-ID: Subject: Re: [PATCH v3] kasan: remove redundant config option To: Nathan Chancellor Cc: Walter Wu , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , "moderated list:ARM/Mediatek SoC..." Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 7:59 PM Nathan Chancellor wrote: > > > > -config KASAN_STACK_ENABLE > > > +config KASAN_STACK > > > bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST > > > > Does this syntax mean that KASAN_STACK is only present for > > CC_IS_CLANG? Or that it can only be disabled for CC_IS_CLANG? > > It means that the option can only be disabled for clang. OK, got it. > > Anyway, I think it's better to 1. allow to control KASAN_STACK > > regardless of the compiler (as it was possible before), and 2. avoid > > It has never been possible to control KASAN_STACK for GCC because of the > bool ... if ... syntax. This patch does not change that logic. Making it > possible to control KASAN_STACK with GCC seems fine but that is going to > be a new change that would probably be suited for a new patch on top of > this one. The if syntax was never applied to KASAN_STACK, only to KASAN_STACK_ENABLE, so it should have been possible (although I've never specifically tried it).