From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 465E1C4727E for ; Thu, 1 Oct 2020 21:59:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D671D206FC for ; Thu, 1 Oct 2020 21:59:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="TBqS7OT7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D671D206FC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 256A56B005C; Thu, 1 Oct 2020 17:59:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE666B0062; Thu, 1 Oct 2020 17:59:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07FC36B0068; Thu, 1 Oct 2020 17:59:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id C5ED76B005C for ; Thu, 1 Oct 2020 17:59:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 53E3F180AD815 for ; Thu, 1 Oct 2020 21:59:23 +0000 (UTC) X-FDA: 77324723406.04.seat65_11053982719e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 33A73800CE7A for ; Thu, 1 Oct 2020 21:59:23 +0000 (UTC) X-HE-Tag: seat65_11053982719e X-Filterd-Recvd-Size: 4666 Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 1 Oct 2020 21:59:22 +0000 (UTC) Received: by mail-pj1-f66.google.com with SMTP id e15so824697pjg.0 for ; Thu, 01 Oct 2020 14:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FeLdvrmRrEjRDvLDp8IMeU8yTFWoBJ46ycNhebnMFYM=; b=TBqS7OT7BDG31xwQf95dhSonRR7ScCBFJKbqe4+XrINEJhqRuwnwgecZy7tTH6Nbns YscWwEDlIRlXGm+eBANlE7YicDfj9W1zjh3Ai23OT/VkZ75yEvb10oPH0BRMtXGB5/FP SpV1t5iHjIK3U34Z2OcjJt8GHt4bh+Y0WuFKllrEcyEEknpCOlbICWc0tfrzeebR+iYC Xh2CLK5kSrDevWj2ZKC1LpJMQt+XO/y1J9LwIDbsPzVYdhOXELyUImVa0CT6kq1Fd2UH +Un4kzN92nO46jJYOMrF/tUbxyzk2h1Wv7J5owXuUB5RNIkn637p/9vkkyYWkQBaFgrS 8Z9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FeLdvrmRrEjRDvLDp8IMeU8yTFWoBJ46ycNhebnMFYM=; b=sgHpSdwzjWCbQ3gH3iRp2ViZPl3c9BRrVo2HqKnqrvRTkFfw1QYs7g+qfKeNeaMxaI xnaf+/N2f54O1Q0ae+U1qszLJcyQQD2DRncdMBXRPzsFSC+XH0xRxVY6Sjpz68J9YNGo wPKUF2328bKy61JxjX0PphbdAmZM18UbAZVuP0lMSULIa7eejMWXGZ0Wghf5qzbx6ui7 Bi7nQkldpC95RKgq2Rk2PZo2RgSf6aVbb6x9mYqFvFURQhOqQvRXoOBzfyspTfWggiWz uDYJw375FmeV/YNstT9dDPZS6aJJcpCv3wrobXW/XsDsqZj/M3B63l1MIIXsqpAstbfM xlXQ== X-Gm-Message-State: AOAM531ce8wx0JXGDndjl03zVYQt0OXq0VK4mxMG2y/kG4RQTACsiJtc J5zP7rhhRaz9SguRN+6Fkd2C/3g7Di1lVaWSh6hcIQ== X-Google-Smtp-Source: ABdhPJxpDAhEXXXNzU+k6JEzSlS5oCCC+YHdJ+RToQDBqDvmlBKjtro0xxou2/hL4BdFQAB3kvq6JYo3NiocZoxZbww= X-Received: by 2002:a17:90b:140c:: with SMTP id jo12mr1907027pjb.41.1601589561599; Thu, 01 Oct 2020 14:59:21 -0700 (PDT) MIME-Version: 1.0 References: <08b7f7fe6b20f6477fa2a447a931b3bbb1ad3121.1600987622.git.andreyknvl@google.com> <20201001175841.GS4162920@elver.google.com> In-Reply-To: <20201001175841.GS4162920@elver.google.com> From: Andrey Konovalov Date: Thu, 1 Oct 2020 23:59:10 +0200 Message-ID: Subject: Re: [PATCH v3 32/39] kasan: define KASAN_GRANULE_SIZE for HW_TAGS To: Marco Elver Cc: Dmitry Vyukov , Vincenzo Frascino , Catalin Marinas , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Evgenii Stepanov , Elena Petrova , Branislav Rankov , Kevin Brodsky , Will Deacon , Andrew Morton , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 1, 2020 at 7:58 PM wrote: > > On Fri, Sep 25, 2020 at 12:50AM +0200, Andrey Konovalov wrote: > > Hardware tag-based KASAN has granules of MTE_GRANULE_SIZE. Define > > KASAN_GRANULE_SIZE to MTE_GRANULE_SIZE for CONFIG_KASAN_HW_TAGS. > > > > Signed-off-by: Andrey Konovalov > > Signed-off-by: Vincenzo Frascino > > Reviewed-by: Marco Elver > > > --- > > Change-Id: I5d1117e6a991cbca00d2cfb4ba66e8ae2d8f513a > > --- > > mm/kasan/kasan.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index 9c73f324e3ce..bd51ab72c002 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -5,7 +5,13 @@ > > #include > > #include > > > > +#if defined(CONFIG_KASAN_GENERIC) || defined(CONFIG_KASAN_SW_TAGS) > > #define KASAN_GRANULE_SIZE (1UL << KASAN_SHADOW_SCALE_SHIFT) > > +#else > > +#include > > +#define KASAN_GRANULE_SIZE (MTE_GRANULE_SIZE) > > Why braces? Shouldn't MTE_GRANULE_SIZE already have braces? Will fix in v4, thanks! > > > +#endif > > + > > #define KASAN_GRANULE_MASK (KASAN_GRANULE_SIZE - 1) > > #define KASAN_GRANULE_PAGE (KASAN_GRANULE_SIZE << PAGE_SHIFT) > > > > -- > > 2.28.0.681.g6f77f65b4e-goog > >