From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E834C5517A for ; Thu, 5 Nov 2020 17:27:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 176CA22203 for ; Thu, 5 Nov 2020 17:27:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jTkbl9gK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 176CA22203 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 934CC6B0160; Thu, 5 Nov 2020 12:27:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E42F6B0161; Thu, 5 Nov 2020 12:27:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FAC66B0162; Thu, 5 Nov 2020 12:27:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 511CD6B0160 for ; Thu, 5 Nov 2020 12:27:45 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E89E7180AD802 for ; Thu, 5 Nov 2020 17:27:44 +0000 (UTC) X-FDA: 77451046848.23.bread67_0d03f25272cb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id C5EB737606 for ; Thu, 5 Nov 2020 17:27:44 +0000 (UTC) X-HE-Tag: bread67_0d03f25272cb X-Filterd-Recvd-Size: 5044 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Nov 2020 17:27:44 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id x13so1877904pfa.9 for ; Thu, 05 Nov 2020 09:27:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yuHzlMA7AoHCHwuNKz7UkjzBoF493bgOUUuEIK52/Ng=; b=jTkbl9gKmVYO+cklCUCK9GhPlwXZpP/eRPazY+vkRQOXb2zNd1Tae+l9SHSVBeDyta hoQxUZ12h+s+kk976C5uM/mgr6PRi1eY5qYbmdLZPmwg4U1AyurkhJ+/gR13Tzr59Gyt xYMMFMf4ZgnHj0/EHdA3fEQ8rP8KOpwFbP6l3HrFMknBh/HjK4Dn5njwqLxfMKYySuoC ftufPWBWeVCQDyWf6NIjADSczrqR1kySP8rtAgBxwZ7worfq1nISp/eMSqurFQ6K5+pT 3Y/ReZjdEwpdqM8ywGfmRn4Ph5+AUh9e8Y/Rs/rFfX8AUbIIPuyRZfWhxxmsLb2rzWGd PMsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yuHzlMA7AoHCHwuNKz7UkjzBoF493bgOUUuEIK52/Ng=; b=Ec5XK/VFNgBJUjLCoSHjozGp/rknosHJKiZPGosBEA/tGM5lEEs+kv41yQBdenZlCj jh4KL6G6z1CQb/UjR32GAs9PMNfDM7DuIODj84N1l+Cad9UOYaEykUsRc5pkNptZNQvZ 1+RDrp/vz1jtq190GQIUUBlvD+EkiNBfbonKwmYpxl1zczrRNpElP8D532qGbphVVBln rRtdpNmsiJzvM95qN2ld8dN4JKNGeO9fDgvi+wNNDyuUQk9F/dCQ85U3kW+IDq865mTI ULaG7WGCEIewqN3Svhr/NvmF3dnQMGepQDzQwpd0CL75pVK8oSA87OPh4py+WTdhv+CB EMJg== X-Gm-Message-State: AOAM531oTfF2lCwM6fd74rfmBFBMT3dbIHAZ3EybZu25tyltxgQrfBti 9fPyv3v+Qm7vQZAAOBDxv1A+pbcpkS8os0+xquEwfQ== X-Google-Smtp-Source: ABdhPJzm8rx2kfyU6P+3/OZ5yfCI1h38ArCi88KHBja812HJd/VliAbeXcpV/Z3RBiGsSE5gLPMUKkHrAFo656qk1Jk= X-Received: by 2002:a62:cec6:0:b029:18a:d620:6b86 with SMTP id y189-20020a62cec60000b029018ad6206b86mr3384207pfg.2.1604597263116; Thu, 05 Nov 2020 09:27:43 -0800 (PST) MIME-Version: 1.0 References: <5e3c76cac4b161fe39e3fc8ace614400bc2fb5b1.1604531793.git.andreyknvl@google.com> <58aae616-f1be-d626-de16-af48cc2512b0@arm.com> <1ef3f645-8b91-cfcf-811e-85123fea90fa@arm.com> <090ab218-8566-772b-648f-00001413fef2@arm.com> In-Reply-To: <090ab218-8566-772b-648f-00001413fef2@arm.com> From: Andrey Konovalov Date: Thu, 5 Nov 2020 18:27:32 +0100 Message-ID: Subject: Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE To: Vincenzo Frascino Cc: Catalin Marinas , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 5, 2020 at 3:14 PM Vincenzo Frascino wrote: > > > > On 11/5/20 12:14 PM, Andrey Konovalov wrote: > > On Thu, Nov 5, 2020 at 12:39 PM Vincenzo Frascino > > wrote: > >> > >> On 11/5/20 11:35 AM, Andrey Konovalov wrote: > >>> This will work. Any preference on the name of this function? > >>> > >> > >> I called it in my current iteration mte_enable(), and calling it from > >> cpu_enable_mte(). > >> > >>> Alternatively we can rename mte_init_tags() to something else and let > >>> it handle both RRND and sync/async. > >> > >> This is an option but then you need to change the name of kasan_init_tags and > >> the init_tags indirection name as well. I would go for the simpler and just > >> splitting the function as per above. > >> > >> What do you think? > > > > OK, let's split. mte_enable() as a name sounds good to me. Both > > functions will still be called one right after another from > > kasan_init_hw_tags (as it's now called) though. I think the name > > works, as it means initializing the hw_tags mode, not just the tags. > > > > I agree. When you finish with v9, could you please provide a tree with both the > sets on top similar to [1]? I would like to repeat the tests (ltp + kselftests) > and even to rebase my async code on top of it since we are aligning with the > development. > > [1] https://github.com/xairy/linux/tree/up-boot-mte-v1 Sure, will share the trees, probably later today.