From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FD2DC2D0E4 for ; Mon, 23 Nov 2020 13:52:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D42782075A for ; Mon, 23 Nov 2020 13:52:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WwhwzWGg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D42782075A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E85FE6B007E; Mon, 23 Nov 2020 08:52:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E34B66B0080; Mon, 23 Nov 2020 08:52:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D718B6B0081; Mon, 23 Nov 2020 08:52:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id A98DF6B007E for ; Mon, 23 Nov 2020 08:52:57 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 55DED1F08 for ; Mon, 23 Nov 2020 13:52:57 +0000 (UTC) X-FDA: 77515823994.05.book31_230319d27365 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 3BC5C1802850B for ; Mon, 23 Nov 2020 13:52:57 +0000 (UTC) X-HE-Tag: book31_230319d27365 X-Filterd-Recvd-Size: 4759 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 13:52:56 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id v21so14338581pgi.2 for ; Mon, 23 Nov 2020 05:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=088zmG11B7ENQeStfIt/hKr66YTpt35vQc34h9N/mec=; b=WwhwzWGgg7krqxKQSWo7qxirBtmz/vdt/6j2DSW4AJ7H0uqC3m0kiJkpBJUucnhIRU regOTZnXOw2Mi23u2xxBoyTAQh/+fHvAJiccNvPdxWN9U1cHeo5sE6tGyzX0cIJPLlaY w+fAPAny5FGyPfO2+0RttYdgJ/tRMrSPdYmX/bNX94ViHoyZGhRhVEIY+W8zmX6IGNA8 nYevFmxgPTO18WEhkQw1uKz+URUyhtoqWU862+CeihUSza4nYw9m5qwhbWsJX9A2o3vA ZgvgnUnLQMI93t7IHi6NpCMu3KZnsu+UZObEw5s6dTmcEThWCXXZcWNZJ5cGrp5dTKMq 9EKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=088zmG11B7ENQeStfIt/hKr66YTpt35vQc34h9N/mec=; b=cl4/gOkYcYyercYPIPvKYwukoyB6EFjGAIj/SQXQ49dl3rLrDlXjAmB0WrksyvbR1v WS57KutOv2F8txjFihxmAeQ9oymkGR7lUk5BCXoT/hN5oQ3rCIskmjjhgw11Oy8ooxwo 77GM7uOClKqVpjy3iHjQX34GxBI9VG2AGvA2graksccw9K/Z9hzfqMgPEML5LPCG9n61 ZRkbWp7d7puRBddC+pUbxM76dHrhk1HXthRhA3gWToyyUlSQFt5MoqJDLqHg0CnAgnQY J/MbL3GQ2WG/ngmMmZpEF7xSif7gpGyZ11gv0NXOb9ATUVYBiTQIlLeG0uvC61IkObOB dE3g== X-Gm-Message-State: AOAM531z3NlYpDlIMPYuVp0tp4MlWpbEVYmpKl5Zr3S/RtAAtr1CUCIH qtBich1kl/85RdlR+iXA3/y877M+6MxZ/c/YBSx3/g== X-Google-Smtp-Source: ABdhPJz7/esoZcZXlaX0WzzQ5aE2SmW1dFlTaMzQH4jQHeR8+EBmkgGNvBzdbUUfdwnFOrNPM2g04JhCTBIRIMN2d9U= X-Received: by 2002:a63:f20:: with SMTP id e32mr27452713pgl.130.1606139575373; Mon, 23 Nov 2020 05:52:55 -0800 (PST) MIME-Version: 1.0 References: <6f0a1e72783ddac000ac08e7315b1d7c0ca4ec51.1605305978.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Nov 2020 14:52:44 +0100 Message-ID: Subject: Re: [PATCH mm v3 18/19] kasan, mm: allow cache merging with no metadata To: Dmitry Vyukov Cc: Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 17, 2020 at 2:25 PM Dmitry Vyukov wrote: > > On Fri, Nov 13, 2020 at 11:20 PM Andrey Konovalov wrote: > > > > The reason cache merging is disabled with KASAN is because KASAN puts its > > metadata right after the allocated object. When the merged caches have > > slightly different sizes, the metadata ends up in different places, which > > KASAN doesn't support. > > > > It might be possible to adjust the metadata allocation algorithm and make > > it friendly to the cache merging code. Instead this change takes a simpler > > approach and allows merging caches when no metadata is present. Which is > > the case for hardware tag-based KASAN with kasan.mode=prod. > > > > Co-developed-by: Vincenzo Frascino > > Signed-off-by: Vincenzo Frascino > > Signed-off-by: Andrey Konovalov > > Link: https://linux-review.googlesource.com/id/Ia114847dfb2244f297d2cb82d592bf6a07455dba > > Somehow gerrit contains an old version... so I was going to > independently propose what Marco already proposed as simplification... > until I looked at the patch in the email :) Ah, this is because I couldn't push next/mm-based changes into Gerrit without manually adding tags to all of the yet-out-of-tree patches. So the Gerrit doesn't have the last version of the patchset. > Reviewed-by: Dmitry Vyukov Thanks!