From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC13C433E0 for ; Thu, 14 Jan 2021 17:59:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB04523B53 for ; Thu, 14 Jan 2021 17:59:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB04523B53 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 970408D00F6; Thu, 14 Jan 2021 12:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9201D8D00F0; Thu, 14 Jan 2021 12:59:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8367C8D00F6; Thu, 14 Jan 2021 12:59:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 6B4698D00F0 for ; Thu, 14 Jan 2021 12:59:10 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 350573647 for ; Thu, 14 Jan 2021 17:59:10 +0000 (UTC) X-FDA: 77705142060.28.truck64_5009d3a27528 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 0AA1B6D79 for ; Thu, 14 Jan 2021 17:59:10 +0000 (UTC) X-HE-Tag: truck64_5009d3a27528 X-Filterd-Recvd-Size: 4831 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Thu, 14 Jan 2021 17:59:09 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id i5so4303850pgo.1 for ; Thu, 14 Jan 2021 09:59:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2auPNUUUKSqA2spBBB38ITsZONoHBGZrmNd5ga3XBtk=; b=PiWe9Ubm2QbW6BtuO6wL1fEVZT8NR6DfhlxC/GA4BPn/RYau9sOW2oP5qfxTt1UMO9 XyiVuuQ6BWVA5ARXyNfG78mVg4ByoWzWUloj+fqes6TlbfYPW1eV9xJhWWK2KMAI5QTo p147499r6HH/cKSonOwi6snhx0Szt/rBsw6jn1AeGGy9lkJIX5Q1wb0k07COvfYZT/+v PMlGy8Q9eeQ6qbIMFE12qQdN+1u+qWvc4IeuMrF5mNnD3qq13LS4SeJZQiOZg5U03+ll DEMJxmcI5q6jDk0F2j66wLbar9QUTyCOWR5J7DyuGOw2Nnlbthiy4yjLEsuqqDxlEa8c 2gmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2auPNUUUKSqA2spBBB38ITsZONoHBGZrmNd5ga3XBtk=; b=K/ox4/HyH0nFdJdbV8uahJq8ZyIfJqZYbrigWS1K+It1IrS/yTN2pKEjMncLc87fOo b9JlKS9CMW7Ccm8goAazfuIFewqxW2F3RVbQsDayBBiL+Vj6VQ/9j0ss1UNoko+R8Pk2 m3ocNvVqJ0yXogPsRIDEz+3QSFN8k+ewV8CChRGr6xPeZYz/FhRhp1VcAvcRwUKRdaM+ ytO5ButMwy7NV6PDTP20+X3WdtspsndYPiw/SobHdTCDdbadMpF+D8BkfxP4Tz+jH+3j hRgkcF+wE8TjN10Eq34g6/witIcGzIaKfusI7abIvrjD1Y0iakrh5HLubUXQEVT1oto5 1qaQ== X-Gm-Message-State: AOAM532WN5UxhB4wGefzfSPsLred+jeQs5enKed45rtxgPnyDwXV8orS eMW/EGk4J5HuXibYhPLHNzcAVqo95knwiPaRFMNt4A== X-Google-Smtp-Source: ABdhPJx4VS5YGc6JIdMS7jp/YUaTjt3UZQAO/wy44uVSMkIarns3UWOfwsr7qEmhIniqX6dkYtp4kq4VrEIvGKtW8XY= X-Received: by 2002:a62:e309:0:b029:1ae:5b4a:3199 with SMTP id g9-20020a62e3090000b02901ae5b4a3199mr8242200pfh.24.1610647148349; Thu, 14 Jan 2021 09:59:08 -0800 (PST) MIME-Version: 1.0 References: <77015767eb7cfe1cc112a564d31e749d68615a0f.1610554432.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 14 Jan 2021 18:58:57 +0100 Message-ID: Subject: Re: [PATCH v2 11/14] kasan: fix bug detection via ksize for HW_TAGS mode To: Marco Elver Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 5:54 PM Marco Elver wrote: > > > +bool __kasan_check_byte(const void *addr, unsigned long ip); > > +static __always_inline bool kasan_check_byte(const void *addr, unsigned long ip) > > +{ > > + if (kasan_enabled()) > > + return __kasan_check_byte(addr, ip); > > + return true; > > +} > > Why was this not added to kasan-checks.h? I'd assume including all of > kasan.h is also undesirable for tag-based modes if we just want to do > a kasan_check_byte(). > > Was requiring 'ip' intentional? Unlike the other > kasan_check-functions, this takes an explicit 'ip'. In the case of > ksize() usage, this is an advantage, so I'd probably keep it, but the > rationale to introducing 'ip' vs. before wasn't mentioned. Yes, to avoid having a ksize() frame in the report. However, I'll move _RET_IP_ inside of kasan_check_byte() as it's inline. > > +bool __kasan_check_byte(const void *address, unsigned long ip) > > +{ > > + if (!kasan_byte_accessible(address)) { > > + kasan_report((unsigned long)address, 1, false, ip); > > + return false; > > + } > > + return true; > > +} > > Like the other __kasan_check*, should this have been EXPORT_SYMBOL()? > Or was it intentional to not export as it's currently only used by > non-modules? We can add EXPORT_SYMBOL as soon as there's a need for it. Thanks!