From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A45EC5519F for ; Mon, 16 Nov 2020 13:51:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 79FAF2074B for ; Mon, 16 Nov 2020 13:51:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Qd0w7ayR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79FAF2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 20A5F6B005C; Mon, 16 Nov 2020 08:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E1AA6B005D; Mon, 16 Nov 2020 08:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AAB36B006C; Mon, 16 Nov 2020 08:51:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id D41B96B005C for ; Mon, 16 Nov 2020 08:51:00 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 726BC181AEF1E for ; Mon, 16 Nov 2020 13:51:00 +0000 (UTC) X-FDA: 77490417480.02.fold21_4d11c3c27329 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id 587F510097AA0 for ; Mon, 16 Nov 2020 13:51:00 +0000 (UTC) X-HE-Tag: fold21_4d11c3c27329 X-Filterd-Recvd-Size: 5115 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Nov 2020 13:50:59 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id q10so14203953pfn.0 for ; Mon, 16 Nov 2020 05:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Rn/GWbCehAJ+GBDtTEnmHyxU7fKIylPW3sz5YfB6oF4=; b=Qd0w7ayRM8p7I/3VxgXVb4Z+J477qPtHJvdhPbVFZ9XwhU7nk+YIXKJu4H/Ta0BwxF t9LBldP1K5XDosLSOw3/pnqneWKXcl2MAT7jJwhpfMGCFjCLG8nlIPEqNH5LXJzKdw4r hr8XIOrGSHOlI22td39a7HRCgRFjfUeDiIH734cDyKiZ68QevmkYAEuchyFDMAuLKEqZ EgO3AZ61AP3smMYLMHfqLFo23PKIeUJ90LOqKZx0qfAplIA9GMZ8oMr+8aX9VJiOh9PE bW5TpM7ui3z/vQ8pnShVeYdJ5P+56IgzT4D8odEtpOEZX5GImbBhIvwmx1hwaAFkFwc8 L4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rn/GWbCehAJ+GBDtTEnmHyxU7fKIylPW3sz5YfB6oF4=; b=UcEUjEEuJ9LjjfBO7dIlnvV5zB31PI/vIK4pkgk0dKzNRCrHHHqIUieaehC5+Su6TR DCFHwgIn4LoUo1cFbO4BKuQJVeIOYk0V3qPsxxhEoE2oGMzBB2LWe+1sFxj/n+A+gNMD Mp5IdIVoez354KZDXZM4rlmsWQMMgNTXfrdIGc6FtBYfeR/Lr1ogLXk8z6n/Hr+ReQ8z bkzKzBxIX3frYMhTfFQ7voLo9gIF7ydv8XUrQiHfye9lxS+fLnZ5RRtyr1Pwb6KX3j1A XcP+lRR3YUKzqVj4H2M7FuOkgIoRWMt4Eiup5UTKxex14qEUtHH//e4iioYHtq/QHBSw sy5w== X-Gm-Message-State: AOAM5306O356zDYdbavxcWhHWXVhENG+tTqkSldUExtSXR26SAPHe8eG 1IP7RpD0b6HWTOfSZBxNAEsER2AMBIG62m+jOx8lwQ== X-Google-Smtp-Source: ABdhPJyvNgxXCuDbqJB50x51i5+dENxPWgpyPuR9VhmAxxqRwC1mORwFApTMW9UZQkgyp1z4DmVpwkJSoeiP2hglNho= X-Received: by 2002:a63:f20:: with SMTP id e32mr12949674pgl.130.1605534658700; Mon, 16 Nov 2020 05:50:58 -0800 (PST) MIME-Version: 1.0 References: <9d4156e6-ec4f-a742-a44e-f38bf7fa9ba9@arm.com> In-Reply-To: <9d4156e6-ec4f-a742-a44e-f38bf7fa9ba9@arm.com> From: Andrey Konovalov Date: Mon, 16 Nov 2020 14:50:47 +0100 Message-ID: Subject: Re: [PATCH RFC v2 04/21] kasan: unpoison stack only with CONFIG_KASAN_STACK To: Vincenzo Frascino , Dmitry Vyukov , Marco Elver , Catalin Marinas Cc: Will Deacon , Alexander Potapenko , Evgenii Stepanov , Kostya Serebryany , Peter Collingbourne , Serban Constantinescu , Andrey Ryabinin , Elena Petrova , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Nov 16, 2020 at 1:42 PM Vincenzo Frascino wrote: > > >>>> > >>>> Not sure why we did this instead of the following, but okay. > >>>> > >>>> config KASAN_STACK > >>>> - int > >>>> - default 1 if KASAN_STACK_ENABLE || CC_IS_GCC > >>>> - default 0 > >>>> + bool > >>>> + default y if KASAN_STACK_ENABLE || CC_IS_GCC > >>>> + default n > >>> > >>> I wondered the same, but then looking at scripts/Makefile.kasan I > >>> think it's because we directly pass it to the compiler: > >>> ... > >>> $(call cc-param,asan-stack=$(CONFIG_KASAN_STACK)) \ > >>> ... > >> > >> Try this instead: > >> > >> $(call cc-param,asan-stack=$(if $(CONFIG_KASAN_STACK),1,0)) \ > > > > > > We could have just 1 config instead of 2 as well. > > For gcc we could do no prompt and default value y, and for clang -- > > prompt and default value n. I think it should do what we need. > > > > I agree with Catalin's proposal since it should simplify things. > > Nit: 'default n' is the default hence I do not think it should be required > explicitly. Fixing this sounds like a good idea, but perhaps not as a part of this series, to not overinflate it even further. I've filed a bug for this: https://bugzilla.kernel.org/show_bug.cgi?id=210221